From fa68d54687807279610973e9cae6913672524bbd Mon Sep 17 00:00:00 2001 From: rusefillc Date: Fri, 16 Feb 2024 00:25:15 -0500 Subject: [PATCH] yes we have a defect for sure! --- .../java/com/rusefi/can/reader/impl/GetValueFromTrcTest.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/reader/src/test/java/com/rusefi/can/reader/impl/GetValueFromTrcTest.java b/reader/src/test/java/com/rusefi/can/reader/impl/GetValueFromTrcTest.java index c0586e3..b2a1848 100644 --- a/reader/src/test/java/com/rusefi/can/reader/impl/GetValueFromTrcTest.java +++ b/reader/src/test/java/com/rusefi/can/reader/impl/GetValueFromTrcTest.java @@ -24,7 +24,7 @@ public class GetValueFromTrcTest { @Test public void testBigEndian() { - byte[] data = {(byte) 0xAB, 0x56}; + byte[] data = {(byte) 0xAB, 0x56, 0x34}; // hmmm assertEquals(0x56AB, DbcField.getBitRange(data, 0, 16, false)); assertEquals(0xAB56, DbcField.getBitRange(data, 8, 16, true)); @@ -34,6 +34,9 @@ public class GetValueFromTrcTest { assertEquals(0x56, DbcField.getBitRange(data, 8, 8, false)); assertEquals(0x56, DbcField.getBitRange(data, 8, 8, true)); + + // yes we have a defect for sure, we only touch two bytes at most while in this case we shall touch three bytes + assertEquals(0x56A, DbcField.getBitRange(data, 4, 16, false)); } @Test