refactoring
This commit is contained in:
parent
6dd941bfa6
commit
034156851c
|
@ -504,7 +504,6 @@ private:
|
||||||
|
|
||||||
void prepareShapes(DECLARE_ENGINE_PARAMETER_SIGNATURE);
|
void prepareShapes(DECLARE_ENGINE_PARAMETER_SIGNATURE);
|
||||||
void resetConfigurationExt(Logging * logger, engine_type_e engineType DECLARE_ENGINE_PARAMETER_SUFFIX);
|
void resetConfigurationExt(Logging * logger, engine_type_e engineType DECLARE_ENGINE_PARAMETER_SUFFIX);
|
||||||
void refreshTriggerShape(Logging * logger DECLARE_ENGINE_PARAMETER_SUFFIX);
|
|
||||||
void applyNonPersistentConfiguration(Logging * logger DECLARE_ENGINE_PARAMETER_SUFFIX);
|
void applyNonPersistentConfiguration(Logging * logger DECLARE_ENGINE_PARAMETER_SUFFIX);
|
||||||
void prepareOutputSignals(DECLARE_ENGINE_PARAMETER_SIGNATURE);
|
void prepareOutputSignals(DECLARE_ENGINE_PARAMETER_SIGNATURE);
|
||||||
|
|
||||||
|
|
|
@ -1279,14 +1279,6 @@ void validateConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void refreshTriggerShape(Logging * logger DECLARE_ENGINE_PARAMETER_SUFFIX) {
|
|
||||||
assertEngineReference();
|
|
||||||
|
|
||||||
#if EFI_ENGINE_CONTROL || defined(__DOXYGEN__)
|
|
||||||
engine->triggerCentral.triggerShape.initializeTriggerShape(logger PASS_ENGINE_PARAMETER_SUFFIX);
|
|
||||||
#endif
|
|
||||||
}
|
|
||||||
|
|
||||||
void applyNonPersistentConfiguration(Logging * logger DECLARE_ENGINE_PARAMETER_SUFFIX) {
|
void applyNonPersistentConfiguration(Logging * logger DECLARE_ENGINE_PARAMETER_SUFFIX) {
|
||||||
#if EFI_PROD_CODE || defined(__DOXYGEN__)
|
#if EFI_PROD_CODE || defined(__DOXYGEN__)
|
||||||
efiAssertVoid(getRemainingStack(chThdGetSelfX()) > 256, "apply c");
|
efiAssertVoid(getRemainingStack(chThdGetSelfX()) > 256, "apply c");
|
||||||
|
@ -1294,7 +1286,10 @@ void applyNonPersistentConfiguration(Logging * logger DECLARE_ENGINE_PARAMETER_S
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
assertEngineReference();
|
assertEngineReference();
|
||||||
refreshTriggerShape(logger PASS_ENGINE_PARAMETER_SUFFIX);
|
|
||||||
|
#if EFI_ENGINE_CONTROL || defined(__DOXYGEN__)
|
||||||
|
engine->triggerCentral.triggerShape.initializeTriggerShape(logger PASS_ENGINE_PARAMETER_SUFFIX);
|
||||||
|
#endif
|
||||||
|
|
||||||
#if EFI_FSIO || defined(__DOXYGEN__)
|
#if EFI_FSIO || defined(__DOXYGEN__)
|
||||||
applyFsioConfiguration(PASS_ENGINE_PARAMETER_SIGNATURE);
|
applyFsioConfiguration(PASS_ENGINE_PARAMETER_SIGNATURE);
|
||||||
|
|
|
@ -573,7 +573,11 @@ void onConfigurationChangeTriggerCallback(engine_configuration_s *previousConfig
|
||||||
COMPARE_CONFIG_PARAMS(bc.nb2ratioTo) ||
|
COMPARE_CONFIG_PARAMS(bc.nb2ratioTo) ||
|
||||||
COMPARE_CONFIG_PARAMS(nbVvtIndex);
|
COMPARE_CONFIG_PARAMS(nbVvtIndex);
|
||||||
if (changed) {
|
if (changed) {
|
||||||
refreshTriggerShape(logger PASS_ENGINE_PARAMETER_SUFFIX);
|
assertEngineReference();
|
||||||
|
|
||||||
|
#if EFI_ENGINE_CONTROL || defined(__DOXYGEN__)
|
||||||
|
engine->triggerCentral.triggerShape.initializeTriggerShape(logger PASS_ENGINE_PARAMETER_SUFFIX);
|
||||||
|
#endif
|
||||||
}
|
}
|
||||||
isTriggerConfigChanged = isTriggerConfigChanged || changed;
|
isTriggerConfigChanged = isTriggerConfigChanged || changed;
|
||||||
}
|
}
|
||||||
|
|
|
@ -583,7 +583,6 @@ void TriggerShape::initializeTriggerShape(Logging *logger DECLARE_ENGINE_PARAMET
|
||||||
|
|
||||||
if (engine->triggerCentral.triggerShape.getSize() == 0) {
|
if (engine->triggerCentral.triggerShape.getSize() == 0) {
|
||||||
firmwareError(CUSTOM_ERR_TRIGGER_ZERO, "triggerShape size is zero");
|
firmwareError(CUSTOM_ERR_TRIGGER_ZERO, "triggerShape size is zero");
|
||||||
return;
|
|
||||||
}
|
}
|
||||||
engine->engineCycleEventCount = getLength();
|
engine->engineCycleEventCount = getLength();
|
||||||
}
|
}
|
||||||
|
|
|
@ -276,5 +276,5 @@ int getRusEfiVersion(void) {
|
||||||
if (initBootloader() != 0)
|
if (initBootloader() != 0)
|
||||||
return 123;
|
return 123;
|
||||||
#endif /* EFI_BOOTLOADER_INCLUDE_CODE */
|
#endif /* EFI_BOOTLOADER_INCLUDE_CODE */
|
||||||
return 20180202;
|
return 20180203;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue