rusefi
/
custom-board-bundle-sample-fork-of-rusefi
mirror of https://github.com/rusefi/custom-board-bundle-sample-fork-of-rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix gppwm on-off mode (#1406) 

* fix

* put it back

* do it with PWM instead

* comments

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
This commit is contained in:
Matthew Kennedy 2020-05-09 06:25:45 -07:00 committed by GitHub
parent 94ca216936
commit 103a1693c8
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
firmware/controllers/system/timer/pwm_generator_logic.cpp
View File

@ -75,13 +75,14 @@ void SimplePwm::setSimplePwmDutyCycle(float dutyCycle) {
warning(CUSTOM_PWM_DUTY_TOO_HIGH, "%s duty %.2f", name, dutyCycle); warning(CUSTOM_PWM_DUTY_TOO_HIGH, "%s duty %.2f", name, dutyCycle);
dutyCycle = 1; dutyCycle = 1;
} }
if (dutyCycle == 0.0f && stateChangeCallback != NULL) {
/** // Handle zero and full duty cycle. This will cause the PWM output to behave like a plain digital output.
* set the pin low just to be super sure if (dutyCycle == 0.0f && stateChangeCallback) {
* this custom handling of zero value comes from CJ125 heater code // Manually fire falling edge
* TODO: is this really needed? cover by unit test?
*/
stateChangeCallback(0, arg); stateChangeCallback(0, arg);
} else if (dutyCycle == 1.0f && stateChangeCallback) {
// Manually fire rising edge
stateChangeCallback(1, arg);
} }
if (dutyCycle < ZERO_PWM_THRESHOLD) { if (dutyCycle < ZERO_PWM_THRESHOLD) {