make nucleo builds normal (#5035)

* make nucleo builds normal

* no skip for test

* don't check for `no`

* put back skips

.github/workflows/build-firmware.yaml

@@ -241,20 +241,17 @@ jobs:
 
           - build-target: stm32f429_nucleo
             folder: nucleo_f429
-            ini-file: no
-            skip-config: yes
+            ini-file: rusefi_stm32f429_nucleo.ini
 
           - build-target: stm32f767_nucleo
             folder: nucleo_f767
-            ini-file: no
+            ini-file: rusefi_stm32f767_nucleo.ini
             console-settings: firmware/config/boards/nucleo_f767/rusefi_console_properties.xml
-            skip-config: yes
             skip-rate: 95
 
           - build-target: stm32h743_nucleo
             folder: nucleo_h743
-            ini-file: no
-            skip-config: yes
+            ini-file: rusefi_stm32h743_nucleo.ini
             skip-rate: 95
 
           - build-target: subaru_eg33_f7
@@ -340,7 +337,7 @@ jobs:
       run: ./gen_enum_to_string.sh
 
     - name: Generate Configs for build-target
-      if: ${{ matrix.skip-config != 'yes' && env.skip != 'true' }}
+      if: ${{ env.skip != 'true' }}
       working-directory: ./firmware/
       # todo: we have code duplication with gen_config.sh here :(
       run: |

firmware/config/boards/nucleo_f767/board.mk

@@ -1,7 +1,7 @@
 # List of all the board related files.
 
 # F429 and F767 Nucleo are indeed the same board with a different chip fitted - so recycle the F429 config
-BOARDCPPSRC = $(BOARD_DIR)/board_configuration.cpp
+BOARDCPPSRC = $(BOARDS_DIR)/nucleo_f429/board_configuration.cpp
 
 # reducing flash consumption for EFI_ETHERNET to fit
 DDEFS += -DEFI_FILE_LOGGING=FALSE -DEFI_ALTERNATOR_CONTROL=FALSE -DEFI_LOGIC_ANALYZER=FALSE -DEFI_ENABLE_ASSERTS=FALSE

firmware/config/boards/nucleo_f767/board_configuration.cpp

@@ -1,7 +0,0 @@
-#include "pch.h"
-
-void setBoardConfigOverrides() {
-}
-
-void preHalInit() {
-}

misc/jenkins/build_working_folder.sh

@@ -33,11 +33,6 @@ ls -l $FOLDER
 wget https://rusefi.com/build_server/st_files/silent_st_drivers2.exe -P $DRIVERS_FOLDER
 [ -e $DRIVERS_FOLDER/silent_st_drivers2.exe ] || { echo "$SCRIPT_NAME: ERROR DOWNLOADING silent_st_drivers2.exe"; exit 1; }
 
-if [ "$INI_FILE_OVERRIDE" = "no" ]; then
-    INI_FILE_OVERRIDE="rusefi.ini"
-    echo "$SCRIPT_NAME: N/a ini_file_override specified"
-fi
-
 if [ -z $INI_FILE_OVERRIDE ]; then
     INI_FILE_OVERRIDE="rusefi.ini"
     echo "$SCRIPT_NAME: No ini_file_override specified"