rusefi
/
custom-board-bundle-sample-fork-of-rusefi
mirror of https://github.com/rusefi/custom-board-bundle-sample-fork-of-rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

minor fix: no need to assign same value twice

This commit is contained in:
rusefillc 2022-11-05 23:50:03 -04:00
parent 43e3fce9b1
commit 2866ba54b8
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
firmware/controllers/trigger/trigger_central.cpp
View File

@ -977,13 +977,9 @@ static void calculateTriggerSynchPoint(
triggerCentral->triggerErrorDetection.clear(); triggerCentral->triggerErrorDetection.clear();
shape.initializeSyncPoint(state, triggerCentral->primaryTriggerConfiguration); shape.initializeSyncPoint(state, triggerCentral->primaryTriggerConfiguration);
int length = shape.getLength();
triggerCentral->engineCycleEventCount = length;
efiAssertVoid(CUSTOM_SHAPE_LEN_ZERO, length > 0, "shapeLength=0");
if (shape.getSize() >= PWM_PHASE_MAX_COUNT) { if (shape.getSize() >= PWM_PHASE_MAX_COUNT) {
// todo: by the time we are here we had already modified a lot of RAM out of bounds! // todo: by the time we are here we had already modified a lot of RAM out of bounds!
firmwareError(CUSTOM_ERR_TRIGGER_WAVEFORM_TOO_LONG, "Trigger length above maximum: %d", length); firmwareError(CUSTOM_ERR_TRIGGER_WAVEFORM_TOO_LONG, "Trigger length above maximum: %d", shape.getSize());
shape.setShapeDefinitionError(true); shape.setShapeDefinitionError(true);
return; return;
} }
@ -1026,6 +1022,11 @@ void TriggerCentral::updateWaveform() {
} }
if (!triggerShape.shapeDefinitionError) { if (!triggerShape.shapeDefinitionError) {
int length = triggerShape.getLength();
engineCycleEventCount = length;
efiAssertVoid(CUSTOM_SHAPE_LEN_ZERO, length > 0, "shapeLength=0");
/** /**
* 'initState' instance of TriggerDecoderBase is used only to initialize 'this' TriggerWaveform instance * 'initState' instance of TriggerDecoderBase is used only to initialize 'this' TriggerWaveform instance
* #192 BUG real hardware trigger events could be coming even while we are initializing trigger * #192 BUG real hardware trigger events could be coming even while we are initializing trigger
@ -1033,8 +1034,6 @@ void TriggerCentral::updateWaveform() {
calculateTriggerSynchPoint(this, calculateTriggerSynchPoint(this,
triggerShape, triggerShape,
initState); initState);
engineCycleEventCount = triggerShape.getLength();
} }
for (int camIndex = 0; camIndex < CAMS_PER_BANK; camIndex++) { for (int camIndex = 0; camIndex < CAMS_PER_BANK; camIndex++) {