diff --git a/firmware/config/boards/hellen/alphax-4chan/board_configuration.cpp b/firmware/config/boards/hellen/alphax-4chan/board_configuration.cpp index 7a5a8a3388..fcb06b4a05 100644 --- a/firmware/config/boards/hellen/alphax-4chan/board_configuration.cpp +++ b/firmware/config/boards/hellen/alphax-4chan/board_configuration.cpp @@ -166,8 +166,6 @@ void setBoardDefaultConfiguration() { engineConfiguration->vvtPins[1] = H144_OUT_PWM8; engineConfiguration->boardUseTempPullUp = true; - // todo: use board ID condition? below D no SD, D and up with SD? - engineConfiguration->isSdCardEnabled = true; engineConfiguration->acSwitch = Gpio::Unassigned; engineConfiguration->fuelPumpPin = H144_OUT_IO12; diff --git a/firmware/config/boards/hellen/alphax-8chan/board_configuration.cpp b/firmware/config/boards/hellen/alphax-8chan/board_configuration.cpp index be7ed8ec14..f30f147d45 100644 --- a/firmware/config/boards/hellen/alphax-8chan/board_configuration.cpp +++ b/firmware/config/boards/hellen/alphax-8chan/board_configuration.cpp @@ -174,7 +174,6 @@ void setBoardDefaultConfiguration() { engineConfiguration->vvtPins[1] = H144_OUT_PWM8; engineConfiguration->boardUseTempPullUp = true; - engineConfiguration->isSdCardEnabled = true; engineConfiguration->mainRelayPin = H144_OUT_IO10; engineConfiguration->fanPin = H144_OUT_IO11; diff --git a/firmware/config/boards/hellen/hellen-gm-e67/board_configuration.cpp b/firmware/config/boards/hellen/hellen-gm-e67/board_configuration.cpp index 422f25d550..2285c94743 100644 --- a/firmware/config/boards/hellen/hellen-gm-e67/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen-gm-e67/board_configuration.cpp @@ -117,8 +117,6 @@ void setBoardDefaultConfiguration() { setInjectorPins(); setIgnitionPins(); - engineConfiguration->isSdCardEnabled = true; - engineConfiguration->enableSoftwareKnock = true; engineConfiguration->invertPrimaryTriggerSignal = true; diff --git a/firmware/config/boards/hellen/hellen-honda-k/board_configuration.cpp b/firmware/config/boards/hellen/hellen-honda-k/board_configuration.cpp index 49456e9916..e52a7b9439 100644 --- a/firmware/config/boards/hellen/hellen-honda-k/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen-honda-k/board_configuration.cpp @@ -99,7 +99,6 @@ void setBoardDefaultConfiguration() { setHondaK(); engineConfiguration->displayLogicLevelsInEngineSniffer = true; - engineConfiguration->isSdCardEnabled = true; engineConfiguration->globalTriggerAngleOffset = 663; diff --git a/firmware/config/boards/hellen/hellen-nb1/board_configuration.cpp b/firmware/config/boards/hellen/hellen-nb1/board_configuration.cpp index 29c900dd44..d00d23528a 100644 --- a/firmware/config/boards/hellen/hellen-nb1/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen-nb1/board_configuration.cpp @@ -90,8 +90,6 @@ void setBoardDefaultConfiguration() { setInjectorPins(); setIgnitionPins(); - engineConfiguration->isSdCardEnabled = true; - engineConfiguration->enableSoftwareKnock = true; engineConfiguration->boostControlPin = H144_LS_6; diff --git a/firmware/config/boards/hellen/hellen121nissan/board_configuration.cpp b/firmware/config/boards/hellen/hellen121nissan/board_configuration.cpp index 7ddbf6a739..3e3d5ae890 100644 --- a/firmware/config/boards/hellen/hellen121nissan/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen121nissan/board_configuration.cpp @@ -99,7 +99,6 @@ void setBoardDefaultConfiguration() { setIgnitionPins(); engineConfiguration->displayLogicLevelsInEngineSniffer = true; - engineConfiguration->isSdCardEnabled = true; engineConfiguration->enableSoftwareKnock = true; engineConfiguration->canNbcType = CAN_BUS_NBC_NONE; // none because handled by Lua! diff --git a/firmware/config/boards/hellen/hellen121vag/board_configuration.cpp b/firmware/config/boards/hellen/hellen121vag/board_configuration.cpp index c19608fd91..c117c0e21c 100644 --- a/firmware/config/boards/hellen/hellen121vag/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen121vag/board_configuration.cpp @@ -104,8 +104,6 @@ void setBoardDefaultConfiguration() { engineConfiguration->globalTriggerAngleOffset = 93; - engineConfiguration->isSdCardEnabled = true; - // todo: should this be a global default not just Hellen121? engineConfiguration->boostCutPressure = 200; diff --git a/firmware/config/boards/hellen/hellen128/board_configuration.cpp b/firmware/config/boards/hellen/hellen128/board_configuration.cpp index 3273e247ed..f2547313e7 100644 --- a/firmware/config/boards/hellen/hellen128/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen128/board_configuration.cpp @@ -157,8 +157,6 @@ void setBoardDefaultConfiguration() { setInjectorPins(); setIgnitionPins(); - engineConfiguration->isSdCardEnabled = true; - engineConfiguration->enableSoftwareKnock = true; engineConfiguration->fuelPumpPin = Gpio::D15; diff --git a/firmware/config/boards/hellen/hellen154hyundai/board_configuration.cpp b/firmware/config/boards/hellen/hellen154hyundai/board_configuration.cpp index 21a18a73f6..1265121f7a 100644 --- a/firmware/config/boards/hellen/hellen154hyundai/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen154hyundai/board_configuration.cpp @@ -148,7 +148,6 @@ void setBoardDefaultConfiguration() { setIgnitionPins(); engineConfiguration->displayLogicLevelsInEngineSniffer = true; - engineConfiguration->isSdCardEnabled = true; engineConfiguration->enableSoftwareKnock = true; engineConfiguration->canNbcType = CAN_BUS_GENESIS_COUPE; diff --git a/firmware/config/boards/hellen/hellen64_miataNA6_94/board_configuration.cpp b/firmware/config/boards/hellen/hellen64_miataNA6_94/board_configuration.cpp index a163dc9d9f..febb698cb5 100644 --- a/firmware/config/boards/hellen/hellen64_miataNA6_94/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen64_miataNA6_94/board_configuration.cpp @@ -91,8 +91,6 @@ void setBoardDefaultConfiguration() { setInjectorPins(); setIgnitionPins(); - engineConfiguration->isSdCardEnabled = true; - engineConfiguration->enableSoftwareKnock = true; // these stm32 pins do not match hellen_meta, is that because hellenNA6 is not using latest MCU version? diff --git a/firmware/config/boards/hellen/hellen72/board_configuration.cpp b/firmware/config/boards/hellen/hellen72/board_configuration.cpp index 3f5fd9f4f7..9b1e5dd2f7 100644 --- a/firmware/config/boards/hellen/hellen72/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen72/board_configuration.cpp @@ -98,8 +98,6 @@ void setBoardDefaultConfiguration() { setInjectorPins(); setIgnitionPins(); - engineConfiguration->isSdCardEnabled = true; - engineConfiguration->enableSoftwareKnock = true; engineConfiguration->acRelayPin = Gpio::H15; diff --git a/firmware/config/boards/hellen/hellen81/board_configuration.cpp b/firmware/config/boards/hellen/hellen81/board_configuration.cpp index dc1e7d4aeb..b7a0435fc3 100644 --- a/firmware/config/boards/hellen/hellen81/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen81/board_configuration.cpp @@ -105,8 +105,6 @@ void setBoardDefaultConfiguration() { setInjectorPins(); setIgnitionPins(); - engineConfiguration->isSdCardEnabled = true; - engineConfiguration->fuelPumpPin = Gpio::G2; // OUT_IO9 engineConfiguration->fanPin = Gpio::D12; // OUT_PWM8 engineConfiguration->mainRelayPin = Gpio::I2; // OUT_LOW3 diff --git a/firmware/config/boards/hellen/hellen88bmw/board_configuration.cpp b/firmware/config/boards/hellen/hellen88bmw/board_configuration.cpp index c86a3fa52f..36ab0d917b 100644 --- a/firmware/config/boards/hellen/hellen88bmw/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen88bmw/board_configuration.cpp @@ -97,7 +97,6 @@ void setBoardDefaultConfiguration() { setIgnitionPins(); engineConfiguration->displayLogicLevelsInEngineSniffer = true; - engineConfiguration->isSdCardEnabled = true; engineConfiguration->enableSoftwareKnock = true; engineConfiguration->canNbcType = CAN_BUS_NISSAN_VQ; diff --git a/firmware/config/boards/hellen/hellenNA8_96/board_configuration.cpp b/firmware/config/boards/hellen/hellenNA8_96/board_configuration.cpp index 7926dc735e..20b28ea0eb 100644 --- a/firmware/config/boards/hellen/hellenNA8_96/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellenNA8_96/board_configuration.cpp @@ -95,8 +95,6 @@ void setBoardDefaultConfiguration() { setInjectorPins(); setIgnitionPins(); - engineConfiguration->isSdCardEnabled = true; - engineConfiguration->enableSoftwareKnock = true; engineConfiguration->boostControlPin = H144_LS_6; diff --git a/firmware/config/boards/hellen_meta.h b/firmware/config/boards/hellen_meta.h index e7decb19ba..25d299231e 100644 --- a/firmware/config/boards/hellen_meta.h +++ b/firmware/config/boards/hellen_meta.h @@ -214,6 +214,7 @@ void detectHellenBoardType(); #define H_SPI3_CS Gpio::A15 static void setHellenSdCardSpi1() { + engineConfiguration->isSdCardEnabled = true; engineConfiguration->sdCardSpiDevice = SPI_DEVICE_1; engineConfiguration->spi1mosiPin = H_SPI1_MOSI; engineConfiguration->spi1misoPin = H_SPI1_MISO; @@ -223,6 +224,7 @@ static void setHellenSdCardSpi1() { } static void setHellenSdCardSpi2() { + engineConfiguration->isSdCardEnabled = true; engineConfiguration->sdCardSpiDevice = SPI_DEVICE_2; engineConfiguration->spi2mosiPin = H_SPI2_MOSI; engineConfiguration->spi2misoPin = H_SPI2_MISO; @@ -232,6 +234,7 @@ static void setHellenSdCardSpi2() { } static void setHellenSdCardSpi3() { + engineConfiguration->isSdCardEnabled = true; engineConfiguration->sdCardSpiDevice = SPI_DEVICE_3; engineConfiguration->spi3mosiPin = H_SPI3_MOSI; engineConfiguration->spi3misoPin = H_SPI3_MISO;