From 3314394dd9873ab37184c7553be147094d8c98df Mon Sep 17 00:00:00 2001 From: rusefillc Date: Sat, 17 Oct 2020 18:45:08 -0400 Subject: [PATCH] refactoring: better method name --- firmware/controllers/algo/engine2.cpp | 2 +- firmware/controllers/engine_cycle/aux_valves.cpp | 4 ++-- firmware/controllers/engine_cycle/aux_valves.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/firmware/controllers/algo/engine2.cpp b/firmware/controllers/algo/engine2.cpp index c1c5329217..50a23e2763 100644 --- a/firmware/controllers/algo/engine2.cpp +++ b/firmware/controllers/algo/engine2.cpp @@ -129,7 +129,7 @@ void EngineState::periodicFastCallback(DECLARE_ENGINE_PARAMETER_SIGNATURE) { } else { timeSinceCranking = nowNt - crankingTime; } - updateAuxValves(PASS_ENGINE_PARAMETER_SIGNATURE); + recalculateAuxValveTiming(PASS_ENGINE_PARAMETER_SIGNATURE); int rpm = ENGINE(rpmCalculator).getRpm(); sparkDwell = getSparkDwell(rpm PASS_ENGINE_PARAMETER_SUFFIX); diff --git a/firmware/controllers/engine_cycle/aux_valves.cpp b/firmware/controllers/engine_cycle/aux_valves.cpp index 69300fa106..8cf1ff5072 100644 --- a/firmware/controllers/engine_cycle/aux_valves.cpp +++ b/firmware/controllers/engine_cycle/aux_valves.cpp @@ -130,7 +130,7 @@ void initAuxValves(Logging *sharedLogger DECLARE_ENGINE_PARAMETER_SUFFIX) { return; } - updateAuxValves(PASS_ENGINE_PARAMETER_SIGNATURE); + recalculateAuxValveTiming(PASS_ENGINE_PARAMETER_SIGNATURE); for (int valveIndex = 0; valveIndex < AUX_DIGITAL_VALVE_COUNT; valveIndex++) { @@ -156,7 +156,7 @@ void initAuxValves(Logging *sharedLogger DECLARE_ENGINE_PARAMETER_SUFFIX) { // addTriggerEventListener(auxValveTriggerCallback, "AuxV", engine); } -void updateAuxValves(DECLARE_ENGINE_PARAMETER_SIGNATURE) { +void recalculateAuxValveTiming(DECLARE_ENGINE_PARAMETER_SIGNATURE) { if (engineConfiguration->auxValves[0] == GPIO_UNASSIGNED) { return; } diff --git a/firmware/controllers/engine_cycle/aux_valves.h b/firmware/controllers/engine_cycle/aux_valves.h index b2acdfb55c..3909107762 100644 --- a/firmware/controllers/engine_cycle/aux_valves.h +++ b/firmware/controllers/engine_cycle/aux_valves.h @@ -10,6 +10,6 @@ #include "engine.h" void initAuxValves(Logging *sharedLogger DECLARE_ENGINE_PARAMETER_SUFFIX); -void updateAuxValves(DECLARE_ENGINE_PARAMETER_SIGNATURE); +void recalculateAuxValveTiming(DECLARE_ENGINE_PARAMETER_SIGNATURE); void plainPinTurnOn(AuxActor *current); void plainPinTurnOff(NamedOutputPin *output);