From 3e30865e6c06853a9153a1d671e77f56047f4c22 Mon Sep 17 00:00:00 2001 From: Matthew Kennedy Date: Thu, 29 Oct 2020 12:26:01 -0700 Subject: [PATCH] unused tach field (#1918) --- firmware/controllers/algo/engine_configuration.cpp | 1 - firmware/integration/rusefi_config.txt | 2 +- firmware/tunerstudio/rusefi.input | 1 - unit_tests/tests/test_tacho.cpp | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/firmware/controllers/algo/engine_configuration.cpp b/firmware/controllers/algo/engine_configuration.cpp index 15bdd29d51..cf05784358 100644 --- a/firmware/controllers/algo/engine_configuration.cpp +++ b/firmware/controllers/algo/engine_configuration.cpp @@ -750,7 +750,6 @@ static void setDefaultEngineConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) { initTemperatureCurve(IAT_FUEL_CORRECTION_CURVE, 1); engineConfiguration->tachPulseDuractionMs = 4; - engineConfiguration->tachPulseTriggerIndex = 4; engineConfiguration->auxPid[0].minValue = 10; engineConfiguration->auxPid[0].maxValue = 90; diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index be4c565474..58dc7527d5 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -1088,7 +1088,7 @@ custom pin_mode_e 1 bits, U08, @OFFSET@, [0:6], @@pin_mode_e_enum@@ float[CRANKING_CURVE_SIZE] crankingTpsBins;;"%", 1, 0, 0.0, 100.0, 2 float tachPulseDuractionMs;;"ms", 1, 0, 0.0, 100.0, 2 - int tachPulseTriggerIndex;+Trigger cycle index at which we start tach pulse (performance consideration);"index", 1, 0, 0.0, 360.0, 0 + int unused1708;;"units", 1, 0, -20, 100, 0 float wwaeTau;+Length of time the deposited wall fuel takes to dissipate after the start of acceleration. ;"Seconds", 1, 0, 0.0, 3.0, 2 pid_s alternatorControl; diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index 0a1db8d02b..d7412f8199 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -2684,7 +2684,6 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@\x00\x31\x00\x00" dialog = tachSettings, "Tachometer output" field = "Pin", tachOutputPin field = "Pin mode", tachOutputPinMode - field = "Rise at trigger index", tachPulseTriggerIndex field = "Pulse duration is duty cycle", tachPulseDurationAsDutyCycle field = "Pulse duration", tachPulseDuractionMs field = "Pulse per Rev", tachPulsePerRev diff --git a/unit_tests/tests/test_tacho.cpp b/unit_tests/tests/test_tacho.cpp index 96d522b2b9..c0f28ef3bf 100644 --- a/unit_tests/tests/test_tacho.cpp +++ b/unit_tests/tests/test_tacho.cpp @@ -17,7 +17,6 @@ TEST(tachometer, testPulsePerRev) { engineConfiguration->tachPulsePerRev = 4; engineConfiguration->tachPulseDuractionMs = 0.5f; engineConfiguration->tachPulseDurationAsDutyCycle = true; - engineConfiguration->tachPulseTriggerIndex = 0; // Set predictable trigger settings engineConfiguration->trigger.customTotalToothCount = 8;