rusefi
/
custom-board-bundle-sample-fork-of-rusefi
mirror of https://github.com/rusefi/custom-board-bundle-sample-fork-of-rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactoring: extracting useful method

This commit is contained in:
rusefi 2022-10-25 21:54:26 -04:00
parent abe179d121
commit 4db3a65a7e
4 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
firmware/config/boards/subaru_eg33/board_configuration.cpp
View File

@ -207,14 +207,6 @@ void setBoardDefaultConfiguration() {
engineConfiguration->knockBankCyl5 = 0; engineConfiguration->knockBankCyl5 = 0;
engineConfiguration->knockBankCyl6 = 1; engineConfiguration->knockBankCyl6 = 1;
/* Cylinder to bank mapping */
engineConfiguration->cylinderBankSelect[1 - 1] = 0;
engineConfiguration->cylinderBankSelect[2 - 1] = 1;
engineConfiguration->cylinderBankSelect[3 - 1] = 0;
engineConfiguration->cylinderBankSelect[4 - 1] = 1;
engineConfiguration->cylinderBankSelect[5 - 1] = 0;
engineConfiguration->cylinderBankSelect[6 - 1] = 1;
/* Misc settings */ /* Misc settings */
engineConfiguration->acSwitch = Gpio::MC33972_PIN_22; engineConfiguration->acSwitch = Gpio::MC33972_PIN_22;
engineConfiguration->acSwitchMode = PI_DEFAULT; engineConfiguration->acSwitchMode = PI_DEFAULT;

2
firmware/config/engines/subaru.cpp
View File

@ -12,6 +12,7 @@
#include "subaru.h" #include "subaru.h"
#include "custom_engine.h" #include "custom_engine.h"
#include "defaults.h"
void setSubaru2003Wrx() { void setSubaru2003Wrx() {
setFrankenso_01_LCD(engineConfiguration); setFrankenso_01_LCD(engineConfiguration);
@ -71,6 +72,7 @@ void setSubaruEG33Defaults() {
engineConfiguration->useOnlyRisingEdgeForTrigger = true; engineConfiguration->useOnlyRisingEdgeForTrigger = true;
engineConfiguration->specs.cylindersCount = 6; engineConfiguration->specs.cylindersCount = 6;
setLeftRightBanksNeedBetterName();
engineConfiguration->specs.firingOrder = FO_1_6_3_2_5_4; engineConfiguration->specs.firingOrder = FO_1_6_3_2_5_4;
engineConfiguration->ignitionMode = IM_INDIVIDUAL_COILS; engineConfiguration->ignitionMode = IM_INDIVIDUAL_COILS;

7
firmware/controllers/algo/defaults/default_base_engine.cpp
View File

@ -13,6 +13,13 @@ static void setDefaultAlternatorParameters() {
engineConfiguration->alternatorControl.periodMs = 100; engineConfiguration->alternatorControl.periodMs = 100;
} }
/* Cylinder to bank mapping */
void setLeftRightBanksNeedBetterName() {
for (int i = 0;i<engineConfiguration->specs.cylindersCount;i++) {
engineConfiguration->cylinderBankSelect[i] = i % 2;
}
}
void setDefaultBaseEngine() { void setDefaultBaseEngine() {
// Base Engine Settings // Base Engine Settings
engineConfiguration->specs.cylindersCount = 4; engineConfiguration->specs.cylindersCount = 4;

4
firmware/controllers/algo/defaults/defaults.h
View File

@ -1,4 +1,8 @@
/**
* file defaults.h
*/
void setLeftRightBanksNeedBetterName();
void setDefaultBaseEngine(); void setDefaultBaseEngine();
void setDefaultFuel(); void setDefaultFuel();
void setDefaultIgnition(); void setDefaultIgnition();