rusefi
/
custom-board-bundle-sample-fork-of-rusefi
mirror of https://github.com/rusefi/custom-board-bundle-sample-fork-of-rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

better idle debug info

This commit is contained in:
rusefi 2018-07-29 16:36:18 -04:00
parent 4c2ecf25eb
commit 52a1ac2b10
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/controllers/engine_controller.cpp
View File

@ -733,5 +733,5 @@ int getRusEfiVersion(void) {
if (initBootloader() != 0) if (initBootloader() != 0)
return 123; return 123;
#endif /* EFI_BOOTLOADER_INCLUDE_CODE */ #endif /* EFI_BOOTLOADER_INCLUDE_CODE */
return 20180728; return 20180729;
} }

13
firmware/controllers/idle_thread.cpp
View File

@ -68,6 +68,7 @@ typedef enum {
RPM_DEAD_ZONE = 2, RPM_DEAD_ZONE = 2,
PWM_PRETTY_CLOSE = 3, PWM_PRETTY_CLOSE = 3,
ADJUSTING = 4, ADJUSTING = 4,
BLIP = 5,
} idle_state_e; } idle_state_e;
@ -317,6 +318,7 @@ static msg_t ivThread(int param) {
if (timeToStopBlip != 0) { if (timeToStopBlip != 0) {
iacPosition = blipIdlePosition; iacPosition = blipIdlePosition;
baseIdlePosition = iacPosition; baseIdlePosition = iacPosition;
idleState = BLIP;
} else if (!isRunning) { } else if (!isRunning) {
// during cranking it's always manual mode, PID would make no sence during cranking // during cranking it's always manual mode, PID would make no sence during cranking
iacPosition = cltCorrection * engineConfiguration->crankingIACposition; iacPosition = cltCorrection * engineConfiguration->crankingIACposition;
@ -346,11 +348,6 @@ static msg_t ivThread(int param) {
engine->rpmCalculator.getRevolutionCounterSinceStart()); engine->rpmCalculator.getRevolutionCounterSinceStart());
} }
// The threshold is dependent on IAC type (see initIdleHardware())
if (absF(iacPosition - currentIdlePosition) < idlePositionSensitivityThreshold) {
idleState = PWM_PRETTY_CLOSE;
continue; // value is pretty close, let's leave the poor valve alone
}
if (engineConfiguration->debugMode == DBG_IDLE_CONTROL) { if (engineConfiguration->debugMode == DBG_IDLE_CONTROL) {
#if ! EFI_UNIT_TEST || defined(__DOXYGEN__) #if ! EFI_UNIT_TEST || defined(__DOXYGEN__)
@ -364,6 +361,12 @@ static msg_t ivThread(int param) {
#endif #endif
} }
// The threshold is dependent on IAC type (see initIdleHardware())
if (absF(iacPosition - currentIdlePosition) < idlePositionSensitivityThreshold) {
idleState = PWM_PRETTY_CLOSE;
continue; // value is pretty close, let's leave the poor valve alone
}
currentIdlePosition = iacPosition; currentIdlePosition = iacPosition;
idleState = ADJUSTING; idleState = ADJUSTING;
applyIACposition(currentIdlePosition); applyIACposition(currentIdlePosition);