From 5fae1b4f557143c3e06b56ea1c29fbc468e8b232 Mon Sep 17 00:00:00 2001 From: Matthew Kennedy Date: Fri, 3 Mar 2023 02:20:51 -0800 Subject: [PATCH] various crust --- firmware/global.h | 1 - firmware/util/datalogging.h | 2 -- firmware/util/loggingcentral.cpp | 3 +-- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/firmware/global.h b/firmware/global.h index 51a839b195..cfa26a3fe5 100644 --- a/firmware/global.h +++ b/firmware/global.h @@ -11,7 +11,6 @@ #pragma once -// todo: remove this from here and rely on os_access.h. unfortunately hal.h includes ch.h :( #include // *** IMPORTANT *** from painful experience we know that common_headers.h has to be included AFTER hal.h // *** https://github.com/rusefi/rusefi/issues/1007 *** diff --git a/firmware/util/datalogging.h b/firmware/util/datalogging.h index 14fa787256..b6e7252eb3 100644 --- a/firmware/util/datalogging.h +++ b/firmware/util/datalogging.h @@ -12,8 +12,6 @@ #include #include -// todo: migrate to external buffer so that different instances have different -// size of buffers? class Logging { public: Logging() = delete; diff --git a/firmware/util/loggingcentral.cpp b/firmware/util/loggingcentral.cpp index c69e763e45..6325ea31fe 100644 --- a/firmware/util/loggingcentral.cpp +++ b/firmware/util/loggingcentral.cpp @@ -138,8 +138,7 @@ public: msg_t msg = filledBuffers.fetch(&line, TIME_INFINITE); if (msg == MSG_RESET) { - // todo? - // what happens if MSG_RESET? + // FIXME what happens if MSG_RESET? } else { // Lock the buffer mutex - inhibit buffer swaps while writing chibios_rt::MutexLocker lock(logBufferMutex);