rusefi
/
custom-board-bundle-sample-fork-of-rusefi
mirror of https://github.com/rusefi/custom-board-bundle-sample-fork-of-rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dead code in map avg (#3290) 

* dead code in map avg

* while we're at it

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
This commit is contained in:
Matthew Kennedy 2021-09-30 20:05:58 -07:00 committed by GitHub
parent f311352750
commit 6703df0be3
1 changed files with 1 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
firmware/controllers/engine_cycle/map_averaging.cpp
View File

@ -50,14 +50,6 @@ static volatile int measurementsPerRevolutionCounter = 0;
*/
static volatile int measurementsPerRevolution = 0;
/**
* In this lock-free implementation 'readIndex' is always pointing
* to the consistent copy of accumulator and counter pair
*/
static int readIndex = 0;
static float accumulators[2];
static int counters[2];
/**
* Running MAP accumulator - sum of all measurements within averaging window
*/
@ -148,18 +140,6 @@ void mapAveragingAdcCallback(adcsample_t adcValue) {
}
#endif /* EFI_SENSOR_CHART */
/**
* Local copy is now safe, but it's an overkill: we only
* have one writing thread anyway
*/
int readIndexLocal = readIndex;
int writeIndex = readIndexLocal ^ 1;
accumulators[writeIndex] = accumulators[readIndexLocal] + adcValue;
counters[writeIndex] = counters[readIndexLocal] + 1;
// this would commit the new pair of values
readIndex = writeIndex;
// todo: migrate to the lock-free implementation
{
// with locking we will have a consistent state
chibios_rt::CriticalSectionLocker csl;
@ -169,8 +149,7 @@ void mapAveragingAdcCallback(adcsample_t adcValue) {
}
#endif
static void endAveraging(void *arg) {
(void) arg;
static void endAveraging(void*) {
#if ! EFI_UNIT_TEST
chibios_rt::CriticalSectionLocker csl;
#endif