diff --git a/firmware/config/engines/dodge_neon.cpp b/firmware/config/engines/dodge_neon.cpp index 9f79631493..20ac02fcad 100644 --- a/firmware/config/engines/dodge_neon.cpp +++ b/firmware/config/engines/dodge_neon.cpp @@ -390,7 +390,7 @@ void setDodgeNeonNGCEngineConfiguration(DECLARE_ENGINE_PARAMETER_F) { engineConfiguration->algorithm = LM_SPEED_DENSITY; boardConfiguration->alternatorControlPin = GPIOD_5; - engineConfiguration->alternatorControlPFactor = 30; + engineConfiguration->alternatorControlPFactor = 22; // engineConfiguration->isCanEnabled = true; boardConfiguration->canTxPin = GPIOB_6; diff --git a/firmware/controllers/alternatorController.cpp b/firmware/controllers/alternatorController.cpp index 30003578aa..6a491fca96 100644 --- a/firmware/controllers/alternatorController.cpp +++ b/firmware/controllers/alternatorController.cpp @@ -70,6 +70,8 @@ static void applyAlternatorPinState(PwmConfig *state, int stateIndex) { static void showAltInfo(void) { scheduleMsg(logger, "atl=%s", boolToString(engineConfiguration->isAlternatorControlEnabled)); + scheduleMsg(logger, "p=%f/i=%f/d=%f", engineConfiguration->alternatorControlPFactor, + 0, 0); // todo: i & d scheduleMsg(logger, "vbatt=%f/duty=%f", getVBatt(engineConfiguration), currentAltDuty); } diff --git a/firmware/hw_layer/HIP9011.cpp b/firmware/hw_layer/HIP9011.cpp index 3e9bbcd5d3..1768fec08b 100644 --- a/firmware/hw_layer/HIP9011.cpp +++ b/firmware/hw_layer/HIP9011.cpp @@ -36,7 +36,7 @@ #if EFI_HIP_9011 || defined(__DOXYGEN__) -static OutputPin intHold; +static NamedOutputPin intHold; static OutputPin hipCs; extern pin_output_mode_e DEFAULT_OUTPUT; @@ -140,7 +140,7 @@ static void startIntegration(void) { * until we are done integrating */ state = IS_INTEGRATING; - intHold.setValue(true); + turnPinHigh(&intHold); } } @@ -150,7 +150,7 @@ static void endIntegration(void) { * engine cycle */ if (state == IS_INTEGRATING) { - intHold.setValue(false); + turnPinLow(&intHold); state = WAITING_FOR_ADC_TO_SKIP; } } @@ -235,6 +235,7 @@ void initHip9011(Logging *sharedLogger) { spicfg.ssport = getHwPort(boardConfiguration->hip9011CsPin); spicfg.sspad = getHwPin(boardConfiguration->hip9011CsPin); + intHold.name = "HIP"; outputPinRegisterExt2("hip int/hold", &intHold, boardConfiguration->hip9011IntHoldPin, &DEFAULT_OUTPUT); outputPinRegisterExt2("hip CS", &hipCs, boardConfiguration->hip9011CsPin, &DEFAULT_OUTPUT);