The Big Refactoring of 2019: configuration version should not be a global variable #656

firmware/util/containers/local_version_holder.cpp

@@ -8,10 +8,6 @@
 #include "local_version_holder.h"
 
 LocalVersionHolder::LocalVersionHolder() {
-	/**
-	 * we want local version to be 'old' on instantiation
-	 */
-	localVersion = -1;
 }
 
 int LocalVersionHolder::getVersion() {

firmware/util/containers/local_version_holder.h

@@ -27,7 +27,10 @@ public:
 	int getVersion();
 
 private:
-	int localVersion;
+	/**
+	 * we want local version to be 'old' on instantiation
+	 */
+	int localVersion = -1;
 
 };