trigger layer start-up is a mess #5241

reducing code duplication: start actual pins only from best startHardware method
This commit is contained in:
rusefillc 2023-04-19 17:27:47 -04:00
parent d423bb063a
commit 8fc2e0eb53
1 changed files with 4 additions and 6 deletions

View File

@ -316,11 +316,6 @@ void applyNewHardwareSettings() {
/******************************************* /*******************************************
* Start everything back with new settings * * Start everything back with new settings *
******************************************/ ******************************************/
#if EFI_PROD_CODE && EFI_SHAFT_POSITION_INPUT
startTriggerInputPins();
#endif /* EFI_SHAFT_POSITION_INPUT */
startHardware(); startHardware();
#if EFI_HD44780_LCD #if EFI_HD44780_LCD
@ -466,6 +461,10 @@ void stopHardware() {
* TODO: move move hardware code here * TODO: move move hardware code here
*/ */
void startHardware() { void startHardware() {
#if EFI_PROD_CODE && EFI_SHAFT_POSITION_INPUT
startTriggerInputPins();
#endif /* EFI_SHAFT_POSITION_INPUT */
#if EFI_ENGINE_CONTROL #if EFI_ENGINE_CONTROL
enginePins.startPins(); enginePins.startPins();
#endif /* EFI_ENGINE_CONTROL */ #endif /* EFI_ENGINE_CONTROL */
@ -571,7 +570,6 @@ void initHardware() {
#if EFI_PROD_CODE && EFI_SHAFT_POSITION_INPUT #if EFI_PROD_CODE && EFI_SHAFT_POSITION_INPUT
onEcuStartTriggerImplementation(); onEcuStartTriggerImplementation();
onEcuStartDoSomethingTriggerInputPins(); onEcuStartDoSomethingTriggerInputPins();
startTriggerInputPins();
#endif /* EFI_SHAFT_POSITION_INPUT */ #endif /* EFI_SHAFT_POSITION_INPUT */
#if EFI_HIP_9011 #if EFI_HIP_9011