sensor checker is not checking sensors fix #5232

firmware/CHANGELOG.md

@@ -49,6 +49,7 @@ Release template (copy/paste this for new release):
  - ETB control improvements hellen boards #5196
  - Require either analog AFR or CAN AFR input not both #5226
  - Ignition Knock response logging progress
+ - sensor checker is not checking sensors #5232
 
 ## February 2023 Release - "Day 346"
 

firmware/controllers/sensors/sensor_checker.cpp

@@ -148,7 +148,7 @@ void SensorChecker::onSlowCallback() {
 	// TODO: also inhibit checking if we just did a flash burn, since that blocks the ECU for a few seconds.
 	bool shouldCheck = m_ignitionIsOn && m_timeSinceIgnOff.hasElapsedSec(5);
 	m_analogSensorsShouldWork = shouldCheck;
-	if (shouldCheck) {
+	if (!shouldCheck) {
 		return;
 	}
 

unit_tests/tests/actuators/test_etb_integrated.cpp

@@ -92,8 +92,7 @@ TEST(etb, intermittentTps) {
 	etb->update();
 
 	EXPECT_NE(0, etb->etbErrorCode);
-	// todo: warnings would have been nice!
-	EXPECT_EQ( 0,  unitTestWarningCodeState.recentWarnings.getCount()) << "intermittentTps";
+	EXPECT_EQ( 3,  unitTestWarningCodeState.recentWarnings.getCount()) << "intermittentTps";
 }
 
 TEST(etb, intermittentPps) {