rusefi
/
custom-board-bundle-sample-fork-of-rusefi
mirror of https://github.com/rusefi/custom-board-bundle-sample-fork-of-rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Trigger setup in TS is highly confusing: hide operation mode from users? #4031

This commit is contained in:
Andrey 2022-04-02 23:50:39 -04:00
parent 2bc1215f86
commit a43aec4e60
3 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/config/engines/GY6_139QMB.cpp
View File

@ -28,6 +28,8 @@ void setGy6139qmbDefaultEngineConfiguration() {
engineConfiguration->specs.displacement = 0.072; // 72cc engineConfiguration->specs.displacement = 0.072; // 72cc
engineConfiguration->specs.cylindersCount = 1; engineConfiguration->specs.cylindersCount = 1;
setOperationMode(engineConfiguration, FOUR_STROKE_CRANK_SENSOR); setOperationMode(engineConfiguration, FOUR_STROKE_CRANK_SENSOR);
// this is related to 'setDefaultBaseEngine' having 'skippedWheelOnCam = true' which is a weird fact by itself
engineConfiguration->skippedWheelOnCam = false;
engineConfiguration->specs.firingOrder = FO_1; engineConfiguration->specs.firingOrder = FO_1;

2
firmware/config/engines/test_engine.cpp
View File

@ -55,6 +55,8 @@ void setTestCrankEngineConfiguration() {
engineConfiguration->trigger.type = TT_ONE; engineConfiguration->trigger.type = TT_ONE;
setOperationMode(engineConfiguration, FOUR_STROKE_CRANK_SENSOR); setOperationMode(engineConfiguration, FOUR_STROKE_CRANK_SENSOR);
// this is related to 'setDefaultBaseEngine' having 'skippedWheelOnCam = true' which is a weird fact by itself
engineConfiguration->skippedWheelOnCam = false;
} }
void setTestVVTEngineConfiguration() { void setTestVVTEngineConfiguration() {

2
firmware/controllers/algo/defaults/default_base_engine.cpp
View File

@ -34,7 +34,9 @@ void setDefaultBaseEngine() {
// Trigger // Trigger
engineConfiguration->trigger.type = TT_TOOTHED_WHEEL_60_2; engineConfiguration->trigger.type = TT_TOOTHED_WHEEL_60_2;
// huh WAT? our default is skipped on CAM?! and *many* our tests are relying on that?!
setOperationMode(engineConfiguration, FOUR_STROKE_CAM_SENSOR); setOperationMode(engineConfiguration, FOUR_STROKE_CAM_SENSOR);
engineConfiguration->skippedWheelOnCam = true;
engineConfiguration->useOnlyRisingEdgeForTrigger = false; engineConfiguration->useOnlyRisingEdgeForTrigger = false;
engineConfiguration->globalTriggerAngleOffset = 0; engineConfiguration->globalTriggerAngleOffset = 0;