rusefi
/
custom-board-bundle-sample-fork-of-rusefi
mirror of https://github.com/rusefi/custom-board-bundle-sample-fork-of-rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Shall we drop "ignitionOffset" feature? #2500 

dead code and TS progress
This commit is contained in:
rusefillc 2021-03-27 19:00:35 -04:00
parent 5fda278503
commit bc3cf715c9
3 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/config/engines/ford_festiva.cpp
View File

@ -139,10 +139,6 @@ void setFordEscortGt(DECLARE_CONFIG_PARAMETER_SIGNATURE) {
// set global_trigger_offset_angle -37
engineConfiguration->globalTriggerAngleOffset = -37;
// set ignition_offset 0
engineConfiguration->ignitionOffset = 0;
// set injection_offset 0
engineConfiguration->extraInjectionOffset = 0;
// todo: change to 15?
// set cranking_timing_angle 3

6
firmware/config/engines/honda_accord.cpp
View File

@ -82,12 +82,6 @@ static void setHondaAccordConfigurationCommon(DECLARE_CONFIG_PARAMETER_SIGNATURE
engineConfiguration->cranking.rpm = 500;
// set ignition_offset 350
// engineConfiguration->ignitionOffset = 350;
// set injection_offset 510
// engineConfiguration->extraInjectionOffset = 510;
/**
* ADC inputs:
*

2
firmware/integration/rusefi_config.txt
View File

@ -603,7 +603,7 @@ angle_t crankingTimingAngle;+Ignition advance angle used during engine cranking,
custom ignition_mode_e 4 bits, U32, @OFFSET@, [0:1], "Single Coil", "Individual Coils", "Wasted Spark", "Two Distributors"
ignition_mode_e ignitionMode;+"Single Coil" is for use on distributed ignition system. "Individual Coils" is to be used when you have one coil per cylinder (COP or similar). "Wasted Spark" means one coil is driving two spark plugs in two cylinders, with one of the sparks not doing anything since it's happening on the exhaust cycle\nset ignition_mode X
angle_t ignitionOffset;+this value could be used to offset the whole ignition timing table by a constant;"RPM", 1, 0, 0, 3000.0, 0
angle_t ignitionOffset;+This value could be used to offset the whole ignition timing table by a constant\nSee also timing_offset_cylinder;"RPM", 1, 0, 0, 3000.0, 0
custom timing_mode_e 4 bits, U32, @OFFSET@, [0:0], "dynamic", "fixed"
timing_mode_e timingMode;+Dynamic uses the timing map to decide the ignition timing, Static timing fixes the timing to the value set below (only use for checking static timing with a timing light).