rusefi
/
custom-board-bundle-sample-fork-of-rusefi
mirror of https://github.com/rusefi/custom-board-bundle-sample-fork-of-rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Allow negative VVT position feedback #1713

This commit is contained in:
rusefi 2020-08-23 11:49:46 -04:00
parent 90c70dc562
commit d0705f14ee
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/controllers/trigger/trigger_central.cpp
View File

@ -151,7 +151,7 @@ void hwHandleVvtCamSignal(trigger_value_e front, efitick_t nowNt DECLARE_ENGINE_
angle_t currentPosition = NT2US(offsetNt) / oneDegreeUs; angle_t currentPosition = NT2US(offsetNt) / oneDegreeUs;
// convert engine cycle angle into trigger cycle angle // convert engine cycle angle into trigger cycle angle
currentPosition -= tdcPosition(); currentPosition -= tdcPosition();
fixAngle(currentPosition, "currentPosition", CUSTOM_ERR_6558); // https://github.com/rusefi/rusefi/issues/1713 currentPosition could be negative that's expected
tc->currentVVTEventPosition = currentPosition; tc->currentVVTEventPosition = currentPosition;
if (engineConfiguration->debugMode == DBG_VVT) { if (engineConfiguration->debugMode == DBG_VVT) {

2
unit_tests/tests/trigger/test_2jz_vvt.cpp
View File

@ -32,5 +32,5 @@ TEST(sensors, test2jz) {
hwHandleVvtCamSignal(TV_RISE, getTimeNowNt() PASS_ENGINE_PARAMETER_SUFFIX); hwHandleVvtCamSignal(TV_RISE, getTimeNowNt() PASS_ENGINE_PARAMETER_SUFFIX);
// currentPosition // currentPosition
ASSERT_NEAR(608.2, engine->triggerCentral.currentVVTEventPosition, EPS3D); ASSERT_NEAR(608.2 - 720, engine->triggerCentral.currentVVTEventPosition, EPS3D);
} }

2
unit_tests/tests/trigger/test_cam_vvt_input.cpp
View File

@ -159,7 +159,7 @@ TEST(sensors, testNB2CamInput) {
// this third important front would give us first comparison between two real gaps // this third important front would give us first comparison between two real gaps
hwHandleVvtCamSignal(TV_RISE, getTimeNowNt() PASS_ENGINE_PARAMETER_SUFFIX); hwHandleVvtCamSignal(TV_RISE, getTimeNowNt() PASS_ENGINE_PARAMETER_SUFFIX);
ASSERT_NEAR(-67.6, engine->triggerCentral.getVVTPosition(), EPS3D); ASSERT_NEAR(-67.6 - 720 - 720, engine->triggerCentral.getVVTPosition(), EPS3D);
// actually position based on VVT! // actually position based on VVT!
ASSERT_EQ(totalRevolutionCountBeforeVvtSync + 2, engine->triggerCentral.triggerState.getTotalRevolutionCounter()); ASSERT_EQ(totalRevolutionCountBeforeVvtSync + 2, engine->triggerCentral.triggerState.getTotalRevolutionCounter());
} }