From e33a9c8301b98f2fa6650d748be5de7df3b0755f Mon Sep 17 00:00:00 2001 From: rusefi Date: Mon, 22 Jul 2019 17:38:52 -0400 Subject: [PATCH] trigger error message makes trigger very unhappy #888 quick dirty temporary solution --- firmware/controllers/trigger/trigger_decoder.cpp | 9 ++++++++- firmware/integration/rusefi_config.txt | 2 +- firmware/tunerstudio/rusefi.input | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/firmware/controllers/trigger/trigger_decoder.cpp b/firmware/controllers/trigger/trigger_decoder.cpp index 8f01fdc7a2..b11c133c98 100644 --- a/firmware/controllers/trigger/trigger_decoder.cpp +++ b/firmware/controllers/trigger/trigger_decoder.cpp @@ -509,8 +509,15 @@ void TriggerState::decodeTriggerEvent(trigger_event_e const signal, efitime_t no isSynchronizationPoint = isSync; + /** + * todo: technically we can afford detailed logging even with 60/2 as long as low RPM + * todo: figure out exact threshold as a function of RPM and tooth count? + * Open question what is 'triggerShape->getSize()' for 60/2 is it 58 or 58*2 or 58*4? + */ + bool silentTriggerError = triggerShape->getSize() > 40 && CONFIG(silentTriggerError); + #if EFI_PROD_CODE - if (CONFIG(verboseTriggerSynchDetails) || (someSortOfTriggerError && !CONFIG(silentTriggerError))) { + if (CONFIG(verboseTriggerSynchDetails) || (someSortOfTriggerError && !silentTriggerError)) { #else if (printTriggerDebug) { #endif /* EFI_PROD_CODE */ diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index 134613033c..5108f1cf84 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -713,7 +713,7 @@ bit vvtDisplayInverted bit isVerboseETB;+Prints ETB details to rusEFI console bit useConstantDwellDuringCranking;+If set to true, will use the specified duration for cranking dwell. If set to false, will use the specified dwell angle. Unless you have a really good reason to, leave this set to true to use duration mode. bit isEngineChartEnabled;+This options enables data for 'engine sniffer' tab in console, which comes at some CPU price - bit silentTriggerError + bit silentTriggerError;+Sometimes we have a performance issue while printing error bit useLinearCltSensor bit canReadEnabled bit canWriteEnabled diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index 8c7fd97e51..548df1b5dc 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -1446,6 +1446,7 @@ cmd_set_engine_type_default = "w\x00\x31\x00\x00" field = "Miata NB2 to (temporary)", miataNb2VVTRatioTo field = "nbVvtIndex", nbVvtIndex field = "print verbose sync details to console",verboseTriggerSynchDetails + field = "Do not print messages in case of sync error", silentTriggerError field = "Enable noise filtering", useNoiselessTriggerDecoder, {trigger_type == 8} dialog = triggerConfiguration panel = triggerConfiguration_settings, North