Commit Graph

1928 Commits

Author SHA1 Message Date
GitHub gen-configs Action 6b28fee5ce Auto-generated configs and docs 2022-10-28 13:11:34 +00:00
rusefillc 5df60fd084 SD card log fields list should be auto-generated #3985 2022-10-28 09:06:15 -04:00
rusefillc cf75202ab6 Automation coverage for RPM not reading #4709 2022-10-28 02:44:38 -04:00
rusefillc 2677da2105 refactoring 2022-10-28 02:41:20 -04:00
rusefillc 983f88709a progress: allow only exhaust cam input now that we have index parameter 2022-10-22 08:40:36 -04:00
rusefillc da0fa03f0a refactoring: wider usage of helper method 2022-10-22 08:39:55 -04:00
rusefillc 905f59d561 progress: rpm register based on trigger input being none or not 2022-10-21 23:29:39 -04:00
Matthew Kennedy f760ae11c1
simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
rusefillc 19b0f7e66e triggerImage: todo: support symmetrical crank 2022-10-16 12:10:58 -04:00
Matthew Kennedy aa881efe89
fix 36-2-1 trigger (#4645)
* fix

* test files

* test real 4b11

* test.mk

* better angle error math

* test GM too

* changelog
2022-10-09 21:22:05 -04:00
rusefillc 6a99469c8a
// todo: what is broken _exactly_? (#4531)
* // todo: what is broken _exactly_?

* hold on, why "float autoscale" at all here?

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 23:13:14 -04:00
GitHub gen-configs Action bd4ca6a805 Auto-generated configs and docs 2022-10-09 02:22:51 +00:00
rusefillc 86d3b16939
hold on, why "float autoscale" at all here? (#4647)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 22:11:34 -04:00
Matthew Kennedy a773b3249a
remove 2jz trigger that's really 12 tooth crank (#4637)
* remove 2jz trigger that's really 12 tooth crank

* triggerimage hardcoded name
2022-10-05 21:59:17 -04:00
Matthew Kennedy 6e021fb880
change triggers that need RiseOnly (#4636)
* triggers that need RiseOnly

* skipped tooth

* s
2022-10-05 20:10:27 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefillc 57c804c6f5 there is no third trigger simulator channel right? 2022-10-03 00:18:11 -04:00
Matthew Kennedy cb86c014cf
fix instant rpm clearing bug (#4629)
* improve instant rpm

* changelog
2022-09-29 07:15:59 -04:00
Andrey 36113d6f66 nicer fatal message if that ever happens 2022-09-28 19:47:14 -04:00
GitHub gen-configs Action 1b56415c56 Auto-generated configs and docs 2022-09-25 22:54:41 +00:00
Matthew Kennedy ca623eb6ee
plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy 26356adf92
also invert trigger stim if you have trigger input inverted (#4612) 2022-09-25 10:10:31 -04:00
Matthew Kennedy ae6c44634b
better k gaps (#4623) 2022-09-25 09:14:29 -04:00
Matthew Kennedy b45f84fe20
#4619 (#4620) 2022-09-25 07:40:28 -04:00
Andrey 9d27780974 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 61cfff1e9e K progress - just a rename 2022-09-24 23:25:36 -04:00
Andrey cff779dd78 K progress 2022-09-24 23:18:57 -04:00
GitHub gen-configs Action 3b5ee8da51 Auto-generated configs and docs 2022-09-24 04:29:39 +00:00
Matthew Kennedy dd41cf0a05
log tooth angle difference (#4613) 2022-09-23 23:49:28 -04:00
Matthew Kennedy 7139ddcda2
explicitly pass which edges we sync trigger on (#4607)
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc c4699efe91 honda K enum rename 2022-09-23 20:13:14 -04:00
Matthew Kennedy 6dd933ea86
terrible horrible typo (#4597) 2022-09-20 12:39:16 -04:00
rusefillc efb232223f moving acceleration around 2022-09-16 00:06:57 -04:00
rusefillc 3104538022 just a rename & hiding unit test method 2022-09-15 23:07:08 -04:00
rusefillc 50cef9a201 tear down Engine god object #4511 2022-09-15 22:12:49 -04:00
rusefillc fc9fb5724c tear down Engine god object #4511 2022-09-15 22:06:16 -04:00
rusefillc 13bd9ab641 tear down Engine god object #4511 2022-09-15 22:00:07 -04:00
rusefillc 52f52376de tear down Engine god object #4511 2022-09-15 21:55:15 -04:00
rusefillc ec0e567989 tear down Engine god object #4511 2022-09-15 21:46:01 -04:00
rusefillc 9e7f36a5ca tear down Engine god object #4511 2022-09-15 21:28:27 -04:00
rusefillc 85b170f84e dead idea 2022-09-15 14:55:32 -04:00
Andrey 0c87bb7260 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
Andrey 0e91914266 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey 663c39afdc deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
Andrey 2c0ce0ec7d deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey 12d857b99c deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
Andrey 6cdb0dc0af deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey 82cda62bac inline method to reduce confusion 2022-09-14 01:34:52 -04:00
Andrey G 55c1f53c75
dead code, reduce typedefs (#4566)
* Do lightweight checks first

* Dead getTimeIgnitionSeconds()

Dead since 81fffe87b7

* Get rid of efitime_t.

Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.

* Fix unit tests

* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G e2addd1951
Supress tons of warning from triggers (#4565) 2022-09-11 15:25:58 -04:00
Andrey G 91d4844e38
time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc 7cc41dfa75 human brain does need sleep 2022-09-11 12:40:24 -04:00
rusefillc 07727f5d0a Revert "refactoring: type safety"
This reverts commit ed7908a69d.
2022-09-11 11:14:20 -04:00
rusefillc ed7908a69d refactoring: type safety 2022-09-11 11:00:12 -04:00
rusefillc 2eca6ec3c7 refactoring: type safety 2022-09-11 05:41:01 -04:00
rusefillc 2a05a31550 refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc 851e8e48d3 refactoring: type safety 2022-09-11 02:57:35 -04:00
rusefillc 6e71b72acc refactoring - reducing API between FW and Java 2022-09-11 02:16:47 -04:00
rusefillc 94762094a7 refactoring - reducing API between FW and Java 2022-09-11 01:59:44 -04:00
rusefillc cfb843b315 send more of Engine Sniffer data #4560
hello Kinetis it has been a while!
2022-09-11 00:18:08 -04:00
rusefillc 7b4a5c9be6 vvtBooleanForVerySpecialCases, tempBooleanForVerySpecialLogic 2022-09-09 17:52:54 -04:00
Matthew Kennedy 72299bd1ba
only report vvt position if we have full sync (#4547)
* only report vvt position if we have full sync

* comments

* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
rusefillc 9e9c0217b8
huh? dead code? how can we get NAN from eventAngles table? (#4549) 2022-09-07 23:45:33 -04:00
GitHub gen-configs Action 27c40e162b Auto-generated configs and docs 2022-09-08 02:41:09 +00:00
Andrey 8e49542600 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 22:24:28 -04:00
Andrey 00fea2cbe5 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 21:45:59 -04:00
Andrey ab4b451195 os_access.h dead? 2022-09-07 15:56:45 -04:00
Matthew Kennedy aeeef3dbd0
reset instant RPM in case of cam resync (#4544) 2022-09-06 21:38:35 -04:00
Andrey c1b218b772 refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Matthew Kennedy 9407150544
more granular trigger error messages (#4526)
* granular trigger error messages

* adjust test expectations

* explicitly test behavior
2022-09-04 09:15:24 -04:00
Andrey c28c876357 todo: what is broken _exactly_? 2022-09-03 06:55:47 -04:00
GitHub gen-configs Action 7dee4d33cb Auto-generated configs and docs 2022-09-01 14:11:17 +00:00
Andrey 5941ad8fb7 smaller step forward 2022-09-01 10:06:00 -04:00
Andrey 1d1fd2da43 Revert "smaller step forward"
This reverts commit f0e6bcc279.
2022-09-01 09:10:11 -04:00
Andrey e1b3c3380f Revert "smaller step forward"
This reverts commit f388163d2a.
2022-09-01 09:10:07 -04:00
Andrey f388163d2a smaller step forward 2022-09-01 08:51:13 -04:00
Andrey f0e6bcc279 smaller step forward 2022-09-01 08:44:46 -04:00
GitHub gen-configs Action b712732dff Auto-generated configs and docs 2022-09-01 05:33:56 +00:00
Andrey 2cfe2a41b3 smaller step forward 2022-09-01 01:11:03 -04:00
Andrey ce5e618e3f smaller step forward 2022-09-01 01:08:51 -04:00
GitHub gen-configs Action 5237235e48 Auto-generated configs and docs 2022-09-01 04:53:05 +00:00
Andrey 9e14073feb c63fb29aaf partial rollback 2022-09-01 00:46:54 -04:00
Andrey da66fa055c refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
GitHub gen-configs Action 4f6f985d4f Auto-generated configs and docs 2022-09-01 04:18:59 +00:00
Andrey c63fb29aaf refactoring: reducing outputChannels copy 2022-09-01 00:13:55 -04:00
Andrey 28d797d5c2 moving confusion further away from fuel control 2022-08-31 23:59:40 -04:00
GitHub gen-configs Action 398003c65d Auto-generated configs and docs 2022-09-01 03:56:47 +00:00
Andrey dddec7cf06 currentEngineDecodedPhase as trigger central field 2022-08-31 23:31:35 -04:00
Andrey 6d3a6dc2f8 readability 2022-08-31 23:29:47 -04:00
Matthew Kennedy ca4936d3fe
rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
rusefillc b444e400eb docs 2022-08-29 10:51:32 -04:00
Andrey b7490590a2 TT_VVT_MAZDA_MYSTERY 2022-08-28 23:01:38 -04:00
Andrey 219a190fbc TT_VVT_MAZDA_MYSTERY 2022-08-28 22:43:03 -04:00
rusefillc 4b0c8c9ff2 TT_VVT_MAZDA_MYSTERY 2022-08-28 21:54:24 -04:00
Matthew Kennedy b662e59707
remove some uses of EFI_ERROR_CODE (#4496)
* lua hooks

* findAngleMatch

* s

* s
2022-08-28 09:43:21 -04:00
rusefillc 85490a497d
separate atomic picked from https://github.com/rusefi/rusefi/pull/4493 (#4495)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:26:56 -04:00
GitHub gen-configs Action cf8d43f412 Auto-generated configs and docs 2022-08-24 22:15:50 +00:00
Matthew Kennedy 73abcb044d
log the state of hasSynchronizedPhase() (#4478)
* s

* log whether we've synced phase

* trigger_state_primary

* need that file

* engine state is not the right spot
2022-08-24 18:11:05 -04:00
rusefillc 5007084981 VQ trigger gaps improvement fix #4469
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
rusefillc 859a66bb3b poke 3 2022-08-23 09:02:38 -04:00
rusefillc 7e690b0899 poke 2 2022-08-22 23:43:06 -04:00
rusefillc c0923f6efe poke 1 2022-08-22 23:42:48 -04:00
rusefillc 841b40d8ac RE: reasons for verbose messages 2022-08-22 22:52:48 -04:00
Matthew Kennedy aeb7c2e464
hard code vq cam gaps (#4471) 2022-08-22 19:40:24 -04:00
rusefillc b0edd12752 docs 2022-08-22 18:44:44 -04:00
Andrey a4a9a2c182 Revert "Revert "Revert "small step forward? (#4450)"""
This reverts commit 3fb0cb2516.
2022-08-21 15:23:20 -04:00
Andrey 3fb0cb2516 Revert "Revert "small step forward? (#4450)""
This reverts commit c97f86e8a7.
2022-08-21 14:43:50 -04:00
GitHub gen-configs Action c1b4e4374f Auto-generated configs and docs 2022-08-21 16:43:08 +00:00
rusefi 25778f0890 trigger gap logging: it's a mess :( 2022-08-21 12:38:29 -04:00
GitHub build-firmware Action fba78abdd5 Auto-generated configs and docs 2022-08-16 23:48:31 +00:00
Andrey c97f86e8a7 Revert "small step forward? (#4450)"
This reverts commit 10c3d5080a.
2022-08-16 19:43:46 -04:00
GitHub build-firmware Action 8c5c987b55 Auto-generated configs and docs 2022-08-16 23:06:34 +00:00
rusefillc 10c3d5080a
small step forward? (#4450)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-16 18:57:40 -04:00
GitHub build-firmware Action 5c131387ee Auto-generated configs and docs 2022-08-15 21:22:59 +00:00
GitHub build-firmware Action 83f2e1e7a6 Auto-generated configs and docs 2022-08-15 19:03:46 +00:00
GitHub build-firmware Action 4199384983 Auto-generated configs and docs 2022-08-15 18:43:52 +00:00
GitHub build-firmware Action 1946218699 Auto-generated configs and docs 2022-08-14 21:08:27 +00:00
GitHub build-firmware Action 8ac3ac7702 Auto-generated configs and docs 2022-08-14 20:14:30 +00:00
Matthew Kennedy 76f5832db9
resolve VVT phase using every tooth, not just sync point (#4434)
* resolve VVT phase using every tooth, not just sync point

* fix tests

* comment

* changelog
2022-08-12 08:08:23 -04:00
rusefillc f61cfcfd95 todo: huh? dead code? how can we get NAN from eventAngles table? 2022-08-11 20:05:29 -04:00
rusefillc b5c2b70e23 refactoring: better field name 2022-08-09 20:32:39 -04:00
rusefillc 122db2de95 fix Subaru EZ30 trigger gaps fix #4344 2022-07-31 10:15:16 -04:00
rusefillc 0424dd6f0e Extra gap ratios for custom trigger wheels fix #4375
these lines are now part of shared method
2022-07-23 10:00:55 -04:00
Andrey 20a16bd53b Extra gap ratios for custom trigger wheels fix #4375 2022-07-23 03:16:11 -04:00
rusefillc d92fa798ba RoverK - wow that's odd, but whatever 2022-07-12 02:42:41 -04:00
rusefillc 5fe87f091b looks dead 2022-07-12 01:38:25 -04:00
Matthew Kennedy e9d092f975
big delete ICU (#4270)
* big delete

* icu vestiges

* changelog
2022-07-07 15:27:59 -04:00
Matthew Kennedy c0f290b922
Injector scheduled by angle, not tooth index (#4208)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine

* injection doesn't care about teeth

* fix up existing tests

* oh look, we can actually test this logic now without trying to depend on trigger shape!!!

* fix a real bug

* simplify
2022-06-24 17:43:23 -04:00
Matthew Kennedy fcd3d991ee
trigger tweaks cleanup (#4278)
* simplify some math

* we say yes to the todo

* and put back that test

* test
2022-06-23 23:11:29 -04:00
rusefillc a4347668c5 https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 11:41:33 -04:00
rusefillc d639a42621 https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 07:43:23 -04:00
rusefi 271dddf61e verbose trigger sync should reuse engineSnifferRpmThreshold fix #4259 2022-06-18 15:18:45 -04:00
rusefi dacc43acad verbose trigger sync should reuse engineSnifferRpmThreshold #4259
docs
2022-06-18 14:44:21 -04:00
rusefi a552d58d42 verbose trigger sync should reuse engineSnifferRpmThreshold #4259
reducing complexity
2022-06-18 14:17:36 -04:00
rusefillc 9a9047c3f9 more info verbose trigger/vvt 2022-06-17 22:11:09 -04:00
rusefillc 6c1d2a297e more into "triggerinfo" 2022-06-17 22:10:48 -04:00
Matthew Kennedy 932f5e1f30
cam/crank sync improvements (#4152)
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit 32d46d1f09.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit d5e131b1d0.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy 4ada633206
Remove third trigger channel (#4226)
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy c0d8cbfef4
Trigger cleanup init (#4222)
* extra parameter

* name decoders in constructor

* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy 70c2689f1e
remove trigger duty cycle calculation (#4213)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix

* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy f945e6efc9
trigger configuration refactoring for clarity (#4212)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy d5a4804993
remove dead useOnlyFirstChannel (#4211)
* This field was ignored.

* move pad out

* gone
2022-05-30 07:03:40 -04:00
Matthew Kennedy 66fffee321
More trigger encapsulation (#4207)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
Matthew Kennedy e8be471b46
bail from trigger_central (#4210) 2022-05-29 10:42:08 -04:00
Matthew Kennedy 720c463ffb
trigger decoder returns a result (#4206) 2022-05-28 09:01:45 -04:00
Matthew Kennedy 90cc62a667
honda trigger sync ratio (#4194) 2022-05-24 17:12:36 -04:00
rusefillc e8ceaeabaf Pavel says 120 2022-05-24 14:40:54 -04:00
Matthew Kennedy 6f45d0fd46
Fix trigger error indicator (#4185)
* test and fix

* more shards!
2022-05-19 09:43:42 -04:00
Matthew Kennedy fe77f5127e
12 tooth crank mode (#4179)
* 12 tooth crank

* comment

* s

* rusefi config
2022-05-17 21:38:24 -04:00
Matthew Kennedy ae91b2aea8
don't rely on triggerStateListener to detect trigger errors (#4164)
* Write proper TriggerDecoder tests

* Improve logic around sync loss

* these tests I understand

* these I sort of understand....

* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00