Commit Graph

3442 Commits

Author SHA1 Message Date
Andrey G c1c9d5222a tle8888 dead code (#4568) 2022-09-12 18:54:29 -04:00
rusefillc 21a1914bc8 at the moment efiWatchdog always fails on enable, would this fix? 2022-09-11 21:31:42 -04:00
rusefi 95e7358fce at the moment efiWatchdog always fails on enable, would this fix? 2022-09-11 21:15:25 -04:00
Andrey G 2b4012b279 dead code, reduce typedefs (#4566)
* Do lightweight checks first

* Dead getTimeIgnitionSeconds()

Dead since 5274cffff3

* Get rid of efitime_t.

Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.

* Fix unit tests

* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G 1ca5988877 time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
Andrey G c73a8c2f46 efiWatchdog: avoid converting time to float (#4562)
https://stackoverflow.com/questions/68690961/why-does-converting-int-to-float-lose-precision-in-c-programming-language
2022-09-11 05:46:55 -04:00
GitHub gen-configs Action 97f1ee67d6 Auto-generated configs and docs 2022-09-11 07:53:45 +00:00
rusefillc 921b97431f refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc 8a2975cc1e dead value 2022-09-11 02:34:02 -04:00
rusefillc f9b849dd8f refactoring - reducing API between FW and Java 2022-09-11 02:16:47 -04:00
rusefillc 202c6ba366 send more of Engine Sniffer data #4560
new API & first usage
2022-09-10 23:42:59 -04:00
rusefillc d569f49874 Proteus with SD card outside of vehicle looses a second #4557
message correction
2022-09-10 11:43:25 -04:00
rusefillc 05fa36e744 Mark is asking for VIN number field #3967
GM says Hi
2022-09-10 01:05:31 -04:00
rusefillc 1964f2e893 Proteus with SD card outside of vehicle looses a second #4557 2022-09-09 20:17:02 -04:00
rusefillc f5231ebb85 "Blip" with trigger error on several boards #4552
exploratory watchdog
2022-09-09 19:21:29 -04:00
rusefillc 64ab64d7de "Blip" with trigger error on several boards #4552
exploratory watchdog
2022-09-09 18:27:16 -04:00
rusefillc b9140636b4 refactoring: better method name 2022-09-09 18:02:38 -04:00
rusefillc 9bb35a3d97 How does rusEFI handle 23 (or 46?) days of continues operation #4554 2022-09-09 17:21:58 -04:00
Andrey f8d275f64b tear down Engine god object #4511
just trying different things
2022-09-07 20:25:49 -04:00
Andrey a7c8ce61f4 brutal encapsulation 2022-09-07 19:37:11 -04:00
Andrey 8f14c44097 extracting prime_injection 2022-09-07 16:25:50 -04:00
Andrey 25b6d39802 os_access.h dead? 2022-09-07 15:56:45 -04:00
Andrey ab3d92b995 tear down Engine god object #4511
just trying different things
2022-09-05 04:24:17 -04:00
Andrey b6eddaee59 tear down Engine god object #4511
just trying different things
2022-09-05 03:38:44 -04:00
Andrey f8febab683 tear down Engine god object #4511
just trying different things
2022-09-05 03:18:32 -04:00
Andrey da7a4b6641 tear down Engine god object #4511
just trying different things
2022-09-05 02:59:38 -04:00
Andrey 76b74a85ba tear down Engine god object #4511
just trying different things
2022-09-05 02:44:06 -04:00
Andrey 1983a07078 tear down Engine god object #4511
just trying different things
2022-09-05 02:28:46 -04:00
Andrey 82fa9b191a refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Andrey 841cd4f962 refactoring: moving field 2022-09-05 00:53:05 -04:00
Andrey 9a9b33401c refactoring: splitting header where cpp was already split 2022-09-05 00:48:38 -04:00
Andrey e9e040895b different file names for different entities 2022-09-04 23:11:19 -04:00
GitHub gen-configs Action 0a37c6d963 Auto-generated configs and docs 2022-09-05 02:44:56 +00:00
Andrey 8fd5e46472 refactoring: reducing outputChannels copy 2022-09-04 22:38:05 -04:00
GitHub gen-configs Action 19addcb2ff Auto-generated configs and docs 2022-09-04 13:57:19 +00:00
Matthew Kennedy 99161cc523 use defs instead of magic numbers (#4523)
* use defs instead of magic numbers

* consecutive
2022-09-04 09:52:14 -04:00
Matthew Kennedy fba0906942 more granular trigger error messages (#4526)
* granular trigger error messages

* adjust test expectations

* explicitly test behavior
2022-09-04 09:15:24 -04:00
GitHub gen-configs Action 4857561a0d Auto-generated configs and docs 2022-09-03 21:35:26 +00:00
rusefi 42e95a0b34 refactoring: reducing outputChannels copy 2022-09-03 17:29:35 -04:00
Andrey f008a98b94 refactoring: reducing outputChannels copy 2022-09-03 17:12:47 -04:00
Andrey 93032c7c1f tear down Engine god object #4511
just trying different things
2022-09-03 11:07:26 -04:00
Andrey 73423a612a tear down Engine god object #4511
just trying different things
2022-09-03 11:05:27 -04:00
Andrey e56924310b tear down Engine god object #4511
just trying different things
2022-09-03 07:44:24 -04:00
rusefillc 78b28c8f90 typo 2022-09-03 07:26:49 -04:00
Andrey 51396deefa dead 2022-09-03 06:59:00 -04:00
GitHub gen-configs Action 59543fa221 Auto-generated configs and docs 2022-09-02 18:42:52 +00:00
rusefillc 54e05ba0fc moving state into specific class (#4520)
* moving state into specific class

* moving state into specific class
2022-09-02 14:38:03 -04:00
rusefillc 0e27ec6633 another huh (#4517)
* another huh

* why does this not compile
2022-09-02 13:10:21 -04:00
rusefillc f8e37e6af7 I am sure that's not magic (#4516)
* I am sure that's not magic

* forward declaration acts funny
2022-09-01 22:33:45 -04:00
Andrey 254385feb2 another dead line 2022-09-01 21:13:03 -04:00
Andrey 074e5c840b Revert "tear down Engine god object #4511"
This reverts commit 3094cc6be7.
2022-09-01 20:44:51 -04:00
Andrey b017ef8031 Revert "tear down Engine god object #4511"
This reverts commit 2d689f5a5a.
2022-09-01 20:44:51 -04:00
Andrey 22c9b6896d what a mess :( 2022-09-01 20:16:57 -04:00
Andrey 2d689f5a5a tear down Engine god object #4511
just trying different things
2022-09-01 20:16:41 -04:00
Andrey 3094cc6be7 tear down Engine god object #4511
just trying different things
2022-09-01 20:15:46 -04:00
Andrey 05e851c138 tear down Engine god object #4511
just trying different things
2022-09-01 19:24:19 -04:00
GitHub gen-configs Action 8785db9762 Auto-generated configs and docs 2022-09-01 23:18:26 +00:00
Andrey c9008214f5 tear down Engine god object #4511
just trying different things
2022-09-01 19:05:40 -04:00
Andrey d1917a2a62 tear down Engine god object #4511
just trying different things
2022-09-01 19:00:16 -04:00
Matthew Kennedy 716b0c1f60 extract updateInjectionAngle (#4512) 2022-09-01 18:48:03 -04:00
Andrey 80fa25488a tear down Engine god object #4511
smallest step maybe forward
2022-09-01 13:55:03 -04:00
Andrey 1ffa98ba89 a bit of dead code 2022-09-01 11:47:56 -04:00
GitHub gen-configs Action f19c219587 Auto-generated configs and docs 2022-09-01 15:03:34 +00:00
Andrey 436c294770 refactoring: reducing outputChannels copy 2022-09-01 10:58:16 -04:00
GitHub gen-configs Action bac4f9800f Auto-generated configs and docs 2022-09-01 14:39:52 +00:00
Andrey 09f0a540b6 refactoring: reducing outputChannels copy 2022-09-01 10:30:07 -04:00
Andrey b64e553d5d refactoring: reducing outputChannels copy 2022-09-01 01:06:49 -04:00
Andrey 2a949f6cd2 dead code 2022-09-01 00:23:33 -04:00
Andrey ea22fcbe95 refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
Andrey be790e2c44 less code is better 2022-08-31 23:14:20 -04:00
Andrey 3eaaf5e293 english do you speak it 2022-08-31 22:56:38 -04:00
GitHub gen-configs Action 0c4945eacf Auto-generated configs and docs 2022-09-01 02:17:58 +00:00
Matthew Kennedy 0863ac1a11 rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
Matthew Kennedy d9ca1fb578 set a default, detect error (#4504) 2022-08-31 20:32:37 -04:00
Matthew Kennedy 4035d79a91 idle always uses instant rpm (#4499)
* idle always uses instant rpm

* configs

* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy 2926570747 idle coasting table is RPM, not clt (#4487)
* idle coasting table is RPM, not clt

* default

* autoscale

* changelog
2022-08-29 08:15:04 -04:00
GitHub gen-configs Action e89eff7370 Auto-generated configs and docs 2022-08-29 03:13:09 +00:00
rusefillc 6be7438cf0 TT_VVT_MAZDA_MYSTERY 2022-08-28 22:57:44 -04:00
GitHub gen-configs Action 9a91c80632 Auto-generated configs and docs 2022-08-29 02:18:23 +00:00
rusefillc 35f17f38b3 TT_VVT_MAZDA_MYSTERY 2022-08-28 21:54:24 -04:00
rusefillc b3dfbd5a1d more proper fix for part of https://github.com/rusefi/rusefi/pull/4493 2022-08-27 22:28:29 -04:00
rusefillc 6968d74b3c separate atomic change (#4494)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:09:54 -04:00
rusefillc da9639ff5d Default GPPWM note 2022-08-27 15:19:35 -04:00
rusefillc c0391b16e4 docs 2022-08-25 23:50:00 -04:00
rusefillc 7e6bb54e7a saving 4 bytes of RAM? 2022-08-25 22:34:16 -04:00
rusefillc 72c4637512 progress or maybe even a fix of logging? 2022-08-25 22:24:35 -04:00
rusefillc fb3343dff5 this code is too dead 2022-08-25 22:09:22 -04:00
Matthew Kennedy 08d2aee17b dfco delay (#4482)
* dfco delay

* config

* using a function that doesn't exist? who does that

* test new behavior

* clearer test
2022-08-25 21:26:17 -04:00
Andrey 5392f8d13e https://github.com/rusefi/hellen154hyundai/issues/60
extra logging
2022-08-25 19:58:10 -04:00
GitHub gen-configs Action 1117be38e3 Auto-generated configs and docs 2022-08-25 22:51:12 +00:00
rusefi 10d77f92b3 https://github.com/rusefi/hellen154hyundai/issues/60 2022-08-25 18:44:23 -04:00
GitHub gen-configs Action 2629924a06 Auto-generated configs and docs 2022-08-24 22:15:50 +00:00
Matthew Kennedy dfd340e8c3 log the state of hasSynchronizedPhase() (#4478)
* s

* log whether we've synced phase

* trigger_state_primary

* need that file

* engine state is not the right spot
2022-08-24 18:11:05 -04:00
GitHub gen-configs Action 8577e7b882 Auto-generated configs and docs 2022-08-24 16:16:12 +00:00
rusefi 7340700b74 refactoring 2022-08-24 12:11:11 -04:00
rusefi 31df3da2cf refactoring 2022-08-24 12:02:39 -04:00
rusefillc ecdde2cf6d docs 2022-08-23 22:54:48 -04:00
GitHub gen-configs Action 3bbb26ed24 Auto-generated configs and docs 2022-08-24 02:19:34 +00:00
rusefillc 13f9e6d76a log the state of hasSynchronizedPhase() for future diagnostic help. 2022-08-23 22:14:32 -04:00
GitHub gen-configs Action 9ce8250a90 Auto-generated configs and docs 2022-08-22 22:32:47 +00:00
rusefillc 101d597d9a // todo: migrate to engineState->desiredRpmLimit to get this variable logged 2022-08-22 18:23:48 -04:00
GitHub gen-configs Action 525509a260 Auto-generated configs and docs 2022-08-22 15:19:58 +00:00
rusefillc 27b5db8789 Pavel Xenon is asking for EGT limping mode #3172 2022-08-22 11:12:34 -04:00
rusefillc 06018ada5b Idle air add via Lua fix #4465
AddressSanitizer being useful?
2022-08-21 00:58:59 -04:00
rusefillc 38e3a84ec9 Idle air add via Lua fix #4465 2022-08-21 00:32:34 -04:00
Matthew Kennedy 6218edd040 allow logging multiple warnings at once (#4414)
* allow logging multiple warnings at once

* comment

* .Code

* Revert ".Code"

This reverts commit 2b986bd50035aeec051d11aafd83fdbc1694351c.

* add a better comparison operator instead of conversion

* dot code

* Revert "dot code"

This reverts commit 35f6ae1007c41e3b30ea129a324f33ab4205036d.

* force gcc-10 maybe?

* Revert "force gcc-10 maybe?"

This reverts commit 4ddf8bcefddd354ccdc1da682c5fff1e68d44273.

* vq

* dot code

* dead

* dot code

* return may be null

* static_vector; maybe cyclic_buffer is broken or wrong tool for the job?

* move static vector

* put cyclic buffer back how it was since we don't use it now
2022-08-17 01:12:25 -04:00
GitHub gen-configs Action 1343699a2f Auto-generated configs and docs 2022-08-17 05:08:02 +00:00
rusefillc dfd4953f0d unconditional VVT PID logging 2022-08-17 00:47:31 -04:00
rusefillc bf15c5bc8a ISO-TP does not work on real car #4427 2022-08-09 13:12:51 -04:00
Matthew Kennedy eb442998dc misc fixes (#4411)
* fix warnings

* break to debugger in case of panic

* move the check

* s
2022-08-02 12:19:50 -04:00
Matthew Kennedy f49f6494fb report injector, ignition faults (#4408)
* report injector, ignition faults

* guard
2022-08-01 15:41:47 -04:00
Matthew Kennedy d4721bee89 implement sensor checker (#4395)
* implement sensor checker

* use default

* s

* fix

* properly report non-timeout errors

* it's not safe to read Value when invalid

* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
rusefillc ee455d23f8 [SECURITY] Cheap password protection against tune modification fix #4243
helping build
2022-07-30 14:33:11 -04:00
rusefillc e19b61aa5b [SECURITY] Cheap password protection against tune modification fix #4243 2022-07-30 12:23:53 -04:00
Matthew Kennedy 14b39b7b0a unexpected contains information about why it failed (#4393)
* unexpected can contain information

* info printing

* sensors return appropriate error codes

* remove reliance on undefined behavior

* s
2022-07-28 10:04:28 +03:00
GitHub build-firmware Action dcc43ee4b4 Auto-generated configs and docs 2022-07-27 09:38:56 +00:00
Matthew Kennedy 4865213537 Log gppwm output values (#4385)
* remove debug option

* purpose built output channels

* name

* embiggen sd log buffer

* Revert "embiggen sd log buffer"

This reverts commit 37432a56535b24c221ae92e9aaded23de4d4a579.

* embiggen SD log buffer
2022-07-27 12:10:00 +03:00
rusefillc 58b0aaeda1 cherry pick https://github.com/rusefi/rusefi/pull/4365 2022-07-21 15:26:41 -04:00
rusefillc 2bc4fd909d Launch control bug? "range" thing is confusing #4348
a typo and configurable behaviour without UI
2022-07-20 18:48:55 -04:00
rusefillc 116207e9aa Launch control bug? "range" thing is confusing #4348 2022-07-20 18:39:17 -04:00
rusefillc 2ba07e975e Launch control bug? "range" thing is confusing #4348
bug or dead code? at least making it a bit more obvious
2022-07-20 18:30:20 -04:00
rusefillc f9ba8bf82c Launch control bug? "range" thing is confusing #4348
refactoring: reducing confusion
2022-07-20 18:24:36 -04:00
rusefillc 8213252f45 code formatting #4348 2022-07-20 18:16:54 -04:00
Matthew Kennedy cd98ad35c2 use libfirmware for a few things (#4351)
* use libfirmware

* unit tests

* crc

* missed one

* bootloader
2022-07-16 02:22:51 -04:00
rusefillc 4ba73d1679 Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 14:04:21 -04:00
rusefillc 456d52e1fe Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 13:03:08 -04:00
rusefillc 9e8bfe92d8 #4308 progress 2022-07-14 12:36:55 -04:00
rusefillc db3f92edf4 Lua A/C Input #4333 2022-07-08 00:51:53 -04:00
GitHub build-firmware Action 1d148c57df Auto-generated configs and docs 2022-07-08 04:45:52 +00:00
rusefillc c23fe0fe9a Lua A/C Input #4333 2022-07-08 00:25:29 -04:00
Matthew Kennedy 16a39badff Error handling cleanup (#4332)
* dead code in stm32

* rusefi.cpp can have some noreturn

* handle lua panic

* unused error codes

* simplifications of error_handling.cpp

* comment

* put that back

* guard
2022-07-07 23:49:02 -04:00
GitHub build-firmware Action bba4a89f3e Auto-generated configs and docs 2022-07-08 03:21:52 +00:00
Matthew Kennedy 68fb838641 Lua hooks for gear detection (#4328)
* implement

* sim has vss

* write a test

* guard
2022-07-07 23:16:56 -04:00
rusefillc c51881a80d debug is set to idle mode, but none of the debug fields show anything #4335
reducing confusion
2022-07-07 23:04:19 -04:00
Matthew Kennedy 6267b8621a big delete ICU (#4270)
* big delete

* icu vestiges

* changelog
2022-07-07 15:27:59 -04:00
Matthew Kennedy b5d85334c3 hellen board ID detect improvements (#4307)
* move call

* board detections work correctly

* improve detector

* s

* break instead of return

* tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-02 05:19:02 -04:00
rusefillc 129e4df5bf Uniform reset pattern for all Lua adjustments #4308
no progress only preparation
2022-06-30 20:07:27 -04:00
GitHub build-firmware Action 784309ca86 Auto-generated configs and docs 2022-06-30 17:53:57 +00:00
rusefillc 970c1b3422 https://github.com/rusefi/rusefi_documentation/issues/226 2022-06-30 13:38:15 -04:00
rusefillc f24c42c605 https://github.com/rusefi/rusefi_documentation/issues/226 (#4306)
* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-06-29 23:34:00 -04:00
Matthew Kennedy 67439afb96 rescale RPM values (#4300)
* rpm configs

* fix

* s

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-29 18:48:30 -04:00
GitHub build-firmware Action 7d5f4cac7c Auto-generated configs and docs 2022-06-29 22:16:13 +00:00
Matthew Kennedy baa7d17799 use detected hellen board type on h72 (#4305)
* use detected hellen board type

* s

* s

* name
2022-06-29 18:10:29 -04:00
Andrey 65ffcc4f37 logging of live data structs was: data points #3614 2022-06-29 03:27:51 -04:00
rusefillc a363be35bb logging of live data structs was: data points #3614 2022-06-29 03:03:02 -04:00
rusefillc fb84241a48 logging of live data structs was: data points #3614 2022-06-29 03:01:13 -04:00
rusefillc 92119af801 logging of live data structs was: data points #3614 2022-06-29 02:37:24 -04:00
GitHub build-firmware Action 58c34d398e Auto-generated configs and docs 2022-06-29 06:21:31 +00:00
rusefillc 3283ce7348 logging of live data structs was: data points #3614 2022-06-29 02:16:15 -04:00
rusefillc 61f6423a42 logging of live data structs was: data points #3614 2022-06-29 02:09:37 -04:00
GitHub build-firmware Action 5247d1f717 Auto-generated configs and docs 2022-06-29 06:06:27 +00:00
rusefillc 2e28537776 logging of live data structs was: data points #3614 2022-06-29 01:49:59 -04:00
rusefillc 0072f3559c logging of live data structs was: data points #3614 2022-06-29 01:38:43 -04:00
rusefillc 2ab71f88e5 logging of live data structs was: data points #3614 2022-06-29 01:27:42 -04:00
GitHub build-firmware Action 09e89f54dc Auto-generated configs and docs 2022-06-29 05:23:15 +00:00
rusefillc 69be42ea33 https://github.com/rusefi/hellen-NB2-issues/issues/36 2022-06-29 01:15:11 -04:00
GitHub build-firmware Action 81f1df25e4 Auto-generated configs and docs 2022-06-27 00:12:14 +00:00
rusefillc 4cbc267c4b stealing from David 2022-06-26 19:40:54 -04:00
Matthew Kennedy 88ff234c91 Injector scheduled by angle, not tooth index (#4208)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine

* injection doesn't care about teeth

* fix up existing tests

* oh look, we can actually test this logic now without trying to depend on trigger shape!!!

* fix a real bug

* simplify
2022-06-24 17:43:23 -04:00
GitHub build-firmware Action fbdebdc20e Auto-generated configs and docs 2022-06-24 00:20:41 +00:00
Matthew Kennedy 840bf6fb27 wideband live data (#4276)
* wideband live data magic

* test build happy

* test even happier
2022-06-23 20:04:26 -04:00
Matthew Kennedy 478549ccdf get rid of setSerialConfigurationOverrides (#4274)
* get rid of setSerialConfigurationOverrides

* missed a few

* kinetis
2022-06-23 19:42:09 -04:00
Matthew Kennedy 98e0297987 force o2 heating (#4275) 2022-06-23 14:32:34 -04:00
rusefi aae5b9fab6 miata 96 defaults 2022-06-23 14:30:41 -04:00
Matthew Kennedy be3e64fd2a clean up sd overrides (#4272) 2022-06-23 09:15:51 -04:00
GitHub build-firmware Action f6f0e2fcde Auto-generated configs and docs 2022-06-20 15:49:50 +00:00
rusefillc 60b8aa71de https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 11:41:33 -04:00
GitHub build-firmware Action d8d7ab66f7 Auto-generated configs and docs 2022-06-20 11:50:51 +00:00
rusefillc 22e3ab8220 https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 07:43:23 -04:00
Matthew Kennedy 40106224f0 Write output channels with new parser (#4219)
* let the new parser run

* s

* support for output channels

* usages reader uses new parser for output channels

* better debugging configuration

* bad merge

* test it a bit too

* more tests

* copy/paste the same content from other file

* s

* fix bugs where even the existing logic tries to write as an enum (?)

* jar

* print stream always unix

* print stream always unix

* use typedefs correctly

* jar

* stub support for multiple of each type

* s

* s

* name some more datas
2022-06-19 09:52:23 -04:00
rusefi 514531bc5c verbose trigger sync should reuse engineSnifferRpmThreshold #4259
reducing complexity
2022-06-18 14:17:36 -04:00
Matthew Kennedy 808287dc71 fix (#4254) 2022-06-17 21:20:47 -04:00
Matthew Kennedy 27c98f70fe cam/crank sync improvements (#4152)
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit e64c8cfccb.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit 5454b8f509.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
GitHub build-firmware Action db929ea937 Auto-generated configs and docs 2022-06-02 01:31:50 +00:00
Matthew Kennedy c2f61dc95f Remove third trigger channel (#4226)
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy 56e7acd869 Trigger cleanup init (#4222)
* extra parameter

* name decoders in constructor

* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy 5f1801f9d6 trigger configuration refactoring for clarity (#4212)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix
2022-05-30 19:36:47 -04:00
rusefillc 3cc4e3143c TS injector bench test pulse is too short fix #4192 2022-05-22 09:43:09 -04:00
rusefillc 5902a55739 B6 test mule 2022-05-21 02:25:43 -04:00
GitHub build-firmware Action ba5910652d Auto-generated configs and docs 2022-05-21 05:58:46 +00:00
rusefillc fb3b1120b1 B6 test mule 2022-05-21 01:45:09 -04:00
GitHub build-firmware Action 80a44ad098 Auto-generated configs and docs 2022-05-18 04:16:08 +00:00
Matthew Kennedy a0d9a584db prototype overcurrent protected driver (#4029)
* stub passthrough protected driver

* plumbing

* include the thing

* signature

* dead

* tdg pdm build task

* s

* pdm pins

* tdg

* init properly

* remove gaps

* board doesn't fatal on start
2022-05-17 23:49:18 -04:00
GitHub build-firmware Action 19522865a5 Auto-generated configs and docs 2022-05-18 03:21:00 +00:00
Matthew Kennedy eb257b2335 12 tooth crank mode (#4179)
* 12 tooth crank

* comment

* s

* rusefi config
2022-05-17 21:38:24 -04:00
rusefillc 62698dbe99 PDM dreams 2022-05-17 21:18:43 -04:00
rusefillc c03ee706bf default VR curve is needed not just by hellen, we have Proteus adapters with it now! 2022-05-17 17:54:11 -04:00
rusefillc ab711cddc5 dead code 2022-05-15 10:13:47 -04:00
Matthew Kennedy 0c9a45a2ac no enum to string for obd (#4168) 2022-05-13 06:41:06 +03:00
rusefillc 7ecab834ac docs 2022-05-12 04:56:23 -04:00
GitHub build-firmware Action c097309234 Auto-generated configs and docs 2022-05-11 10:51:10 +00:00
Matthew Kennedy fa835950a0 remove 360 trigger (#4165)
* remove 360

* s

* simplify that mess
2022-05-11 06:15:06 -04:00
Matthew Kennedy cf89b42716 move logic in to trigger decoder (#4162)
* move logic in to trigger decoder

* status loop

* minor cleanup

* s
2022-05-10 23:55:28 +03:00
Matthew Kennedy b243d3fca0 TriggerState -> TriggerDecoder (#4157) 2022-05-10 11:41:39 +03:00
Matthew Kennedy 2161751187 clarify doesTriggerImplyOperationMode (#4153) 2022-05-09 15:28:30 -04:00
rusefillc 178721c809 Remove value copy from controller into outputChannels #4095 2022-05-09 06:12:17 -04:00
rusefillc b6525e8acc User was unable to find Ford Mustang firing order 1-5-4-2-6-3-7-8 in the list #4150 2022-05-08 07:11:53 -04:00
rusefillc c557b4ec30 Revert "Ford Mustang firing order 1-5-4-2-6-3-7-8 fix #4150"
This reverts commit 086b4885c9.
2022-05-08 07:10:54 -04:00
rusefillc 086b4885c9 Ford Mustang firing order 1-5-4-2-6-3-7-8 fix #4150 2022-05-08 07:07:34 -04:00
GitHub build-firmware Action 37b0211bc7 Auto-generated configs and docs 2022-05-06 12:32:54 +00:00
Matthew Kennedy 997565ac22 Trigger gm 3 vs 5 (#4140)
* add parameter

* two modes

* add new mode to list

* format

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
rusefillc 0ed0702536 Make ETB low limit configurable fix #4119 2022-05-02 05:24:50 -04:00
GitHub build-firmware Action 7db1d3d0d2 Auto-generated configs and docs 2022-05-02 09:02:46 +00:00
Andrey 1f6e09de84 Technical debt: ENUM_32_BITS #3874
one step back
2022-05-02 04:38:04 -04:00
GitHub build-firmware Action a2366d187e Auto-generated configs and docs 2022-05-02 08:21:38 +00:00
rusefillc c84a32f194 Next steps 4 (#4130)
* Technical debt: ENUM_32_BITS #3874

* Make ETB low limit configurable #4119

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-05-02 04:13:59 -04:00
Andrey 03662e48c4 Move curves out of engineConfiguration in order to reduce RAM usage #4127 2022-05-01 23:43:43 -04:00
GitHub build-firmware Action 75166b15d1 Auto-generated configs and docs 2022-05-02 03:14:48 +00:00
rusefillc 78ca563cc4 Technical debt: ENUM_32_BITS #3874 2022-05-01 23:07:12 -04:00
GitHub build-firmware Action 9a2302eb40 Auto-generated configs and docs 2022-05-01 19:20:46 +00:00
rusefillc d8fc872fba Technical debt: ENUM_32_BITS #3874
hmm one step back
2022-05-01 15:13:01 -04:00
GitHub build-firmware Action 0c4e27e557 Auto-generated configs and docs 2022-05-01 18:18:04 +00:00
rusefillc 6aa2c54768 Technical debt: ENUM_32_BITS #3874 2022-05-01 13:51:36 -04:00
GitHub build-firmware Action 0d0a42a61d Auto-generated configs and docs 2022-05-01 12:09:38 +00:00
rusefillc 2b11b54003 Next steps (#4120)
* Technical debt: ENUM_32_BITS #3874

* Technical debt: ENUM_32_BITS #3874

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-05-01 08:02:51 -04:00
GitHub build-firmware Action 6418d7b11b Auto-generated configs and docs 2022-04-30 18:29:47 +00:00
rusefillc a0da677a1e this seems mostly dead? 2022-04-30 13:43:09 -04:00
rusefillc e78b93ee07 oh not all dead 2022-04-30 13:35:25 -04:00
rusefillc a1d89cb093 Technical debt: ENUM_32_BITS #3874 2022-04-30 13:16:34 -04:00
rusefillc 1f590637ab wow dead code 2022-04-30 13:09:03 -04:00
GitHub build-firmware Action 4a4ebb4505 Auto-generated configs and docs 2022-04-30 17:07:03 +00:00
rusefillc 1ae5625801 Technical debt: ENUM_32_BITS #3874 2022-04-30 12:54:12 -04:00
GitHub build-firmware Action d2d07e40ff Auto-generated configs and docs 2022-04-30 02:32:30 +00:00
Andrey 33b4f8f86d CAN GPIO #4096 2022-04-29 22:15:54 -04:00
GitHub build-firmware Action 94b9e4a5b1 Auto-generated configs and docs 2022-04-30 00:36:25 +00:00
rusefillc 4af8a13a31 CAN GPIO #4096 2022-04-29 20:29:50 -04:00
rusefillc f341ce561e 2 byte pin index #4097 (#4102)
* 2 byte pin index #4097

* 2 byte pin index #4097

good time to defragment configuration

* 2 byte pin index #4097

new fancy way

* 2 byte pin index #4097

smart comment

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-04-29 19:35:31 -04:00
GitHub build-firmware Action b84cb0d83a Auto-generated configs and docs 2022-04-28 22:06:22 +00:00
Matthew Kennedy 83caf1ea1b Brain pin is enum class (#4108)
* change most usages to Gpio::

* board configs

* engine configs etc

* isBrainPinValid, smart gpio

* generator

* generator

* generator

* connector yamls

* kinetis enums

* cypress txt

* kinetis config

* frankenso

* config generator

* actually do it for the others

* disable skips for pr ci

* fix tle8888

* misc

* weird cast from int

* needs this operator too

* this can be an unsigned subtract

* happy tests

* s

* kinetis isConfigurationChanged weirdness

* missed J/K

* cypress efifeatures

* build script mistake (!)

* mistake in smart gpio

* debounce

* eg33

* kinetis, so needy

* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
Matthew Kennedy 2d033df11b more missing autoscale (#4112)
* autoscale m_config->timeConstant

* min/max afr

* more

* dwell voltage

* closed loop fuel

* knock

* map estimate

* applyNonlinearBelowPulse

* fix

* add a test while we're at it for un-covered code

* test fallback MAP since we touched that

* always compute fallback MAP even if sensor is OK
2022-04-28 08:16:02 -04:00
Matthew Kennedy a2e1a079b8 allow enum_class in rusefi_hw_enums.h (#4104)
* make things c++ friendly

* install various canaries in coal mines

* using is much clearer than typedef

* fixing builds

* lps25

* trigger includes were a mess

* c -> c++ cleanup

* os util

* why did so many include os_util.h?

* fwd declare

* cypress/kinetis

* s

* eg33 happy

* happy sim

* cypress usb

* pch

* cypress

* doesn't need to include all that

* h7
2022-04-25 20:38:16 -04:00
rusefillc d5fb1113d3 [EPIC] [Feature Request] Transmission Control #1454 2022-04-25 17:42:19 -04:00
rusefillc 7d2d6c4a01 [EPIC] [Feature Request] Transmission Control #1454 2022-04-25 17:20:56 -04:00
rusefillc e0e61f7f44 FasterEngineSpinUp should be enabled by default fix #4094 2022-04-23 09:51:47 -04:00
David Holdeman b4e8dfb05a More untested transmission features (#4093)
* use ISS for gearbox ratio, add gauge for TC ratio

* measure shift time

* add shift time gauge, todo notes for pc

* do conversion in the right direction

* switch to Timer and seconds

* try fixing build

* try fixing build again

* try defines, remove include

* use shift pcs

* add 3-2 pct curve

* control 3-2 solenoid

* move 3-2 to persistent config

* fix param
2022-04-23 07:34:39 -04:00
rusefillc 57f04b6aed https://github.com/rusefi/alphax-2chan/issues/50 2022-04-19 20:43:41 -04:00
GitHub build-firmware Action a54a535443 Auto-generated configs and docs 2022-04-18 21:53:02 +00:00
rusefillc 001b5cb07e life is better without special characters 2022-04-18 17:36:28 -04:00
rusefillc b252533889 actually let's remove the duplicates 2022-04-18 11:43:49 -04:00
rusefillc a6108bafbf unique field names 2022-04-18 11:11:57 -04:00
Matthew Kennedy 8650686ab7 knock threshold table fix (#4077)
* fix knock threshold table

* defaults

* knock controller is engine module

* testable

* test builds

* knock tests work

* s

* format

* everyone loves changelogs
2022-04-18 08:03:16 -04:00
rusefillc e4d9664c09 minor fix 2022-04-17 22:48:57 -04:00
GitHub build-firmware Action 783aa1451c Auto-generated configs and docs 2022-04-17 20:30:07 +00:00
rusefillc 16a6112002 one step sideways to fix build 2022-04-16 21:24:02 -04:00
rusefillc 0ba512c925 logging of live data structs was: data points #3614
progress
2022-04-16 21:04:02 -04:00
GitHub build-firmware Action 4f35c31c44 Auto-generated configs and docs 2022-04-16 23:33:47 +00:00
rusefillc fc128e1954 logging of live data structs was: data points #3614 2022-04-16 19:18:03 -04:00
rusefillc cb4979e068 very random progress 2022-04-16 17:07:57 -04:00
GitHub build-firmware Action 959840bc03 Auto-generated configs and docs 2022-04-15 14:34:37 +00:00
Matthew Kennedy 735b4899e2 allow setting injection phase by start or center of injection (#4068)
* allow SOI/COI

* other change

* renames and simplify

* clean up ownIndex

* double check in spark logic
2022-04-15 10:22:36 -04:00