Matthew Kennedy
fcb9897443
resolve VVT phase using every tooth, not just sync point ( #4434 )
...
* resolve VVT phase using every tooth, not just sync point
* fix tests
* comment
* changelog
2022-08-12 08:08:23 -04:00
rusefillc
f11480597d
todo: huh? dead code? how can we get NAN from eventAngles table?
2022-08-11 20:05:29 -04:00
rusefillc
d97bcec161
refactoring: better field name
2022-08-09 20:32:39 -04:00
rusefillc
64c76bf59c
fix Subaru EZ30 trigger gaps fix #4344
2022-07-31 10:15:16 -04:00
rusefillc
cfd6828d42
Extra gap ratios for custom trigger wheels fix #4375
...
these lines are now part of shared method
2022-07-23 10:00:55 -04:00
Andrey
43bc08bc24
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:16:11 -04:00
rusefillc
250d8c4213
RoverK - wow that's odd, but whatever
2022-07-12 02:42:41 -04:00
rusefillc
b2cbd889f9
looks dead
2022-07-12 01:38:25 -04:00
Matthew Kennedy
6267b8621a
big delete ICU ( #4270 )
...
* big delete
* icu vestiges
* changelog
2022-07-07 15:27:59 -04:00
Matthew Kennedy
88ff234c91
Injector scheduled by angle, not tooth index ( #4208 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
* injection doesn't care about teeth
* fix up existing tests
* oh look, we can actually test this logic now without trying to depend on trigger shape!!!
* fix a real bug
* simplify
2022-06-24 17:43:23 -04:00
Matthew Kennedy
d5f1235a43
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
rusefillc
60b8aa71de
https://rusefi.com/forum/viewtopic.php?f=5&t=2353
2022-06-20 11:41:33 -04:00
rusefillc
22e3ab8220
https://rusefi.com/forum/viewtopic.php?f=5&t=2353
2022-06-20 07:43:23 -04:00
rusefi
214d38f286
verbose trigger sync should reuse engineSnifferRpmThreshold fix #4259
2022-06-18 15:18:45 -04:00
rusefi
dcde5cea9e
verbose trigger sync should reuse engineSnifferRpmThreshold #4259
...
docs
2022-06-18 14:44:21 -04:00
rusefi
514531bc5c
verbose trigger sync should reuse engineSnifferRpmThreshold #4259
...
reducing complexity
2022-06-18 14:17:36 -04:00
rusefillc
9d942a1c4a
more info verbose trigger/vvt
2022-06-17 22:11:09 -04:00
rusefillc
f3a5b027d9
more into "triggerinfo"
2022-06-17 22:10:48 -04:00
Matthew Kennedy
27c98f70fe
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit e64c8cfccb
.
* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"
This reverts commit 5454b8f509
.
* remove synchronizedPhase
* only crank needs this
* changelog
* needsDisambiguation()
* test
* s
* bad merge
* put the timer back
* s
* s
* changelog
* test for new behavior
* correct parameter order
* spelling
* s
* s
* s
* tests merge happy
* bad merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy
c2f61dc95f
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy
56e7acd869
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy
54c339c0a4
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy
5f1801f9d6
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy
b5d212dcd8
remove dead useOnlyFirstChannel ( #4211 )
...
* This field was ignored.
* move pad out
* gone
2022-05-30 07:03:40 -04:00
Matthew Kennedy
cf51533f45
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
Matthew Kennedy
6ea78efbe7
bail from trigger_central ( #4210 )
2022-05-29 10:42:08 -04:00
Matthew Kennedy
d85ed5f3c0
trigger decoder returns a result ( #4206 )
2022-05-28 09:01:45 -04:00
Matthew Kennedy
4a0c7cb8d5
honda trigger sync ratio ( #4194 )
2022-05-24 17:12:36 -04:00
rusefillc
7a52251375
Pavel says 120
2022-05-24 14:40:54 -04:00
Matthew Kennedy
65db5aacaa
Fix trigger error indicator ( #4185 )
...
* test and fix
* more shards!
2022-05-19 09:43:42 -04:00
Matthew Kennedy
eb257b2335
12 tooth crank mode ( #4179 )
...
* 12 tooth crank
* comment
* s
* rusefi config
2022-05-17 21:38:24 -04:00
Matthew Kennedy
76a15dd711
don't rely on triggerStateListener to detect trigger errors ( #4164 )
...
* Write proper TriggerDecoder tests
* Improve logic around sync loss
* these tests I understand
* these I sort of understand....
* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00
Matthew Kennedy
fa835950a0
remove 360 trigger ( #4165 )
...
* remove 360
* s
* simplify that mess
2022-05-11 06:15:06 -04:00
Matthew Kennedy
cf89b42716
move logic in to trigger decoder ( #4162 )
...
* move logic in to trigger decoder
* status loop
* minor cleanup
* s
2022-05-10 23:55:28 +03:00
Matthew Kennedy
b243d3fca0
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
Matthew Kennedy
05dd33ddb3
switch back to flag ( #4155 )
2022-05-10 07:52:29 +03:00
Matthew Kennedy
dede3f8215
phase resolution rpm limit ( #4156 )
2022-05-10 07:22:50 +03:00
Matthew Kennedy
55fdd3f3c7
encapsulate stuff properly ( #4154 )
2022-05-09 15:46:36 -04:00
rusefillc
e64c8cfccb
synchronized Phase handling improvements fix #4099
2022-05-09 04:36:03 -04:00
rusefillc
5454b8f509
m_hasSynchronizedSymmetrical handling improvements #4099
...
API progress
2022-05-09 04:04:38 -04:00
rusefillc
23c16280f6
helping build
2022-05-08 09:14:50 -04:00
rusefillc
35901087cd
Merge branch 'master' of https://github.com/rusefi/rusefi
2022-05-08 09:11:16 -04:00
GitHub build-firmware Action
5bbb401f85
Auto-generated configs and docs
2022-05-08 13:06:44 +00:00
rusefillc
394d1fe961
refactoring: bringing method names up to date
2022-05-08 09:04:27 -04:00
rusefillc
b2771f9b44
Remove value copy from controller into outputChannels #4095
2022-05-08 08:50:27 -04:00
GitHub build-firmware Action
a4b7845279
Auto-generated configs and docs
2022-05-08 12:05:34 +00:00
rusefillc
ad4591945e
Remove value copy from controller into outputChannels #4095
2022-05-08 07:58:19 -04:00
Matthew Kennedy
997565ac22
Trigger gm 3 vs 5 ( #4140 )
...
* add parameter
* two modes
* add new mode to list
* format
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
Matthew Kennedy
72e5604f9b
fix 36-2 trigger params ( #4138 )
...
* fix gap params
* changelog was wrong too
* typo
* binary log knock count and retard
* Revert "binary log knock count and retard"
This reverts commit 48b29d24d72331065a9f648ef5bfe845d03575d6.
2022-05-05 07:41:26 +03:00
rusefillc
fdeeaac1c8
Corolla 1ZZ 2003 trigger improvements fix #4132
2022-05-04 02:45:44 -04:00