b4bc5551db
tear down Engine god object #4511
2022-09-15 22:06:16 -04:00
918112d588
tear down Engine god object #4511
2022-09-15 22:00:07 -04:00
03d176ca61
tear down Engine god object #4511
2022-09-15 21:55:15 -04:00
1c28ca0582
tear down Engine god object #4511
2022-09-15 21:46:01 -04:00
f5a5764429
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
1d0f13fc41
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
579f3df7ad
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
1ca5988877
time routines refactor ( #4563 )
...
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
921b97431f
refactoring: type safety
2022-09-11 03:46:50 -04:00
cb3c070928
refactoring: type safety
2022-09-11 02:57:35 -04:00
f9b849dd8f
refactoring - reducing API between FW and Java
2022-09-11 02:16:47 -04:00
3c647c6442
huh? dead code? how can we get NAN from eventAngles table? ( #4549 )
2022-09-07 23:45:33 -04:00
3c1cc0b857
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
8253156233
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 21:45:59 -04:00
25b6d39802
os_access.h dead?
2022-09-07 15:56:45 -04:00
670c2e4afe
reset instant RPM in case of cam resync ( #4544 )
2022-09-06 21:38:35 -04:00
fba0906942
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
715b799b6c
separate atomic picked from https://github.com/rusefi/rusefi/pull/4493 ( #4495 )
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:26:56 -04:00
4e6d129f27
poke 3
2022-08-23 09:02:38 -04:00
016cd3bc7c
poke 2
2022-08-22 23:43:06 -04:00
341b43e7e3
poke 1
2022-08-22 23:42:48 -04:00
637dc37e95
RE: reasons for verbose messages
2022-08-22 22:52:48 -04:00
ea7597e0d6
trigger gap logging: it's a mess :(
2022-08-21 12:38:29 -04:00
f11480597d
todo: huh? dead code? how can we get NAN from eventAngles table?
2022-08-11 20:05:29 -04:00
d97bcec161
refactoring: better field name
2022-08-09 20:32:39 -04:00
d5f1235a43
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
214d38f286
verbose trigger sync should reuse engineSnifferRpmThreshold fix #4259
2022-06-18 15:18:45 -04:00
9d942a1c4a
more info verbose trigger/vvt
2022-06-17 22:11:09 -04:00
27c98f70fe
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit e64c8cfccb5454b8f509
2022-06-09 17:21:22 -04:00
c2f61dc95f
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
56e7acd869
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
54c339c0a4
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
5f1801f9d6
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
cf51533f45
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
d85ed5f3c0
trigger decoder returns a result ( #4206 )
2022-05-28 09:01:45 -04:00
76a15dd711
don't rely on triggerStateListener to detect trigger errors ( #4164 )
...
* Write proper TriggerDecoder tests
* Improve logic around sync loss
* these tests I understand
* these I sort of understand....
* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00
cf89b42716
move logic in to trigger decoder ( #4162 )
...
* move logic in to trigger decoder
* status loop
* minor cleanup
* s
2022-05-10 23:55:28 +03:00
b243d3fca0
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
05dd33ddb3
switch back to flag ( #4155 )
2022-05-10 07:52:29 +03:00
55fdd3f3c7
encapsulate stuff properly ( #4154 )
2022-05-09 15:46:36 -04:00
e64c8cfccb
synchronized Phase handling improvements fix #4099
2022-05-09 04:36:03 -04:00
5454b8f509
m_hasSynchronizedSymmetrical handling improvements #4099
...
API progress
2022-05-09 04:04:38 -04:00
23c16280f6
helping build
2022-05-08 09:14:50 -04:00
394d1fe961
refactoring: bringing method names up to date
2022-05-08 09:04:27 -04:00
b2771f9b44
Remove value copy from controller into outputChannels #4095
2022-05-08 08:50:27 -04:00
5f9c9d1732
humans need humane warning messages
2022-04-18 11:35:19 -04:00
cb4979e068
very random progress
2022-04-16 17:07:57 -04:00
5cf2b1bba5
warning cleanup ( #4020 )
2022-03-22 16:53:24 -04:00
b555d9e82b
toothed previous time #4019
2022-03-21 20:41:09 -04:00
e0258c4c8e
migrating to SensorType::Rpm API
2022-01-20 23:36:09 -05:00
rusefillc
Andrey
Andrey G
rusefillc
Matthew Kennedy