8cb1f2545c
trigger refactoring & docs
2021-11-14 15:35:11 -05:00
93d31c6c9b
Convert TriggerWaveform::wave to a pointer in preparation for code-defined sequences. ( #3528 )
...
It will eventually be class to support dynamic universal patterns in addition to ROM-based
tables.
2021-11-11 13:19:25 -05:00
1a299a3221
Move phaseCount into MultiChannelStateSequence ( #3520 )
...
We can them drop the field from a bunch of callers, simplifying the code.
2021-11-10 19:47:27 -05:00
38ea0d1835
Revert "Don't keep a separate MultiChannelStateSequence for the trigger emulator. ( #3513 )"
...
This reverts commit 4e220dc163
2021-11-09 20:42:23 -05:00
4e220dc163
Don't keep a separate MultiChannelStateSequence for the trigger emulator. ( #3513 )
...
All it wants is to use the main trigger state, so don't bother copying it. Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt. Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes. And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)
Also remove SimplePwm's 2nd copy of SingleChannelStateSequence. It served no purpose.
Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-09 14:35:07 -05:00
9b40e68155
Save ~2800 bytes of RAM by not caching angle->trigger mapping ( #3506 )
...
Memory seems more valuable than CPU; use the O(lg n) lookup by angle. A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
94faa375e1
reducing complexity
2021-11-07 01:57:32 -05:00
d0a8bbc974
typo
2021-11-07 01:51:05 -05:00
4f6dc57d31
refactoring - magic constant bad
...
cypress and kinetis both have this macro already
2021-11-07 01:34:16 -04:00
73fe152db2
refactoring - magic constant bad
...
cypress and kinetis both have this macro already
2021-11-07 01:28:28 -04:00
fd28e82f73
refactoring - magic constant bad
2021-11-07 00:03:16 -04:00
1685ec95cf
Honda K cam wheels #3405
2021-10-28 19:26:59 -04:00
94b5b3a089
Honda K cam wheels #3405
2021-10-28 11:40:31 -04:00
98c4e71f03
enable address sanitizer ( #3217 )
...
* enable asan
* lua
* this is dead and leaky
* leaky nissan
* fix pwm generator use-after-stack
* initializers
* prevent problems in case of invalid trigger shape
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-05 05:56:59 -04:00
c9360448cc
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 17:47:32 -04:00
d76132c206
refactoring
2021-07-17 00:46:39 -04:00
206bf7adc8
reducing warnings
2021-07-13 14:50:10 -04:00
4627707e1c
refactoring - explicit read method
2021-06-26 22:17:07 -04:00
1003056f85
refactoring - explicit read method
2021-06-26 22:07:45 -04:00
62ecef3e3f
Override trigger gaps feature #2734
2021-05-23 19:51:00 -04:00
b6fc9befc8
finish it off: remove scheduleMsg ( #2575 )
...
* finish it off
* one more logger ptr
* fwd decl
* Revert "one more logger ptr"
This reverts commit a21fb0087ddc748978d716db2710800cf26e437b.
* unused
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 15:33:40 -04:00
5f0791f9fb
Destroy all shared logger ( #2574 )
...
* most of shared logger
* a few more
* one more
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
782ae69cc3
GM/Daewoo 60/2/2/2 Trigger Pattern #2264
2021-02-01 23:44:14 -05:00
0cc7cb8eb4
Revert "Save more space in the angle cache ( #2228 )"
...
This reverts commit 1800219e
2021-01-18 18:53:00 -05:00
1800219e44
Save more space in the angle cache ( #2228 )
...
* store event angles in a scaled field
* tests
* comment
2021-01-18 18:31:06 -05:00
a294dfeadd
save 1440 bytes ( #2226 )
2021-01-16 21:22:30 -05:00
b047ec4f12
clean up some includes ( #2227 )
...
* cleanup
* make c happy
2021-01-16 09:45:45 -05:00
4072db3052
trigger lifecycle
2020-12-09 12:19:25 -05:00
9871d5b501
refactoring: magic constants
2020-12-04 16:24:19 -05:00
5ae3347927
6.1 Hemi V8 decoder #2010
2020-12-04 16:03:27 -05:00
2b2ffe9d7d
6.1 Hemi V8 decoder #2010
2020-12-04 15:33:07 -05:00
45e47220ab
6.1 Hemi V8 decoder #2010
2020-12-04 15:22:53 -05:00
7327fd6e6c
all triggers should be documented way nicer #2001
2020-12-02 22:17:38 -05:00
060cfbd778
const ref-ify trigger ( #1856 )
...
* const ref-ify
* tests
2020-10-05 14:22:59 -04:00
9808e675f5
Trigger performance: variable gapTrackingLength #1851
...
cool change but looks to have made zero difference
2020-10-04 13:05:49 -04:00
0992f90f18
VVT support for VAG trigger #883
2020-08-26 20:57:11 -04:00
470a9f5a5a
VVT support for VAG trigger #883
2020-08-25 12:45:18 -04:00
7d53f5859d
VVT support for VAG trigger #883
2020-08-25 00:59:07 -04:00
978c3ff16d
VVT support for VAG trigger #883
...
a bit of dead code?
2020-08-24 02:31:27 -04:00
c1a4bd857b
TT_HONDA_K_12_1
2020-04-19 14:23:01 -04:00
4967e8ba7b
better trigger definition API
2020-04-18 20:28:03 -04:00
eb46d7bd58
warnings ( #1169 )
2020-03-03 08:37:02 -05:00
6c70f390da
trigger shape constraint validation
2020-01-14 03:54:46 -05:00
abe1b8c1f3
refactoring: no need to specify parameter manually
2020-01-12 10:43:02 -05:00
63e3e84e08
happy new year
2020-01-08 00:02:40 -05:00
bcec694eb1
just a trivial massive rename: TriggerState > TriggerWaveform
2019-12-08 01:09:39 -05:00
889ee45c16
typo
2019-12-06 00:07:27 -05:00
561986d3e4
The Big Refactoring of 2019: folder structure #723
2019-12-04 01:11:10 -05:00
c5e60a7f93
improving API?
2019-11-24 00:15:44 -05:00
79ada84b56
'triggerEventAngle' not really needed
2019-11-23 17:44:44 -05:00
rusefillc
Scott Smith
Andrey
Matthew Kennedy