98040ad9af
Make the module API more concise. ( #3571 )
...
engineModules.get<FOO>(). becomes modules<FOO>()->
I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
2021-11-17 21:50:00 -05:00
69d36dad6e
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
988aacdd91
Create a base class EngineModule for that contains various useful callbacks. ( #3548 )
...
* Create a base class EngineModule for that contains various useful callbacks.
This cleans up the API by not requiring the notifiers to know about who wants callbacks. The only
place you need to update to add a module is in one place.
* Add mockability.
* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
70ad9724c0
Make engine* and friends be const pointers in production. ( #3564 )
...
This allows the compiler to see through the pointer and make accesses faster.
It saves 1336 bytes of text.
2021-11-17 03:53:17 -05:00
cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
17d4646dce
spelling
2021-11-16 16:46:54 -05:00
dad00adc28
helping launch enter simulator
2021-11-16 16:45:14 -05:00
678a756275
helping launch enter simulator
2021-11-16 16:31:35 -05:00
a61043e570
proportional spark cut #3427
2021-11-16 13:23:08 -05:00
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
344c9073e2
Start the process of using a global engine ptr for unit tests. ( #3551 )
...
* Start the process of using a global engine ptr for unit tests.
Passing around the engine, config, and persistent state wasn't buying anything. Instead, use
EngineTestHelper(Base) to correctly set and clear the global variables. Add a dummy check in
case some test tries to set them manually.
* Fix OSX build
* Adapt PR to recently added code.
2021-11-16 00:23:14 -05:00
0cc88ec6e2
Not all launch control options are used #3554
2021-11-15 21:13:01 -05:00
3b0825181c
technical debt: enableOverdwellProtection #3553
...
only documentation
2021-11-15 20:32:25 -05:00
655b77dc3f
random refactoring: trigger central encapsulation
2021-11-15 20:22:05 -05:00
928c673695
refactoring launch
2021-11-15 20:09:03 -05:00
05fa6071dd
refactoring launch
2021-11-15 19:55:04 -05:00
0d5df34f36
refactoring launch
2021-11-15 19:55:04 -05:00
c18204325c
refactoring launch
2021-11-15 19:34:42 -05:00
f510cb8b29
refactoring launch
2021-11-15 19:24:00 -05:00
4002c92dcc
refactoring launch
2021-11-15 18:57:12 -05:00
34015eceee
refactoring launch
2021-11-15 14:40:35 -05:00
145316c497
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
adbb32e9b6
Auto-generated configs and docs
2021-11-15 03:03:29 +00:00
6f3eea31c6
MAP phase sensing #3544
2021-11-14 21:58:01 -05:00
e8aebc313a
Something something Automatic Compression Release #3442
2021-11-14 15:04:10 -05:00
89ab20c35c
Epic: Remove FSIO #2928
2021-11-14 14:14:43 -05:00
68ebb8045d
Epic: Remove FSIO #2928
2021-11-14 11:04:51 -05:00
22c872d8d8
Epic: Remove FSIO #2928
2021-11-14 10:57:19 -05:00
c22215cea7
Epic: Remove FSIO #2928
2021-11-14 10:39:47 -05:00
991d0c5001
Epic: Remove FSIO #2928
2021-11-14 08:33:19 -05:00
0a9682c553
Epic: Remove FSIO #2928
2021-11-14 07:24:50 -05:00
a9bcce88d0
script settings need names!
2021-11-13 22:47:46 -05:00
b295511600
Auto-generated configs and docs
2021-11-14 03:02:10 +00:00
d591a5ad26
mercedes two lobe trigger testing ( #3543 )
...
* mercedes
* config
* break;
* I did the gap ratio math wrong
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 21:50:04 -05:00
8333234737
Something something Automatic Compression Release #3442
2021-11-13 04:24:53 -05:00
dffab7abff
Auto-generated configs and docs
2021-11-13 03:01:55 +00:00
6d58518fb2
Proteus Harley
2021-11-12 21:56:07 -05:00
2765d386b9
Auto-generated configs and docs
2021-11-12 01:54:56 +00:00
562ab174d7
Bench Test IAC Valve fails #3534
...
that's not even funny
2021-11-11 20:39:01 -05:00
8d154b94df
Bench Test IAC Valve fails #3534
2021-11-11 20:31:46 -05:00
df98eb69d4
Bench Test IAC Valve fails #3534
2021-11-11 20:28:01 -05:00
cd57e1fdb6
Something something Automatic Compression Release #3442
2021-11-11 20:16:46 -05:00
aff7664c21
refactoring: less hacky implementation
2021-11-11 20:16:46 -05:00
2794a85ff8
Idle valve outputs not available in TS #3523
2021-11-10 20:40:42 -05:00
8aaecb568e
pid demo progress
2021-11-08 17:31:33 -05:00
9d2f9f0d35
docs
2021-11-08 12:23:00 -05:00
656b8c3429
refactoring - magic constant bad
2021-11-07 00:03:16 -04:00
ed44ee9b11
Auto-generated configs and docs
2021-11-07 03:59:47 +00:00
ce45a907a7
a bit of dead code
2021-11-06 23:39:56 -04:00
Scott Smith
rusefillc
Andrey
Matthew Kennedy
GitHub build-firmware Action