d13a851c97
triggerImage: todo: support symmetrical crank
2022-10-16 10:33:38 -04:00
5fb9f7c2df
triggerImage: todo: support symmetrical crank
2022-10-16 02:59:57 -04:00
d91211106c
triggerImage: todo: support symmetrical crank
2022-10-16 02:44:57 -04:00
aa881efe89
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
d6647025cc
2jz test ( #4638 )
2022-10-05 20:48:28 -04:00
940e0dc369
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
ec5d48fb5b
remove 898 ( #4634 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-10-04 20:12:57 -04:00
cb86c014cf
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
ca623eb6ee
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
b089825a4a
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
ae6c44634b
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
b45f84fe20
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
612d52645a
Honda K cam wheels #3405
2022-09-25 00:26:42 -04:00
9d27780974
Honda K cam wheels #3405
2022-09-24 23:49:41 -04:00
111220d38c
more inclusive configuration name
2022-09-24 23:49:41 -04:00
cff779dd78
K progress
2022-09-24 23:18:57 -04:00
a38d87b0e0
fancy default and reusing constant
2022-09-24 23:01:42 -04:00
93e64a61a6
fancy
2022-09-24 22:54:58 -04:00
33be12541b
K
2022-09-24 15:37:51 -04:00
0eef498b3e
refactoring: extract constant
2022-09-24 15:33:01 -04:00
c4699efe91
honda K enum rename
2022-09-23 20:13:14 -04:00
2f18168d47
K20
2022-09-23 20:13:14 -04:00
ed72758a5d
K20
2022-09-23 18:25:24 -04:00
6cdb0dc0af
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
6b0941b8ed
inline method to reduce confusion
2022-09-14 01:24:19 -04:00
2a05a31550
refactoring: type safety
2022-09-11 03:46:50 -04:00
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
72299bd1ba
only report vvt position if we have full sync ( #4547 )
...
* only report vvt position if we have full sync
* comments
* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
8e49542600
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
4934d76d88
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:24:17 -04:00
268a5c7964
tear down Engine god object #4511
...
just trying different things
2022-09-05 02:44:06 -04:00
c1b218b772
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
feb386a54b
refactoring: moving field
2022-09-05 01:15:45 -04:00
9407150544
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
7e340cceb3
refactoring: reducing outputChannels copy
2022-09-01 10:58:16 -04:00
da66fa055c
refactoring: enum name clean-up
2022-09-01 00:23:33 -04:00
fef406a5a6
english do you speak it
2022-08-31 22:56:38 -04:00
5007084981
VQ trigger gaps improvement fix #4469
...
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
25778f0890
trigger gap logging: it's a mess :(
2022-08-21 12:38:29 -04:00
0f320448ff
refactoring: default argument value
2022-08-21 12:17:50 -04:00
eebc810295
enable alwaysInstantRpm in some tests ( #4461 )
...
* test some with alwaysInstantRpm set
* more
2022-08-19 15:03:20 -04:00
423f69a842
allow logging multiple warnings at once ( #4414 )
...
* allow logging multiple warnings at once
* comment
* .Code
* Revert ".Code"
This reverts commit 2b986bd50035aeec051d11aafd83fdbc1694351c.
* add a better comparison operator instead of conversion
* dot code
* Revert "dot code"
This reverts commit 35f6ae1007c41e3b30ea129a324f33ab4205036d.
* force gcc-10 maybe?
* Revert "force gcc-10 maybe?"
This reverts commit 4ddf8bcefddd354ccdc1da682c5fff1e68d44273.
* vq
* dot code
* dead
* dot code
* return may be null
* static_vector; maybe cyclic_buffer is broken or wrong tool for the job?
* move static vector
* put cyclic buffer back how it was since we don't use it now
2022-08-17 01:12:25 -04:00
76f5832db9
resolve VVT phase using every tooth, not just sync point ( #4434 )
...
* resolve VVT phase using every tooth, not just sync point
* fix tests
* comment
* changelog
2022-08-12 08:08:23 -04:00
b5c2b70e23
refactoring: better field name
2022-08-09 20:32:39 -04:00
7887b9d1e1
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:39:19 -04:00
b628c81d26
Make hard-coded gap ratios visible on trigger documentation images #4172
2022-07-12 00:11:25 -04:00
1b28e292e2
logging of live data structs was: data points #3614
...
huh?
2022-06-29 02:42:03 -04:00
c0f290b922
Injector scheduled by angle, not tooth index ( #4208 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
* injection doesn't care about teeth
* fix up existing tests
* oh look, we can actually test this logic now without trying to depend on trigger shape!!!
* fix a real bug
* simplify
2022-06-24 17:43:23 -04:00
fcd3d991ee
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
rusefillc
Matthew Kennedy
Andrey