Matthew Kennedy
63524c3f34
fan/AC idle improvements ( #2818 )
...
* fan 2 open loop bump
* we had an AC target bump all this time?!
* format
* enable test
* I can't type
2021-06-15 17:30:35 -04:00
Matthew Kennedy
0c0957f52a
apply open loop idle when in automatic mode ( #2745 )
...
* always apply open loop in closed loop
* simplify flags
* comment
* move
* comment
* missed one
* config for fan bump
* adjust miata defaults
* test fan/ac open loop
* idle CL tests
* test coasting
* test integration case
* fix merge
* put back reset logic for now
* s
* don't need that part
* I guess use OL as baseIdlePosition
* reset condition
2021-06-12 14:21:11 -04:00
Matthew Kennedy
70c0db189d
warnings & assorted cleanup ( #2793 )
...
* lua hook
* validateBuffer
* tables
* simplify fsio table
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-03 14:30:25 -04:00
Matthew Kennedy
f21fa3e652
idle fan/AC open loop bump ( #2785 )
...
* idle open loop ui section
* idle bump logic
* test fan/ac bump
2021-06-01 00:45:04 +03:00
Matthew Kennedy
1f3cbd67ad
iac coast table ( #2784 )
2021-06-01 00:43:58 +03:00
Matthew Kennedy
6fbdb3c2d0
make the implementation match what the UI claims ( #2779 )
2021-05-31 07:37:02 -04:00
Matthew Kennedy
1b607faeba
Idle test that fails ( #2781 )
...
* make member func
* failing test
2021-05-31 06:18:15 -04:00
Matthew Kennedy
6118a6adc6
code style ( #2780 )
2021-05-31 06:01:57 -04:00
Matthew Kennedy
ad505bfb1b
idle indicators ( #2692 )
...
* add coasting bit
* remove useless bit
2021-05-13 17:35:00 -04:00
Matthew Kennedy
8cfb63455d
Logging remove 3 ( #2568 )
...
* ts logger
* sensors
* wideband too
* missed one
* init
* motors, pid, etc
* vvt
* more
* idle
* missed one
* dynoview
* launch
* can
* console IO
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-20 14:09:41 -04:00
Matthew Kennedy
992c16b4af
logging cleanup 2: sensors, pid, etb, etc ( #2567 )
...
* ts logger
* sensors
* wideband too
* missed one
* init
* motors, pid, etc
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 20:02:32 -04:00
Matthew Kennedy
dbebc353a2
remove unused msg parameter ( #2360 )
...
* dead parameter
* last few
2021-02-16 09:32:16 -05:00
Matthew Kennedy
7fec313f50
Proteus analog input ci ( #2271 )
...
* test vbatt
* test proteus vbatt
* tolerance
* these don't work on proteus
* new engine type
* test analog input
* more test points, less tolerance
* console build needs this file generated
* only include for hw ci builds
* wiring info
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-03 13:34:48 -06:00
Matthew Kennedy
5bfee13c21
fix instant rpm ( #2180 )
...
* consumers
* impl
* instant rpm in idle timing
2021-01-14 20:45:55 -05:00
Matthew Kennedy
d4965d16f3
Enable idle timing/ve tables based on idle phase logic ( #2213 )
...
* add helper
* advance
* ve
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-11 00:54:37 -05:00
Andrey G
b61ae75fe2
gpio helper ( #2195 )
...
* gpios: isBrainPinValid helper
* LCD HD44780: do not touch pins if DM_NONE or invalid gpio
* Fix isEnabled checks for GPS and Joystick
* LCD HD44780: writePad use this method wider
2021-01-08 20:01:26 -05:00
Matthew Kennedy
86d3746453
Idle timing uses phase logic, remove falloff ( #2169 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
* wonderful changelog
* now unused parameter
* put back deadzone
* ui
* test deadzone
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-07 08:06:36 -05:00
rusefillc
7c38714129
Revert "Idle timing PID uses phase logic ( #2156 )"
...
This reverts commit f1ee8b43
2020-12-31 12:22:54 -05:00
Matthew Kennedy
8492f99b91
show when idle is closed loop ( #2160 )
...
* show when idle is closed loop
* semicolon
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-30 08:42:40 -05:00
Matthew Kennedy
f1ee8b431e
Idle timing PID uses phase logic ( #2156 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-29 23:50:56 -05:00
Matthew Kennedy
587536ee4a
use phase computation ( #2152 )
2020-12-29 07:49:10 -05:00
Matthew Kennedy
a76d399bf6
add idle timing defaults ( #2155 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-29 07:47:18 -05:00
Matthew Kennedy
5e7dc71365
move swtiches out of idle ( #2148 )
2020-12-26 21:31:41 -05:00
Matthew Kennedy
d20a54b463
start integratig ( #2147 )
2020-12-26 19:44:40 -05:00
Matthew Kennedy
560061e251
Idle refactor open loop ( #2146 )
...
* impl
* typo
* tests
2020-12-26 19:34:42 -05:00
Matthew Kennedy
93cc1e84c3
more testable idle logic ( #2140 )
...
* header
* test
* impl
2020-12-26 08:32:01 -05:00
Matthew Kennedy
d3cbed60af
move target computation ( #2091 )
2020-12-17 17:46:51 -05:00
rusefillc
2af3cdf70e
Starter seems to be engaged forever #1965
2020-11-18 20:01:02 -05:00
rusefillc
c30d0d31f3
Starter seems to be engaged forever #1965
2020-11-18 19:51:51 -05:00
rusefillc
851478f846
DC not ETB refactoring
2020-11-16 20:05:35 -05:00
Matthew Kennedy
605269c358
remove idle thread; just call from periodicSlowCallback ( #1924 )
...
* remove thread
* remove ui
2020-11-11 21:47:19 -05:00
Matthew Kennedy
e8bb0cfd00
extract idle hardware to its own file ( #1923 )
...
* extract idle hardware
* should fix the build
2020-11-03 18:06:32 -05:00
rusefi
66b61f76a7
Output pin init/deinit needs a linked list #1803
2020-11-03 00:09:42 -05:00
Matthew Kennedy
b79c0fefe5
replace ETB index with function enum ( #1807 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
2020-09-28 16:33:07 -04:00
rusefi
d63d0e185f
merge got confused
2020-09-07 15:05:47 -04:00
rusefi
5243811711
Merge remote-tracking branch 'origin/Hellen_fork_point' into master
...
# Conflicts:
# firmware/controllers/algo/engine.h
# firmware/hw_layer/drivers/drivers.mk
# firmware/hw_layer/stepper.h
# firmware/integration/rusefi_config.txt
# firmware/tunerstudio/rusefi.input
# simulator/simulator/efifeatures.h
2020-09-07 15:02:11 -04:00
rusefi
16580f0afd
Hellen says isIdleMotorBusy
...
(cherry picked from commit 7601952548
)
2020-09-07 14:43:29 -04:00
rusefi
7601952548
Hellen says isIdleMotorBusy
2020-09-07 14:12:21 -04:00
Matthew Kennedy
fc02c2bdf4
fix broken master, inject engine ptr to rpmcalculator ( #1759 )
...
* fix
* oops
2020-09-05 18:49:42 -04:00
rusefi
c476cd3b95
refactoring
2020-09-03 19:29:15 -04:00
rusefi
7d53f5859d
VVT support for VAG trigger #883
2020-08-25 00:59:07 -04:00
rusefi
39ba9a9f19
Weird VAG: DC motor idle valve not ETB #1637
...
misc progress
2020-07-26 15:22:14 -04:00
rusefi
bd1c43ab8f
Weird VAG: DC motor idle valve not ETB #1637
...
should be better this way
2020-07-26 12:19:30 -04:00
rusefi
07df0c78a8
Weird VAG: DC motor idle valve not ETB
...
#1637
Seattle we might have a problem!
2020-07-26 12:03:36 -04:00
Andrei
57f6ad1fdb
Idle PID improvements
2020-07-22 18:39:09 +03:00
rusefi
93d015598a
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 21:35:01 -04:00
rusefi
ffb559d9b3
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 21:13:04 -04:00
rusefi
d70b4a5cb1
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 19:06:26 -04:00
rusefi
93f85b0b93
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 18:25:48 -04:00
rusefi
eff12bbeb1
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 18:11:10 -04:00
rusefi
e18a03766b
https://rusefi.com/forum/viewtopic.php?p=37401#p37401
2020-07-10 15:06:55 -04:00
rusefi
a1b9d58361
https://rusefi.com/forum/viewtopic.php?p=37401#p37401
2020-07-10 14:19:51 -04:00
rusefi
f2eadae4ea
https://rusefi.com/forum/viewtopic.php?p=37401#p37401
2020-07-10 14:03:07 -04:00
rusefi
8bcd46291f
migrate amazing idle from FSIO to less opaque TS #1581
2020-07-08 01:12:08 -04:00
rusefi
4e24b3ece1
idle_min through FSIO not working as intended
...
#1553
we now re-activated idle PID even in deadzone for half a second after A/C toggle
2020-07-06 16:40:16 -04:00
Matthew Kennedy
1bdc5fbaaa
Switch fueling to new axes ( #1574 )
...
* switch tables
* missed one
2020-07-05 18:14:55 -04:00
rusefi
bd39351055
idle_min through FSIO not working as intended #1553
2020-07-04 22:01:12 -04:00
rusefi
c6d0a015cc
idle_min through FSIO not working as intended #1553
...
better idle state logging
2020-07-01 19:10:42 -04:00
rusefi
14fc5a54df
idle_min through FSIO not working as intended #1553
...
making logging less confusing
2020-07-01 16:37:25 -04:00
rusefi
9d2cbd682b
helping build
2020-05-08 21:39:35 -04:00
dron0gus
35af083a6e
idle thread: debug output for bipolar stepper ( #1409 )
2020-05-08 20:05:05 -04:00
dron0gus
7007627b70
[SAFE] Debug cleanups ( #1403 )
...
* electronic throttle: inprove debug
* idle thread: show debug info for configured idle driver
* gpio-chips: make private functions static
2020-05-06 20:06:50 -04:00
Matthew Kennedy
5ac535c5e5
Support 4 h-bridges ( #1392 )
...
* update dc motor api
* add more etbio
* get out of two arrays
* hand generate enough
* forgot engine param
* ram
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-02 17:54:28 -04:00
rusefi
0ec3ce595e
dead code
2020-04-26 17:40:12 -04:00
Matthew Kennedy
ce08650f65
Inject idle to ETB ( #1335 )
...
* inject idle position
* pointer
* etb idle tests
* extract mocks
* ops
* test negative case too
* don't convert for etb
* guard
2020-04-20 16:26:35 -04:00
rusefi
1bcbed3cb5
reducing code duplication
2020-04-20 15:57:03 -04:00
rusefi
ceb8b6d9b4
idle duty cycle clamping
2020-04-20 14:11:40 -04:00
rusefi
385f4b12e8
Better handling in case of ETB idle without ETB #1332
2020-04-19 23:55:27 -04:00
Matthew Kennedy
83592f0dff
New clt consumers part 1 ( #1301 )
...
* idle
* CLT test prep
* idle target
* header
* air interpolate
* ancient comment
* fuel cut
* fuel cut, idle tests
* cleanup
2020-04-15 09:48:17 -04:00
dron0gus
281e8ac754
idle: add two coil idle valve support ( #1271 )
2020-04-06 17:55:41 -04:00
Matthew Kennedy
9a21262cf8
TPS consumers: idle and ignition and obd2 and lcd ( #1254 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-03 19:59:08 -04:00
Matthew Kennedy
8235d8d765
Fully switch acc pedal to new sensors ( #1212 )
...
* proxy sensor
* header
* idle
* can
* settings
* remove old mocking
* remove old impl
* etb
* oops, gotta actually register it
* fix test
* structured bindings ftw!
* driver intent for stepper
* tear out old
* oops too much
2020-04-01 20:21:03 -04:00
Matthew Kennedy
0ac3e06149
cleanup extern mess ( #1237 )
...
* cleanup
* move outside define
2020-03-29 19:06:03 -04:00
Matthew Kennedy
adac5fba78
Control stepper with dual H-bridges ( #1121 )
...
* divorce stepper from hw
* oops
* ptr not ref
* hbridge stepper
* typo
* hook up twin h
* hook up hardware
* use config field
* hook up motor repo
* guard tests
* whoops
* ok fix for real
* ok that's the right thing
* do full stepping
Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.stagpad.local>
Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
2020-03-10 15:18:29 -04:00
rusefi
b47462b4de
Three wire idle air valve #1122
...
ugly but should work to begin with
2020-02-04 01:22:04 -05:00
Matthew Kennedy
94e30b0b38
Separate stepper control logic from hardware ( #1101 )
...
* divorce stepper from hw
* oops
* ptr not ref
* ptr not ref
* whitespace
* null check
2020-01-15 02:18:15 -05:00
rusefi
a222ecdfe1
happy new year unification
2020-01-13 21:57:43 -05:00
rusefi
f47a1a16d1
getting rid of boardConfiguration / binary compatible change
2019-12-11 17:48:55 -05:00
rusefi
561986d3e4
The Big Refactoring of 2019: folder structure #723
2019-12-04 01:11:10 -05:00
andreika-git
ae9c619c50
iacPidMultTbl + EFI_IDLE_PID_CIC + kinetis_hysteresis ( #1043 )
...
* rename EFI_IDLE_INCREMENTAL_PID_CIC -> EFI_IDLE_PID_CIC
* Impl. IacPidMultTable
* Kinetis: Trigger Comparator Hysteresis settings (+adaptive mode)
2019-12-04 00:37:32 -05:00
rusefi
07b7b62bca
refactoring
2019-12-02 23:08:18 -05:00
rusefi
2738fefa48
that's how we can move all fields one by one from boardConfiguration to engineConfiguration
...
my approach is to move fields from the bottom of BC struct
2019-11-30 10:24:37 -05:00
andreika-git
7220735530
Starter relay + Hardcoded 'FSIO' + simulator fix ( #1032 )
...
* Starter Relay: gui + built-in FSIO impl.
* Hardcoded 'FSIO' replacement for RAM-limited boards
* fix simulator
2019-11-25 20:08:01 -05:00
rusefi
9c3492043d
progress towards #961
2019-11-04 22:44:52 -05:00
rusefi
db24091933
60/2 VW trigger has running issue on 19/10/19 snapshot fix #986
2019-10-30 20:51:20 -04:00
rusefi
1602bdbebc
steps towards #975
2019-10-18 19:45:32 -04:00
rusefi
eff84bcfeb
steps towards #975
2019-10-18 18:54:32 -04:00
rusefi
abfdfe6896
preparation for #961
...
more unified access to pre-calculated value
2019-10-10 08:25:58 -04:00
rusefi
2c8a2b61a5
preparation for #961
...
more unified access to pre-calculated value
2019-10-10 08:16:21 -04:00
Matthew Kennedy
821ca6156f
move tsOutputChannels to header ( #970 )
2019-10-08 21:02:51 -04:00
rusefi
b6d22a007b
docs
2019-09-29 15:14:08 -04:00
rusefi
ba1d8eb512
idle&ETB progress
2019-09-26 00:02:47 -04:00
rusefi
7710df4fed
ETB target is using integer values #945
...
refactoring
2019-09-22 08:44:51 -04:00
rusEfi
53ae54e8cc
ETB target is using integer values #945
...
first we will write a unit test
2019-09-22 00:16:46 -04:00
rusefi
757f8eb690
NB2 miata on Frankenso with ETB
2019-09-21 01:21:53 -04:00
rusefi
13b74d3d4d
unit tests progress
2019-09-20 00:46:35 -04:00
rusefi
d83ed085e8
unit tests progress
2019-09-19 22:56:54 -04:00
rusefi
0c9a8b58ca
unit tests progress
2019-09-19 22:10:39 -04:00
rusefi
fcbc26bf82
FSIO progress
2019-09-13 21:07:34 -04:00
rusefi
f0427360bf
Delayed A/C compressor switch #922
2019-09-11 20:46:50 -04:00