rusefillc
f919845c9c
tear down Engine god object #4511
...
oh I hope this ends well
2022-09-15 23:41:06 -04:00
rusefillc
c77ac3c42e
tear down Engine god object #4511
2022-09-15 22:21:07 -04:00
rusefillc
1c28ca0582
tear down Engine god object #4511
2022-09-15 21:46:01 -04:00
rusefillc
ac03dc55d8
CUSTOM_INSTANT_MAP_DECODING
2022-09-15 15:07:31 -04:00
rusefillc
672f0b8acc
mapFast into logs
2022-09-15 14:55:49 -04:00
Andrey
f5a5764429
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey
1d0f13fc41
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey
579f3df7ad
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey
b439f27284
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
Andrey
d256fd2b01
removing dead parameter
2022-09-14 01:13:57 -04:00
Andrey
867cc73950
moving IO-only away from scheduling logic
2022-09-14 00:55:55 -04:00
Andrey
556427b01d
moving IO-only away from scheduling logic
2022-09-14 00:52:24 -04:00
rusefillc
f97c5ed8fd
i suspect that no one cares about these
2022-09-14 00:34:04 -04:00
Andrey G
2b4012b279
dead code, reduce typedefs ( #4566 )
...
* Do lightweight checks first
* Dead getTimeIgnitionSeconds()
Dead since 5274cffff3
* Get rid of efitime_t.
Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.
* Fix unit tests
* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
rusefillc
efcd8ea084
refactoring - reducing API between FW and Java
2022-09-11 01:59:44 -04:00
rusefillc
4836c78644
send more of Engine Sniffer data #4560
...
hello Kinetis it has been a while!
2022-09-11 00:18:08 -04:00
rusefillc
ce32d0e3d8
send more of Engine Sniffer data #4560
2022-09-10 20:25:29 -04:00
Andrey
5dc26a7717
refactoring: brining stuff closer
2022-09-08 00:19:24 -04:00
Andrey
dea9090fd0
refactoring: better place for cam validation
2022-09-07 23:31:44 -04:00
Andrey
1f38979367
refactoring: parameter rename
2022-09-07 23:24:24 -04:00
Andrey
b95eeecb9b
brutal encapsulation
2022-09-07 21:29:11 -04:00
Andrey
91179ac54b
brutal encapsulation
2022-09-07 20:31:04 -04:00
Andrey
f8d275f64b
tear down Engine god object #4511
...
just trying different things
2022-09-07 20:25:49 -04:00
Andrey
e734bd7b07
brutal encapsulation
2022-09-07 20:20:29 -04:00
Andrey
a7c8ce61f4
brutal encapsulation
2022-09-07 19:37:11 -04:00
Andrey
4f3c0b3c60
extracting prime_injection
2022-09-07 16:27:56 -04:00
Andrey
8f14c44097
extracting prime_injection
2022-09-07 16:25:50 -04:00
Andrey
25b6d39802
os_access.h dead?
2022-09-07 15:56:45 -04:00
Andrey
7369126d91
tear down Engine god object #4511
...
just trying different things
2022-09-07 15:38:15 -04:00
rusefillc
8c10cf22c4
Engine Sniffer into TS data logs fix #4535 ( #4537 )
2022-09-05 19:49:27 -04:00
Andrey
fe8553ed9d
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:28:47 -04:00
Andrey
ab3d92b995
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:24:17 -04:00
Andrey
d4024f7f2d
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:10:14 -04:00
Andrey
b6eddaee59
tear down Engine god object #4511
...
just trying different things
2022-09-05 03:38:44 -04:00
Andrey
da7a4b6641
tear down Engine god object #4511
...
just trying different things
2022-09-05 02:59:38 -04:00
Andrey
76b74a85ba
tear down Engine god object #4511
...
just trying different things
2022-09-05 02:44:06 -04:00
Andrey
1983a07078
tear down Engine god object #4511
...
just trying different things
2022-09-05 02:28:46 -04:00
Andrey
6fbafd7818
Injection Offset for skipped wheel triggers fix #4536
2022-09-05 01:31:03 -04:00
Andrey
82fa9b191a
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
Andrey
841cd4f962
refactoring: moving field
2022-09-05 00:53:05 -04:00
Andrey
9a9b33401c
refactoring: splitting header where cpp was already split
2022-09-05 00:48:38 -04:00
Andrey
341447c82d
refactoring: moving method closer to usage
2022-09-05 00:32:36 -04:00
Matthew Kennedy
716b0c1f60
extract updateInjectionAngle ( #4512 )
2022-09-01 18:48:03 -04:00
Andrey
406a0226f0
a bit of dead code
2022-09-01 12:05:01 -04:00
Andrey
1ffa98ba89
a bit of dead code
2022-09-01 11:47:56 -04:00
Andrey
b64e553d5d
refactoring: reducing outputChannels copy
2022-09-01 01:06:49 -04:00
Andrey
2a949f6cd2
dead code
2022-09-01 00:23:33 -04:00
Andrey
ea22fcbe95
refactoring: enum name clean-up
2022-09-01 00:23:33 -04:00
Andrey
fcc1c72506
let spark deal with spark limpManager
2022-08-31 23:59:40 -04:00
Andrey
9d497846d3
moving confusion further away from fuel control
2022-08-31 23:59:40 -04:00
Andrey
0a9c1d7581
readability
2022-08-31 23:29:47 -04:00
Andrey
be790e2c44
less code is better
2022-08-31 23:14:20 -04:00
Andrey
19e2f28bec
unused parameter
2022-08-31 22:59:05 -04:00
Andrey
3eaaf5e293
english do you speak it
2022-08-31 22:56:38 -04:00
Andrey
e70e83d3fd
dead
2022-08-31 22:45:35 -04:00
Andrey
b756fbd605
dead console command and minor refactoring
2022-08-31 22:41:58 -04:00
GitHub gen-configs Action
e37d53e271
Auto-generated configs and docs
2022-08-30 06:02:26 +00:00
Matthew Kennedy
dcab243381
knock retard limit table ( #4498 )
...
* add max retard table
* ui
* s
* better naming
* s
* test can use base class
2022-08-30 01:57:37 -04:00
Andrey
4ec4d4caf7
docs
2022-08-25 19:58:15 -04:00
Andrey
5392f8d13e
https://github.com/rusefi/hellen154hyundai/issues/60
...
extra logging
2022-08-25 19:58:10 -04:00
rusefillc
42f02c67a3
require full sync for odd cylinder count #4478
2022-08-23 22:58:33 -04:00
rusefillc
87389f152e
https://github.com/rusefi/hellen154hyundai/issues/57
2022-08-09 13:26:11 -04:00
Matthew Kennedy
14b39b7b0a
unexpected contains information about why it failed ( #4393 )
...
* unexpected can contain information
* info printing
* sensors return appropriate error codes
* remove reliance on undefined behavior
* s
2022-07-28 10:04:28 +03:00
rusefillc
517418ba8d
todo: shall we move into high_pressure_fuel_pump.txt and reduce OOP elegance or create a separate live data just for these ones?
2022-07-04 17:08:41 -04:00
Andrey
ef2278aeb1
logging of live data structs was: data points #3614
2022-06-29 03:21:53 -04:00
rusefillc
c50009ee59
logging of live data structs was: data points #3614
2022-06-29 03:13:35 -04:00
Matthew Kennedy
88ff234c91
Injector scheduled by angle, not tooth index ( #4208 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
* injection doesn't care about teeth
* fix up existing tests
* oh look, we can actually test this logic now without trying to depend on trigger shape!!!
* fix a real bug
* simplify
2022-06-24 17:43:23 -04:00
rusefi
514531bc5c
verbose trigger sync should reuse engineSnifferRpmThreshold #4259
...
reducing complexity
2022-06-18 14:17:36 -04:00
Matthew Kennedy
d85ed5f3c0
trigger decoder returns a result ( #4206 )
2022-05-28 09:01:45 -04:00
Matthew Kennedy
eb257b2335
12 tooth crank mode ( #4179 )
...
* 12 tooth crank
* comment
* s
* rusefi config
2022-05-17 21:38:24 -04:00
rusefillc
76ce3b3e1c
An option to disable semi-random ignition fix #4151
2022-05-08 09:16:43 -04:00
Andrey
03662e48c4
Move curves out of engineConfiguration in order to reduce RAM usage #4127
2022-05-01 23:43:43 -04:00
rusefillc
ebf9e8ab47
knock reaction #202
...
LiveData
2022-04-29 15:23:22 -04:00
rusefillc
853ff9d6cd
knock reaction #202
...
steps towards new LiveData convention
2022-04-29 13:47:31 -04:00
rusefillc
64e0f342b1
knock reaction #202
2022-04-29 12:25:33 -04:00
GitHub build-firmware Action
bd1a36cc14
Auto-generated configs and docs
2022-04-29 16:04:30 +00:00
rusefillc
5f80ba1f65
knock reaction #202
2022-04-29 11:22:24 -04:00
Matthew Kennedy
2d033df11b
more missing autoscale ( #4112 )
...
* autoscale m_config->timeConstant
* min/max afr
* more
* dwell voltage
* closed loop fuel
* knock
* map estimate
* applyNonlinearBelowPulse
* fix
* add a test while we're at it for un-covered code
* test fallback MAP since we touched that
* always compute fallback MAP even if sensor is OK
2022-04-28 08:16:02 -04:00
Matthew Kennedy
a2e1a079b8
allow enum_class in rusefi_hw_enums.h ( #4104 )
...
* make things c++ friendly
* install various canaries in coal mines
* using is much clearer than typedef
* fixing builds
* lps25
* trigger includes were a mess
* c -> c++ cleanup
* os util
* why did so many include os_util.h?
* fwd declare
* cypress/kinetis
* s
* eg33 happy
* happy sim
* cypress usb
* pch
* cypress
* doesn't need to include all that
* h7
2022-04-25 20:38:16 -04:00
rusefillc
1ce5be5629
m_hasSynchronizedSymmetrical handling improvements #4099 ( #4101 )
2022-04-23 19:45:29 -04:00
Matthew Kennedy
8650686ab7
knock threshold table fix ( #4077 )
...
* fix knock threshold table
* defaults
* knock controller is engine module
* testable
* test builds
* knock tests work
* s
* format
* everyone loves changelogs
2022-04-18 08:03:16 -04:00
GitHub build-firmware Action
783aa1451c
Auto-generated configs and docs
2022-04-17 20:30:07 +00:00
rusefillc
c93594cd1b
random progress
2022-04-16 16:39:52 -04:00
Matthew Kennedy
735b4899e2
allow setting injection phase by start or center of injection ( #4068 )
...
* allow SOI/COI
* other change
* renames and simplify
* clean up ownIndex
* double check in spark logic
2022-04-15 10:22:36 -04:00
rusefillc
5f288d88dc
do not control VVT during cranking fix #3443
2022-04-10 19:22:39 -04:00
rusefillc
9ae96ea7e5
refactoring: method rename
2022-04-02 21:01:29 -04:00
Matthew Kennedy
f0013f71b5
limp mangaer handles more stuff ( #3983 )
2022-03-20 09:28:17 -04:00
Benas Brazdziunas
dbcc165a11
Launch fuel and spark cut issue ( #3988 )
...
* Launch fual and spark cut issue
* moved launch cuts to limp_manager
* Applied recomendations
* Auto-generated configs and docs
* Added recomendations
* Auto-generated configs and docs
Co-authored-by: GitHub build-firmware Action <action@github.com>
Co-authored-by: Benas <bbrazdziunas@gavea.co.uk>
2022-03-11 09:27:42 -05:00
rusefillc
3be2fcaa80
Limp shutdown rebase ( #3879 )
...
* limp manager handles engine stop
* use timer
* dead relevant fsio
* this stuff needs its own ticket
* if we can comment out 'business logic' and tests do not fail it's not a great sign :(
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-02-01 20:47:17 -05:00
Matthew Kennedy
258f00efa3
fix sequential mode cranking ( #2919 )
...
* fix
* use the right enum
* do it for fuel too
* earlier
* s
2022-02-01 19:04:20 -05:00
Matthew Kennedy
fe6cdf60e3
warnings fixes ( #3851 )
...
* unused things
* !!! actual bug !!!
* dead
* unused
* unused
* multi-bus lua RX was just broken
* make the compiler angry about it
* dead config
* alphax 2
* just call, no store
* compiler too angry
2022-01-31 18:37:42 -05:00
Matthew Kennedy
b07127614b
decouple TPS accel enrichment from trigger ( #3825 )
...
* move call site
* move thresholding out of fast path
* adjust config
* test
2022-01-23 15:31:39 -05:00
Andrey
e94b251e33
Good news RPM is now float
...
open question if I've affected performance negativelly or not.
2022-01-21 00:56:13 -05:00
Andrey
4e676e1a86
fixing NOISY_RPM handling via Sensor framework
2022-01-21 00:21:45 -05:00
Andrey
014ea2b78a
migrating to SensorType::Rpm API
2022-01-20 23:54:52 -05:00
Andrey
e0258c4c8e
migrating to SensorType::Rpm API
2022-01-20 23:36:09 -05:00
Andrey
5f3324cd6b
migrating to SensorType::Rpm API
2022-01-20 23:32:59 -05:00
Andrey
3a6597464f
migrating to SensorType::Rpm API
2022-01-20 22:04:45 -05:00
Andrey
ea014a07d8
what's the difference between setRpmValue and assignRpmValue #3815
...
refactoring
2022-01-20 21:48:18 -05:00
Matthew Kennedy
8828c8a101
#3815 ( #3816 )
2022-01-19 17:38:17 -05:00