Andrey
4a7a48779d
ETB duty cycle jitter #4833
2022-11-29 20:51:28 -05:00
Andrey
7547edb566
mock invalid & current state of ETB error counter
2022-11-29 20:36:03 -05:00
Andrey
b97745496e
refactoring: extracting method
2022-11-29 20:11:34 -05:00
Andrey
ca63f37d9e
ETB duty cycle jitter #4833
...
do-you-TDD
2022-11-29 16:05:36 -05:00
Andrey
8a3727de3e
ETB duty cycle jitter #4833
2022-11-29 14:59:08 -05:00
Andrey
73e309da03
ETB duty cycle jitter #4833
2022-11-29 14:02:44 -05:00
Andrey
82a3074cbd
ETB overheats due to constant isTpsError true/false/true/false jitter #4832
2022-11-29 11:42:09 -05:00
Andrey
651944152f
ETB JNI test progress
...
Coffee is important!
2022-11-29 10:25:15 -05:00
Andrey
e31f042603
ETB JNI test progress
...
I am pretty confused :(
2022-11-29 10:17:05 -05:00
Andrey
2c13af3324
ETB JNI test progress
2022-11-29 09:58:35 -05:00
Andrey
1d4a454f0c
ETB JNI test progress
2022-11-29 02:21:36 -05:00
Andrey
d8e808ad13
ETB JNI test progress
2022-11-29 01:03:29 -05:00
Andrey
0c69adaa1f
ETB JNI test progress
2022-11-29 00:38:59 -05:00
Andrey
bcbe06d210
ETB JNI test progress
2022-11-29 00:10:46 -05:00
Andrey
d7cdf75e22
unit test compile more of ETB code
2022-11-28 23:41:51 -05:00
Andrey
a14fb947c2
exp average is pretty cool
2022-11-28 19:22:45 -05:00
Andrey
ac12287ab0
ETB duty cycle jitter #4833
...
weird, whatever for now :(
2022-11-27 21:16:50 -05:00
Andrey
c5a5d7f6eb
ETB duty cycle jitter #4833
...
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey
e1d3647401
ETB duty cycle jitter #4833
...
a step back to safety
2022-11-27 19:26:28 -05:00
Matthew Kennedy
9e60b52ed4
fix warnings ( #4840 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-27 10:11:14 -05:00
Andrey
638c7fdc6d
Target AFR table Y axis stuck at 0 #4826
...
sweet coverage :)
2022-11-26 20:22:40 -05:00
Andrey
45a52e3ae2
progress
2022-11-26 17:39:25 -05:00
rusefillc
c729b10bbe
refactoring: constexpr fuel computer ( #4830 )
...
* refactoring: constexpr fuel computer
* refactoring: constexpr fuel computer
* refactoring: constexpr fuel computer
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 12:25:04 -05:00
rusefillc
d63f1af40d
without ValueProvider3D interface how do we mock? ( #4829 )
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:23:54 -05:00
Andrey
f32ae379f5
nissan
2022-11-23 23:45:25 -05:00
rusefillc
261222bb04
avoid ctime in GPS UART ( #4824 )
...
Co-authored-by: Nathan Schulte <nmschulte@desmas.net>
2022-11-23 13:20:36 -05:00
Nathan Schulte
d4cc3caeab
code style, GPS fixes (test, firmware) ( #4822 )
...
* tidy NMEA
* const in nmea
* correct gps test output
* fix GPS UART print statements
* cleanup feature toggles in settings
* fix comment typos, misc whitespace
2022-11-23 07:01:34 -04:00
rusefillc
ba3d482340
What is "Aux PID"? #4807
2022-11-21 00:10:35 -05:00
GitHub build-unit-tests Action
5b03455dae
Trigger wheel definitions
2022-11-16 20:54:55 +00:00
Andrey
7afc95a241
refactoring: default parameter, global replace
2022-11-16 14:28:43 -05:00
GitHub build-unit-tests Action
1ede71f987
Trigger wheel definitions
2022-11-16 16:48:00 +00:00
Andrey G
85f46318a4
SENT updates ( #4774 )
...
* SENT: simplify
* SENT: add crc6 routine, check crc for slow channels enhanced messages
* SENT: helper to get Slow Channel values
* SENT: getTickTime() report tick unit time
* unit_tests: SENT: update tests
2022-11-12 16:57:20 -05:00
Andrey
05b46b1b12
Nissan
2022-11-12 13:06:55 -05:00
Andrey G
9b0fa7ec43
SENT unit tests ( #4769 )
...
* unit_tests: sent: zero-init
* sent: SENT_SLOW_CHANNELS_MAX to header
* unit_tests: sent: clock, falling edges
* SENT: support and autodetect if device sends pause pulse
Also rework tick time calculation
* unit_tests: SENT: verbose debug on request
* unit_tests: SENT: actual checks
* unit_tests: SENT: extract common code for reuse
* unit_test: SENT: add test with fuel pressue captured data
* unit_test: SENT: add test with Ford ETB CLOSED captured data
2022-11-11 17:25:02 -05:00
GitHub build-unit-tests Action
b52c80ad6b
Trigger wheel definitions
2022-11-09 03:08:46 +00:00
Matthew Kennedy
7b47e77e58
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy
e801ffc979
fix vvt logging logic ( #4747 )
...
* fix vvt logging logic
* put that back
* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
Andrey
cebb3e1847
Ford SENT ETB bench test in NJ #4745
...
we shall unit test SENT
2022-11-07 00:06:42 -05:00
rusefillc
1e10055279
Ford SENT ETB bench test in NJ #4745
...
we shall unit test SENT
2022-11-06 23:21:54 -05:00
rusefi
5c32f75c2c
reducing ugly
2022-11-06 21:28:38 -05:00
rusefi
80e02de00b
https://rusefi.com/forum/viewtopic.php?p=46603#p46603
...
calling 'setTimeout' on bad self (cpp class not export)
2022-11-06 20:09:01 -05:00
Andrey
e42939560f
sensor_chart into unit tests
2022-11-06 11:28:25 -05:00
Andrey
25d292c462
trigger refactoring: instance RPM #4740
2022-11-06 11:05:57 -05:00
rusefillc
cc7af64ed3
minor trigger refactoring
2022-11-06 00:59:29 -04:00
Matthew Kennedy
32b170810e
duplicate log field names ( #4730 )
...
* remove duplicate target lambda/afr
* names on fuel computer
* remove more copies
* sensor.java
* everybody loves hard dependencies on generated fields
* target afr gauge fix
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-05 20:23:09 -04:00
Matthew Kennedy
acfde29c60
remove idle timing deadzone ( #4731 )
...
* remove idle timing deadzone
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-04 15:02:20 -04:00
Andrey
ea0a054dfc
Nissan defaults
2022-11-02 12:05:51 -04:00
rusefi
8d0ac7a5be
huh, we can pole larger method here
2022-10-26 12:08:27 -04:00
rusefillc
2aabff5c8f
so much weird
2022-10-24 23:02:39 -04:00
Matthew Kennedy
890a8e0fed
implement "ford mode" injector correction ( #4686 )
...
* implement "ford mode"
* missed the enum value
2022-10-20 22:25:39 -04:00
Matthew Kennedy
1cc46a1b83
simplify initializeSkippedToothTrigger ( #4674 )
2022-10-17 16:05:27 -04:00
GitHub build-unit-tests Action
1c74ddfc68
Trigger wheel definitions
2022-10-16 16:21:57 +00:00
GitHub build-unit-tests Action
ad55f3fad1
Trigger wheel definitions
2022-10-16 14:42:22 +00:00
rusefillc
9c75704412
triggerImage: todo: support symmetrical crank
2022-10-16 10:33:38 -04:00
GitHub build-unit-tests Action
0abfdd8df1
Trigger wheel definitions
2022-10-16 14:31:28 +00:00
rusefillc
5590b55273
triggerImage: todo: support symmetrical crank
2022-10-16 02:59:57 -04:00
GitHub build-unit-tests Action
a1b0b76fcd
Trigger wheel definitions
2022-10-16 06:57:03 +00:00
rusefillc
fc66b45ce4
triggerImage: todo: support symmetrical crank
2022-10-16 02:44:57 -04:00
Matthew Kennedy
7116670fd0
build tweaks for size ( #4661 )
...
* don't align on non-cached mcu
* lua decimal point
* no snprintf
* sort sections by alignment
* unit tests
2022-10-13 20:30:30 -04:00
GitHub build-unit-tests Action
060849c364
Trigger wheel definitions
2022-10-10 01:31:12 +00:00
Matthew Kennedy
14b92612e2
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
GitHub build-unit-tests Action
795b3cff84
Trigger wheel definitions
2022-10-06 02:10:48 +00:00
Matthew Kennedy
f07c00548b
2jz test ( #4638 )
2022-10-05 20:48:28 -04:00
Andrey
3d329639ea
Mark is asking for VIN number field #3967
2022-10-04 21:12:51 -04:00
Matthew Kennedy
58a5569006
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy
60fc30d34d
remove 898 ( #4634 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-10-04 20:12:57 -04:00
Matthew Kennedy
f2c8a0192c
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
Matthew Kennedy
9cd5553617
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy
90489edb96
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
GitHub build-unit-tests Action
9996f3c562
Trigger wheel definitions
2022-09-25 13:23:24 +00:00
Matthew Kennedy
6f5bed28d9
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
Matthew Kennedy
dbf8a1ea2a
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
Andrey
24cf41c5f7
Honda K cam wheels #3405
2022-09-25 00:26:42 -04:00
Andrey
df0bb3ebc5
Honda K cam wheels #3405
2022-09-24 23:49:41 -04:00
Andrey
178fe15760
more inclusive configuration name
2022-09-24 23:49:41 -04:00
Andrey
4653cde601
K progress
2022-09-24 23:18:57 -04:00
Andrey
cd2da05443
progress
2022-09-24 23:07:55 -04:00
Andrey
63fe1120bd
fancy default and reusing constant
2022-09-24 23:01:42 -04:00
Andrey
3730a4650c
renaming stuff
2022-09-24 22:55:54 -04:00
Andrey
533d30efd1
fancy
2022-09-24 22:54:58 -04:00
Andrey
d497d99a8c
K
2022-09-24 15:37:51 -04:00
Andrey
e7e9742ba9
refactoring: extract constant
2022-09-24 15:33:01 -04:00
rusefillc
35bf947f06
insist on setBoardConfigOverrides fix #4614 ( #4615 )
...
* insist on setBoardConfigOverrides fix #4614
* insist on setBoardConfigOverrides fix #4614
* insist on setBoardConfigOverrides fix #4614
* insist on setBoardConfigOverrides fix #4614
* insist on setBoardConfigOverrides fix #4614
2022-09-24 07:35:19 -04:00
Matthew Kennedy
02aad24c59
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
GitHub build-unit-tests Action
e1cebcef4f
Trigger wheel definitions
2022-09-24 00:25:12 +00:00
rusefillc
c6a2f2657b
honda K enum rename
2022-09-23 20:13:14 -04:00
rusefillc
08499c7252
K20
2022-09-23 20:13:14 -04:00
rusefillc
04ac7fcd3b
K20
2022-09-23 18:25:24 -04:00
Matthew Kennedy
0dfba2a655
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
Matthew Kennedy
4e78c4c922
two modes trigger scheduler ( #4598 )
...
* two modes trigger scheduler
* asOld
* hpfp
2022-09-20 05:28:23 -04:00
rusefillc
70dc03a821
B6
2022-09-17 23:49:24 -04:00
Andrey
579f3df7ad
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey
b439f27284
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
Andrey
34f87a3683
inline method to reduce confusion
2022-09-14 01:24:19 -04:00
Andrey
b1451e229c
GM
2022-09-14 00:03:38 -04:00
Andrey
32c6aef746
code formatting
2022-09-13 23:44:38 -04:00
Andrey G
2b4012b279
dead code, reduce typedefs ( #4566 )
...
* Do lightweight checks first
* Dead getTimeIgnitionSeconds()
Dead since 5274cffff3
* Get rid of efitime_t.
Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.
* Fix unit tests
* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G
1ca5988877
time routines refactor ( #4563 )
...
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc
921b97431f
refactoring: type safety
2022-09-11 03:46:50 -04:00
rusefillc
cb3c070928
refactoring: type safety
2022-09-11 02:57:35 -04:00