Scott Smith
f9f13f0bad
Create a base class EngineModule for that contains various useful callbacks. ( #3548 )
...
* Create a base class EngineModule for that contains various useful callbacks.
This cleans up the API by not requiring the notifiers to know about who wants callbacks. The only
place you need to update to add a module is in one place.
* Add mockability.
* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
rusefillc
dfac1897e1
Startup Pin State Error - maybe hardware damage of STM32 pin connected to a 12v-powered TC4427? #3558
2021-11-17 04:45:55 -05:00
rusefillc
46d2b21ecc
proportional spark cut #3427
2021-11-17 04:06:22 -05:00
Scott Smith
80091498a6
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith
19f7fa8f89
Make engine* and friends be const pointers in production. ( #3564 )
...
This allows the compiler to see through the pointer and make accesses faster.
It saves 1336 bytes of text.
2021-11-17 03:53:17 -05:00
Scott Smith
14578ddae7
Remove a bunch of macros from engine_ptr.h ( #3562 )
2021-11-17 10:01:39 +03:00
GitHub set-date Action
05bef81735
Update date
2021-11-17 01:00:29 +00:00
Scott Smith
dac2ae9b1d
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
rusefillc
774d96493e
spelling
2021-11-16 16:46:54 -05:00
rusefillc
6fdb98e84f
helping launch enter simulator
2021-11-16 16:45:14 -05:00
rusefillc
ed1d24dbbe
helping launch enter simulator
2021-11-16 16:31:35 -05:00
Andrey
1be12392c0
proportional spark cut #3427
2021-11-16 13:23:08 -05:00
Andrey
c201b5b0ec
proportional spark cut #3427
2021-11-16 05:56:15 -05:00
Matthew Kennedy
7296593448
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
Scott Smith
2cfc4af998
Start the process of using a global engine ptr for unit tests. ( #3551 )
...
* Start the process of using a global engine ptr for unit tests.
Passing around the engine, config, and persistent state wasn't buying anything. Instead, use
EngineTestHelper(Base) to correctly set and clear the global variables. Add a dummy check in
case some test tries to set them manually.
* Fix OSX build
* Adapt PR to recently added code.
2021-11-16 00:23:14 -05:00
Scott Smith
c354d30a71
Use Valgrind to detect unitialized variable references. ( #3555 )
...
* Use Valgrind to detect unitialized variable references.
Fix the edge cases that pop up
* Comment and disable Mac run
2021-11-15 23:42:23 -05:00
GitHub build-firmware Action
b477365e7c
Auto-generated configs and docs
2021-11-16 02:53:15 +00:00
Andrey
164218747a
Knock retard #3396
2021-11-15 21:21:45 -05:00
Andrey
b545743f7d
Not all launch control options are used #3554
2021-11-15 21:13:01 -05:00
Andrey
349d224b5f
technical debt: enableOverdwellProtection #3553
...
only documentation
2021-11-15 20:32:25 -05:00
Andrey
7b790d36f6
random refactoring: trigger central encapsulation
2021-11-15 20:22:05 -05:00
Andrey
4bc9343d0b
refactoring launch
2021-11-15 20:09:03 -05:00
Andrey
837cdf2cfb
refactoring launch
2021-11-15 19:55:04 -05:00
Andrey
0a956d96b4
refactoring launch
2021-11-15 19:55:04 -05:00
Andrey
c8b733ea6e
refactoring launch
2021-11-15 19:34:42 -05:00
Andrey
c41dccb5ff
refactoring launch
2021-11-15 19:24:00 -05:00
Andrey
bc3befd0ac
refactoring launch
2021-11-15 18:57:12 -05:00
Andrey
bafd5e0e17
refactoring launch
2021-11-15 14:40:35 -05:00
Matthew Kennedy
c1941f3a49
(void) -> () ( #3550 )
...
* static functions with (void)
* more
* Revert "more"
This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
Matthew Kennedy
bd04dc8352
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
GitHub build-firmware Action
a29aa50cb0
Auto-generated configs and docs
2021-11-15 03:03:29 +00:00
rusefillc
8448b04078
MAP phase sensing #3544
2021-11-14 21:58:01 -05:00
GitHub build-firmware Action
a7a89b74d5
Auto-generated configs and docs
2021-11-15 02:31:36 +00:00
rusefillc
9420c6d831
MAP phase sensing #3544
2021-11-14 21:24:59 -05:00
GitHub set-date Action
b814015179
Update date
2021-11-15 01:00:10 +00:00
rusefillc
c6bc2f73f6
clarification
2021-11-14 18:36:59 -05:00
GitHub build-firmware Action
ecf4a31095
Auto-generated configs and docs
2021-11-14 23:09:53 +00:00
rusefillc
c616a6f057
Epic: Remove FSIO #2928
2021-11-14 17:56:58 -05:00
rusefi
c5077a88e5
## November 2021 Release - "Loosen Up Lighten Up Day"
2021-11-14 17:47:07 -05:00
rusefi
1f486a1e15
Lua: changing "table" API
2021-11-14 16:29:46 -05:00
Matthew Kennedy
3d79c06200
enable nb1 serial pins ( #3546 )
...
* enable serial on nb1
* typo
* serial
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-14 16:07:56 -05:00
rusefi
301bdf08a2
Something something Automatic Compression Release #3442
2021-11-14 16:04:44 -05:00
rusefillc
8cb1f2545c
trigger refactoring & docs
2021-11-14 15:35:11 -05:00
Matthew Kennedy
af78ab76cb
math is fun ( #3545 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-14 15:32:35 -05:00
rusefi
291f815b2d
Something something Automatic Compression Release #3442
2021-11-14 15:04:10 -05:00
rusefi
e40780a595
more API
2021-11-14 14:53:44 -05:00
rusefi
924ae4b4a1
Epic: Remove FSIO #2928
2021-11-14 14:44:52 -05:00
GitHub build-firmware Action
98e2649f70
Auto-generated configs and docs
2021-11-14 19:42:17 +00:00
rusefi
0f29e137b7
bugfix: show both new and legacy field names were displayed
2021-11-14 14:19:09 -05:00
rusefi
df4f122c0b
Epic: Remove FSIO #2928
2021-11-14 14:14:43 -05:00