Scott Smith
f9f13f0bad
Create a base class EngineModule for that contains various useful callbacks. ( #3548 )
...
* Create a base class EngineModule for that contains various useful callbacks.
This cleans up the API by not requiring the notifiers to know about who wants callbacks. The only
place you need to update to add a module is in one place.
* Add mockability.
* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith
80091498a6
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith
dac2ae9b1d
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy
7296593448
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
Matthew Kennedy
bd04dc8352
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
Matthew Kennedy
a2766e5d9b
support autoscale on table axes ( #3452 )
...
* scale map Y axis
* allow different row/col types
* scaled channel detector
* interpolation
* looks like this actually works
* tests, no manual scaling
* comment
2021-11-03 19:53:26 -04:00
rusefillc
a16819ae10
refactoring
2021-10-16 23:18:09 -04:00
rusefillc
1fe037192e
refactoring
2021-10-16 22:08:47 -04:00
rusefillc
0518617689
Remove engine load acceleration enrichment fix #3357
2021-10-16 21:49:38 -04:00
rusefillc
504bd78814
Remove engine load acceleration enrichment fix #3357
2021-10-16 21:24:05 -04:00
Andreika
99fb5e4204
[DRAFT] Fix cranking->idling taper phase for useSeparate*ForIdle tables ( #3168 )
...
* Rename Phase::CrankToRunTaper -> CrankToIdleTaper
* Change isIdling() to isIdlingOrTaper()
* test_idle_controller.cpp
* useSeparateIdleTablesForCrankingTaper setting
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 12:05:20 -04:00
Matthew Kennedy
dab377d15d
getOrZero ( #3319 )
2021-10-05 19:59:07 -04:00
Matthew Kennedy
4e6b61234f
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Matthew Kennedy
d3ec2b21d1
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
Matthew Kennedy
e3849b95d5
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
Matthew Kennedy
b68469822e
lua hooks for custom airmass model ( #2697 )
...
* lua airmass
* not const any more
* bad merge
* don't change the position of others
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-16 00:49:14 -04:00
Matthew Kennedy
77f9c68733
not const getAirmass ( #2883 )
...
* not const
* test
2021-07-01 00:05:42 -04:00
Matthew Kennedy
0c03a1cb4a
const airmass ( #2694 )
2021-05-14 07:17:22 -04:00
Matthew Kennedy
76f2f063d2
Maf in sensor model ( #2672 )
...
* init
* consumers
* hasMafSensor
* consumers
* remove
* remove
* s
* guard
* tiny bit of ram
* ram
2021-05-09 20:59:06 -04:00
Matthew Kennedy
dbebc353a2
remove unused msg parameter ( #2360 )
...
* dead parameter
* last few
2021-02-16 09:32:16 -05:00
Matthew Kennedy
ace0f4e78c
Add fallback map table ( #2248 )
...
* table
* sd math
* config
* debug channel name
* ptr vs not ptr
* actually use return value
* memory
* less magic
2021-01-31 17:19:06 -05:00
Matthew Kennedy
654bf0d698
Map fallback logic, TS cleanup ( #2247 )
...
* add new field
* UI
* set default
* consume new parameter
* some cleanup while we're at it
2021-01-27 20:31:29 -05:00
Matthew Kennedy
d4965d16f3
Enable idle timing/ve tables based on idle phase logic ( #2213 )
...
* add helper
* advance
* ve
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-11 00:54:37 -05:00
Matthew Kennedy
add0dcd390
switch more map to read from sensor model ( #2162 )
...
* hook up map
* check for init
* switch some consumers
* that's the rest of them
* test
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
Matthew Kennedy
83266c904b
Put map in the sensor model ( #2161 )
...
* hook up map
* check for init
* switch some consumers
* don't do limp for now
* oops
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-30 08:43:49 -05:00
rusefillc
a1fe39b89d
unit tests in clang #2012
2020-12-04 23:59:21 -05:00
rusefillc
5118a67f89
better error handling
2020-11-17 22:45:43 -05:00
Matthew Kennedy
8adfef930f
Selectable VE axis override ( #1769 )
...
* add config fields
* config options
* new output channels
* dump out state to ts
* s
* implement override
* enums
* this test is no longer used
* test new behavior
* old
* comments
2020-09-07 10:15:42 -04:00
Matthew Kennedy
a3db817f6e
Move ve logic ( #1762 )
...
* move ve
* fix build
* fix rendering
* duh
* cleaning
* correct scaling
* put some back
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-09-06 19:06:32 -04:00
Matthew Kennedy
5b6091524b
explicit
2020-07-29 02:23:03 -07:00
Matthew Kennedy
ca2559c669
fwd decl
2020-07-28 11:44:09 -07:00
Matthew Kennedy
5f8ab63695
missed a spot
2020-07-25 02:05:33 -07:00
Matthew Kennedy
eda3fd020a
alphan
2020-07-25 01:14:35 -07:00
Matthew Kennedy
73c0582908
move speed density
2020-07-24 19:30:12 -07:00
Matthew Kennedy
fceac1b131
format
2020-07-24 11:44:54 -07:00
Matthew Kennedy
5c156ebada
move impl
2020-07-23 01:23:57 -07:00
Matthew Kennedy
49ed4d40a2
base class
2020-07-23 01:12:38 -07:00
Matthew Kennedy
28d27c4990
comment headers, notes
2020-07-22 18:24:20 -07:00
Matthew Kennedy
7940b84778
start refactor
2020-07-22 13:11:07 -07:00
Matthew Kennedy
2525a9a22c
Factor out airmass logic ( #1483 )
...
* refactor
* extract more airmass
* rename, fix tests
2020-06-06 07:25:19 -04:00