rusefi
/
isotp-c
mirror of https://github.com/rusefi/isotp-c.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove const specifiers for value parameters 

clang-tidy doesn't like this construct, and gives the following warning:
readability-avoid-const-params-in-decls
https://clang.llvm.org/extra/clang-tidy/checks/readability-avoid-const-params-in-decls.html
This commit is contained in:
Phil Wise 2018-05-14 17:07:04 +02:00
parent 4c5904bff3
commit 83b0bf8ba8
4 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
README.mkd
View File

@ -27,8 +27,8 @@ system:
// required, this must send a single CAN message with the given arbitration // required, this must send a single CAN message with the given arbitration
// ID (i.e. the CAN message ID) and data. The size will never be more than 8 // ID (i.e. the CAN message ID) and data. The size will never be more than 8
// bytes. // bytes.
void send_can(const uint16_t arbitration_id, const uint8_t* data, void send_can(uint16_t arbitration_id, const uint8_t* data,
const uint8_t size) { uint8_t size) {
... ...
} }

6
src/isotp/receive.h
View File

@ -52,7 +52,7 @@ typedef struct {
* when the message is completely sent. * when the message is completely sent.
*/ */
IsoTpReceiveHandle isotp_receive(IsoTpShims* shims, IsoTpReceiveHandle isotp_receive(IsoTpShims* shims,
const uint32_t arbitration_id, IsoTpMessageReceivedHandler callback); uint32_t arbitration_id, IsoTpMessageReceivedHandler callback);
/* Public: Continue to receive a an ISO-TP message, based on a freshly /* Public: Continue to receive a an ISO-TP message, based on a freshly
* received CAN message. * received CAN message.
@ -76,8 +76,8 @@ IsoTpReceiveHandle isotp_receive(IsoTpShims* shims,
* handle. Keep passing the same handle to this function when CAN frames arrive. * handle. Keep passing the same handle to this function when CAN frames arrive.
*/ */
IsoTpMessage isotp_continue_receive(IsoTpShims* shims, IsoTpMessage isotp_continue_receive(IsoTpShims* shims,
IsoTpReceiveHandle* handle, const uint32_t arbitration_id, IsoTpReceiveHandle* handle, uint32_t arbitration_id,
const uint8_t data[], const uint8_t size); const uint8_t data[], uint8_t size);
#ifdef __cplusplus #ifdef __cplusplus
} }

6
src/isotp/send.h
View File

@ -46,7 +46,7 @@ typedef struct {
* *
* Returns a message object to be passed to isotp_send() * Returns a message object to be passed to isotp_send()
*/ */
IsoTpMessage isotp_new_send_message(const uint16_t arbitration_id, const uint8_t payload[], uint16_t size); IsoTpMessage isotp_new_send_message(uint16_t arbitration_id, const uint8_t payload[], uint16_t size);
/* Public: Initiate sending a single ISO-TP message. /* Public: Initiate sending a single ISO-TP message.
* *
@ -88,8 +88,8 @@ IsoTpSendHandle isotp_send(IsoTpShims* shims, IsoTpMessage* message, IsoTpMessag
* it was successful. * it was successful.
*/ */
bool isotp_receive_flowcontrol(IsoTpShims* shims, IsoTpSendHandle* handle, bool isotp_receive_flowcontrol(IsoTpShims* shims, IsoTpSendHandle* handle,
const uint16_t arbitration_id, const uint8_t data[], uint16_t arbitration_id, const uint8_t data[],
const uint8_t size); uint8_t size);
/* Public: Continue sending multi-frame package based on the current state /* Public: Continue sending multi-frame package based on the current state
* *

11
tests/common.c
View File

@ -46,8 +46,8 @@ void debug(const char* format, ...) {
va_end(args); va_end(args);
} }
bool mock_send_can(const uint32_t arbitration_id, const uint8_t* data, bool mock_send_can(uint32_t arbitration_id, const uint8_t* data,
const uint8_t size) { uint8_t size) {
can_frame_was_sent = true; can_frame_was_sent = true;
last_can_frame_sent_arb_id = arbitration_id; last_can_frame_sent_arb_id = arbitration_id;
last_can_payload_size = size; last_can_payload_size = size;
@ -70,7 +70,7 @@ void message_received(const IsoTpMessage* message) {
} }
} }
void message_sent(const IsoTpMessage* message, const bool success) { void message_sent(const IsoTpMessage* message, bool success) {
if(success) { if(success) {
debug("Sent ISO-TP message:"); debug("Sent ISO-TP message:");
} else { } else {
@ -88,8 +88,9 @@ void message_sent(const IsoTpMessage* message, const bool success) {
} }
} }
void can_frame_sent(const uint32_t arbitration_id, const uint8_t* payload, void can_frame_sent(uint32_t arbitration_id, const uint8_t* payload,
const uint8_t size) { uint8_t size) {
(void)payload;
debug("Sent CAN Frame with arb ID 0x%x and %d bytes", arbitration_id, size); debug("Sent CAN Frame with arb ID 0x%x and %d bytes", arbitration_id, size);
} }