From 0578b3813b624685d23ecc2e8b412cf8ab6dcd14 Mon Sep 17 00:00:00 2001 From: Redirion Date: Tue, 9 Oct 2018 12:15:09 +0200 Subject: [PATCH] Avoid using su on Android if not required on some devices the com ports already have the required file flags, so check them first to avoid unnecessary work --- src/main/java/com/fazecast/jSerialComm/SerialPort.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/fazecast/jSerialComm/SerialPort.java b/src/main/java/com/fazecast/jSerialComm/SerialPort.java index 40f0138..caa1db3 100644 --- a/src/main/java/com/fazecast/jSerialComm/SerialPort.java +++ b/src/main/java/com/fazecast/jSerialComm/SerialPort.java @@ -378,7 +378,8 @@ public final class SerialPort try { Thread.sleep(safetySleepTime); } catch (Exception e) {} // If this is an Android root application, we must explicitly allow serial port access to the library - if (isAndroid) + File portFile = isAndroid ? new File(comPort) : null; + if (portFile != null && (!portFile.canRead() || !portFile.canWrite())) { Process process = null; try