shall we be just a little less Toyota

Makefile

@@ -56,7 +56,7 @@ ifeq ($(USE_OPT),)
 # -O2 is needed for mingw, without it there is a linking issue to isnanf?!?!
   #USE_OPT = $(RFLAGS) -O2 -fgnu89-inline -ggdb -fomit-frame-pointer -falign-functions=16 -std=gnu99 -Werror-implicit-function-declaration -Werror -Wno-error=pointer-sign -Wno-error=unused-function -Wno-error=unused-variable -Wno-error=sign-compare -Wno-error=unused-parameter -Wno-error=missing-field-initializers
   USE_OPT = -c -Wall -O0 -ggdb -g
-  USE_OPT += -Werror=missing-field-initializers
+  USE_OPT += -Werror=missing-field-initializers -Werror=shadow
 endif
 
 # C specific options here (added to USE_OPT).

pt2001/include/rusefi/pt2001.h

@@ -34,8 +34,8 @@ public:
 	// Disable the PT2001 chip.
 	void shutdown();
 
-	void onError(McFault fault) {
-	    this->fault = fault;
+	void onError(McFault p_fault) {
+	    fault = p_fault;
 	}
 
 	// Re-read timing configuration and reconfigure the chip. This is safe to call while operating.

util/include/rusefi/containers/cyclic_buffer.h

@@ -52,8 +52,8 @@ cyclic_buffer<T, maxSize>::cyclic_buffer() : cyclic_buffer(maxSize) {
 }
 
 template<typename T, size_t maxSize>
-cyclic_buffer<T, maxSize>::cyclic_buffer(int size) {
-	setSize(size);
+cyclic_buffer<T, maxSize>::cyclic_buffer(int p_size) {
+	setSize(p_size);
 }
 
 template<typename T, size_t maxSize>
@@ -83,9 +83,9 @@ bool cyclic_buffer<T, maxSize>::contains(T value) const {
 }
 
 template<typename T, size_t maxSize>
-void cyclic_buffer<T, maxSize>::setSize(size_t size) {
+void cyclic_buffer<T, maxSize>::setSize(size_t p_size) {
 	clear();
-	this->size = size < maxSize ? size : maxSize;
+	size = p_size < maxSize ? p_size : maxSize;
 }
 
 template<typename T, size_t maxSize>

util/test/test_cyclic_buffer.cpp

@@ -0,0 +1,37 @@
+#include <gtest/gtest.h>
+
+#include "cyclic_buffer.h"
+#include "rusefi/true_false.h"
+
+TEST(util, cyclicBufferContains) {
+	cyclic_buffer<int> sb;
+	sb.add(10);
+	ASSERT_EQ(TRUE, sb.contains(10));
+	ASSERT_EQ(FALSE, sb.contains(11));
+}
+
+TEST(util, cyclicBuffer) {
+	cyclic_buffer<int> sb;
+
+	{
+		sb.add(10);
+
+		ASSERT_EQ(10, sb.sum(3));
+
+		sb.add(2);
+		ASSERT_EQ(12, sb.sum(2));
+	}
+	{
+		sb.clear();
+
+		sb.add(1);
+		sb.add(2);
+		sb.add(3);
+		sb.add(4);
+
+		ASSERT_EQ(4, sb.maxValue(3));
+		ASSERT_EQ(4, sb.maxValue(113));
+		ASSERT_EQ( 2,  sb.minValue(3)) << "minValue(3)";
+		ASSERT_EQ(1, sb.minValue(113));
+	}
+}

util/util.mk

@@ -10,6 +10,7 @@ RUSEFI_LIB_CPP += \
 RUSEFI_LIB_CPP_TEST += \
 	$(RUSEFI_LIB)/util/test/test_arrays.cpp \
 	$(RUSEFI_LIB)/util/test/test_crc.cpp \
+	$(RUSEFI_LIB)/util/test/test_cyclic_buffer.cpp \
 	$(RUSEFI_LIB)/util/test/test_efistringutil.cpp \
 	$(RUSEFI_LIB)/util/test/test_fragments.cpp \
 	$(RUSEFI_LIB)/util/test/test_interpolation.cpp \