From 0c9080c7a9c2e0f9ee39a887bbde5385160b9747 Mon Sep 17 00:00:00 2001 From: Roberto Ierusalimschy Date: Fri, 18 Dec 1998 11:26:43 -0200 Subject: [PATCH] "tonumber" goes crazy with negative numbers in other bases (not 10), because "strtol" returns long, not unsigned long. --- bugs | 6 ++++++ lbuiltin.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/bugs b/bugs index bd5806e5..c07d8a66 100644 --- a/bugs +++ b/bugs @@ -52,3 +52,9 @@ of view) when functions have upvalues. ** lstrlib.c Tue Nov 10 17:29:36 EDT 1998 >> gsub/strfind do not check whether captures are properly finished. + +** lbuiltin.c +Fri Dec 18 11:22:55 EDT 1998 +>> "tonumber" goes crazy with negative numbers in other bases (not 10), +because "strtol" returns long, not unsigned long. + diff --git a/lbuiltin.c b/lbuiltin.c index 0398c7ac..d72a320d 100644 --- a/lbuiltin.c +++ b/lbuiltin.c @@ -1,5 +1,5 @@ /* -** $Id: lbuiltin.c,v 1.37 1998/12/15 14:59:59 roberto Exp roberto $ +** $Id: lbuiltin.c,v 1.38 1998/12/15 15:21:09 roberto Exp $ ** Built-in functions ** See Copyright Notice in lua.h */ @@ -268,7 +268,7 @@ static void luaB_tonumber (void) { } else { char *s = luaL_check_string(1); - unsigned long n; + long n; luaL_arg_check(0 <= base && base <= 36, 2, "base out of range"); n = strtol(s, &s, base); while (isspace(*s)) s++; /* skip trailing spaces */