rusefi
/
lua
mirror of https://github.com/rusefi/lua.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BUG: 'luaV_settable' may invalidate a reference to a table and try 

to reuse it.
This commit is contained in:
Roberto Ierusalimschy 2009-07-01 18:10:33 -03:00
parent afb3f7e754
commit d57c9cdefc
1 changed files with 46 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
bugs
View File

@ -1880,8 +1880,8 @@ patch = [[
+++ lundump.c 2008/04/04 19:51:41 2.7.1.4 +++ lundump.c 2008/04/04 19:51:41 2.7.1.4
@@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/* /*
-** $Id: bugs,v 1.99 2009/04/27 20:11:11 roberto Exp roberto $ -** $Id: bugs,v 1.100 2009/06/15 14:12:59 roberto Exp roberto $
+** $Id: bugs,v 1.99 2009/04/27 20:11:11 roberto Exp roberto $ +** $Id: bugs,v 1.100 2009/06/15 14:12:59 roberto Exp roberto $
** load precompiled Lua chunks ** load precompiled Lua chunks
** See Copyright Notice in lua.h ** See Copyright Notice in lua.h
*/ */
@ -2060,7 +2060,7 @@ patch = [[
Bug{ Bug{
what = [[internal macro 'svalue' is wrong]], what = [[internal macro 'svalue' is wrong]],
report = [["Martijn van Buul, on 2008/08/04]], report = [[Martijn van Buul, on 2008/08/04]],
since = [[5.1]], since = [[5.1]],
example = [[ example = [[
/* in luaconf.h */ /* in luaconf.h */
@ -2083,7 +2083,7 @@ patch = [[
Bug{ Bug{
what = [[malicious zero-length string in binary code may segfault Lua]], what = [[malicious zero-length string in binary code may segfault Lua]],
report = [["Peter Cawley, on 2008/09/01]], report = [[Peter Cawley, on 2008/09/01]],
since = [[5.1]], since = [[5.1]],
example = [[ example = [[
loadstring(('').dump(function()X''end):gsub('\2%z%z%zX','\0\0\0'))() loadstring(('').dump(function()X''end):gsub('\2%z%z%zX','\0\0\0'))()
@ -2095,7 +2095,7 @@ patch = [[
Bug{ Bug{
what = [[wrong code generation for some particular boolean expressions]], what = [[wrong code generation for some particular boolean expressions]],
report = [["Brian Kelley, on 2009/04/15]], report = [[Brian Kelley, on 2009/04/15]],
since = [[5.0]], since = [[5.0]],
example = [[ example = [[
print(((1 or false) and true) or false) --> 1 print(((1 or false) and true) or false) --> 1
@ -2152,3 +2152,44 @@ patch = [[
]], ]],
} }
Bug{
what = [['luaV_settable' may invalidate a reference to a table and try
to reuse it]],
report = [[Mark Feldman, on 2009/06/27]],
since = [[5.0]],
example = [[
grandparent = {}
grandparent.__newindex = function(s,_,_) print(s) end
parent = {}
parent.__newindex = parent
setmetatable(parent, grandparent)
child = setmetatable({}, parent)
child.foo = 10 --> (crash on some machines)
]],
patch = [[
--- lvm.c 2007/12/28 15:32:23 2.63.1.3
+++ lvm.c 2009/07/01 20:36:59
@@ -133,6 +133,7 @@
void luaV_settable (lua_State *L, const TValue *t, TValue *key, StkId val) {
int loop;
+ TValue temp;
for (loop = 0; loop < MAXTAGLOOP; loop++) {
const TValue *tm;
if (ttistable(t)) { /* `t' is a table? */
@@ -152,7 +153,9 @@
callTM(L, tm, t, key, val);
return;
}
- t = tm; /* else repeat with `tm' */
+ /* else repeat with `tm' */
+ setobj(L, &temp, tm); /* avoid pointing inside table (may rehash) */
+ t = &temp;
}
luaG_runerror(L, "loop in settable");
}
]],
}