From 6fc678148abdc5b8f1d42a6e16944f0798bfa4f8 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Fri, 7 Oct 2022 15:50:33 -0700 Subject: [PATCH] Add comment about variable length GM message, fix comment syntax --- generator/gm/gm_global_a_powertrain.dbc | 1 + generator/honda/honda_civic_ex_2022_can.dbc | 2 +- gm_global_a_powertrain_generated.dbc | 1 + honda_civic_ex_2022_can_generated.dbc | 2 +- 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/generator/gm/gm_global_a_powertrain.dbc b/generator/gm/gm_global_a_powertrain.dbc index 2b6866b..94bf60d 100644 --- a/generator/gm/gm_global_a_powertrain.dbc +++ b/generator/gm/gm_global_a_powertrain.dbc @@ -267,6 +267,7 @@ CM_ BU_ K114B_HPCM "Hybrid Powertrain Control Module"; CM_ BU_ NEO "Comma NEO"; CM_ BU_ K124_ASCM "Active Safety Control Module"; CM_ SG_ 381 MSG17D_AccPower "Need to investigate"; +CM_ BO_ 190 "Length varies from 6 to 8 bytes by car"; CM_ SG_ 190 GasPedalAndAcc "ACC baseline is 62"; CM_ SG_ 352 Ignition "Non-zero when ignition is on"; CM_ SG_ 451 GasPedalAndAcc2 "ACC baseline is 62"; diff --git a/generator/honda/honda_civic_ex_2022_can.dbc b/generator/honda/honda_civic_ex_2022_can.dbc index e4a8fdc..5c7ef6a 100644 --- a/generator/honda/honda_civic_ex_2022_can.dbc +++ b/generator/honda/honda_civic_ex_2022_can.dbc @@ -70,7 +70,7 @@ BO_ 254913108 LKAS_HUD_2: 8 ADAS SG_ COUNTER : 61|2@0+ (1,0) [0|3] "" XXX SG_ CHECKSUM : 59|4@0+ (1,0) [0|15] "" XXX -CM_ BO 456 "not sure which bit enables cruise"; +CM_ BO_ 456 "not sure which bit enables cruise"; CM_ SG_ 456 STANDSTILL "set to 1 when camera requests -4.0 m/s^2"; VAL_ 401 GEAR_SHIFTER 32 "L" 16 "S" 8 "D" 4 "N" 2 "R" 1 "P"; diff --git a/gm_global_a_powertrain_generated.dbc b/gm_global_a_powertrain_generated.dbc index 1e2b76a..f5d6623 100644 --- a/gm_global_a_powertrain_generated.dbc +++ b/gm_global_a_powertrain_generated.dbc @@ -287,6 +287,7 @@ CM_ BU_ K114B_HPCM "Hybrid Powertrain Control Module"; CM_ BU_ NEO "Comma NEO"; CM_ BU_ K124_ASCM "Active Safety Control Module"; CM_ SG_ 381 MSG17D_AccPower "Need to investigate"; +CM_ BO_ 190 "Length varies from 6 to 8 bytes by car"; CM_ SG_ 190 GasPedalAndAcc "ACC baseline is 62"; CM_ SG_ 352 Ignition "Non-zero when ignition is on"; CM_ SG_ 451 GasPedalAndAcc2 "ACC baseline is 62"; diff --git a/honda_civic_ex_2022_can_generated.dbc b/honda_civic_ex_2022_can_generated.dbc index 194c2e9..2b06a4a 100644 --- a/honda_civic_ex_2022_can_generated.dbc +++ b/honda_civic_ex_2022_can_generated.dbc @@ -496,7 +496,7 @@ BO_ 254913108 LKAS_HUD_2: 8 ADAS SG_ COUNTER : 61|2@0+ (1,0) [0|3] "" XXX SG_ CHECKSUM : 59|4@0+ (1,0) [0|15] "" XXX -CM_ BO 456 "not sure which bit enables cruise"; +CM_ BO_ 456 "not sure which bit enables cruise"; CM_ SG_ 456 STANDSTILL "set to 1 when camera requests -4.0 m/s^2"; VAL_ 401 GEAR_SHIFTER 32 "L" 16 "S" 8 "D" 4 "N" 2 "R" 1 "P";