Commit Graph

24 Commits

Author SHA1 Message Date
Dean Lee 8faada0494
refactor CANParser to improve performance (#795)
* reduce the const of copying signal values in CANParser::query_latest

* pass by reference

* use for range loop

* update_strings

* use assign

* track all signals

* use iterator & pointer to avoid copy SignalValue from vector

* use normal dict for vl_all

* update tests

* fix error in merge master

* change thresholds

reduce thresholds

* Trigger CI

* Trigger CI

* Trigger CI

* cleanup ctor

* reduce threshold

* revert changes to test_parser.py

* change thresholds

* remove update_string() from cython

* comment out test_performance_one_signal

* reduce thresholds

* test

* update

* update

* revert that for now

* update

* update

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-04-22 17:54:36 -07:00
Adeeb Shihadeh f50e9d78bd
CANParser: add msg name to debug prints (#813) 2023-04-13 14:48:00 -07:00
Adeeb Shihadeh 06a3e7db6f
add cpplint (#773)
* add cpplint

* passes

* bump cereal

* here's a real hash
2022-12-31 16:49:26 -08:00
Shane Smiskol 1c4deed968
CANParser: move can valid threshold into parser (#690)
* use can_valid flag from parser and make it consider counter checks

* clean up

* don't show incorrect messages

* add comments

* move threshold to cpp parser

* only the refactor in this pr

* fix bug and same logic as old cython wrapper can invalid

* still print everything

* clean up

* whoops

* make these properties

revert that
2022-08-19 16:19:36 -07:00
Adeeb Shihadeh 387dcf9628
teach the packer how to count (#669)
* teach the packer how to count

* fix tests

* same as checksum

* little test
2022-07-21 17:51:49 -07:00
Jason Young 2afccacd52
VW PQ: Message updates, checksum and counter support (#633)
* refactor MQB checksum/counter to prep for PQ

* first pass at PQ checksums and counters

* remove checksum and counter alignment checks

* forgot HCA_1

* Revert "remove checksum and counter alignment checks"

This reverts commit 0d30ee9b854c933bf12ee9ca26ad0b0f29956cea.

* don't check counter offset

* tweak comment

* handle checksum not starting at zero

* remove unused argument

* add LDW_Textbits to LDW_1

* Update can/common.cc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* fix counter again; minimize diff

* additional door-open signals

* add trunk lid state

* update LDW_Status message and signals

* typo

* make XOR checksum generic

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-07-15 10:29:12 -07:00
Jason Young fe6241dcc6
refactor per-manufacturer checksum calculation (#650)
* synchronize function signatures

* if-spaghetti reduction

* add to cython

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-06-30 11:31:58 -07:00
Adeeb Shihadeh 82be71072c
CANParser: invalid until valid (#648)
* CANParser: invalid until valid

* small test
2022-06-22 15:13:59 -07:00
Adeeb Shihadeh 87af8c4ac1 CANParser: wait a couple seconds printing misisng 2022-05-16 21:56:14 -07:00
Adeeb Shihadeh 1599f2e370
Kia EV6 (#567) 2022-05-15 18:26:19 -07:00
Adeeb Shihadeh 004db342a8
CANParser: add flag for bus timeout (#586)
* CANParser: add flag for bus timeout

* bump to 500ms

* 10x most frequent msg

* little test

* per bus

* Update can/parser.cc
2022-04-12 22:34:27 -07:00
Adeeb Shihadeh 859fea7ded
CAN FD support in packer + parser (#568)
* can fd support in packer + parser

* don't need these anymore

* fix pedal crc

* fix dynamic parsing

* cleanup

* packer test
2022-02-28 09:10:34 -08:00
Adeeb Shihadeh 298c830739
Cleanup dead code in CAN parser + packer (#573)
* remove duplicate implementation

* Cleanup dead code in CAN parser + packer

* little more
2022-02-24 22:58:37 -08:00
Shane Smiskol 053a761244
CANParser: add field for all values from a cycle (#558)
* could work

* should be light-speed

* clean up

* clean up

* make sure updated is empty if nothing is updated

updating without a msg is undefined behavior

* should be fast enough

* more test

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-02-10 13:01:30 -08:00
Adeeb Shihadeh 24538ceb04 Revert "CANParser: add field for all updated values (#548)"
This reverts commit da47fe5e45.
2022-02-09 22:01:25 -08:00
Shane Smiskol 6770f1cdfb
CANParser: remove ts field (#557)
more usages
2022-02-09 11:59:15 -08:00
Shane Smiskol da47fe5e45
CANParser: add field for all updated values (#548)
* add updated field

* rename to updated

* draft

* clean up

* function for resetting

* *minor* refactor

* clean up names

* keep track of updated vals in the cc parser

* remove extra lines

* remove ts

* match parser_pyx

* cleaner to just call the cpp function as we don't need to aggregate updated values

* draft

* some tests

* fix test

* clean up

clean up

* test clean up

* add clarifying comments

* Revert "remove ts"

This reverts commit fd4558289d6667a42ab41c4511b0d8fe54eb7fc8.

* fix order

* use vals

* fix dup
2022-02-07 15:36:00 -08:00
Joost Wooning f133708455
Modified can parser to run it from PlotJuggler (#352)
* Modified can parser to run it from PlotJuggler

* Assert for parsing DynamicStruct, can ignore checksum/counter messages

* Only write processed dbc on changes, to prevent cmake compiling

* Do not fail on creating new DBC outputs

* Remove print statement

* outer ignore_checksum and ignore_counter

* whitespace
2021-03-09 16:33:37 +01:00
Dean Lee 419471253a
update_string: use cached buffer (#356) 2021-03-09 16:10:39 +01:00
Dean Lee ec13e51c90
CANParser::update_string :use const std::string& as paramater (#344) 2021-01-30 22:26:30 -08:00
Adeeb 7f3b1774dd
Chrysler: calculate checksum in can packer/parser (#255)
* calculate chrysler checksum in can packer/parser

* remove comment
2020-04-30 14:06:26 -07:00
Adeeb a57e7ddbd7
CANPacker: Subaru checksum support (#241)
* subaru global: use standard checksum signal naming convention

* subaru checksum

* ignore first byte

* update other subaru dbcs

* revert outback changes, checksum is in a different byte
2020-04-13 15:06:28 -07:00
Willem Melching 0ba7926bfe unify can packer and parser 2019-12-03 08:43:05 -08:00
rbiasini e155e01748
Can migration (#199)
* moved CAN to opendbc

* also dbc was needed

* dbc test also added
2019-11-22 21:46:33 -08:00