From 08c1c5d969fe57ec216d89dfb5498c637b11c3dd Mon Sep 17 00:00:00 2001 From: Andrey Date: Tue, 18 Jan 2022 16:01:27 -0500 Subject: [PATCH] Remove legacy check fix #3808 --- firmware/controllers/system/timer/trigger_scheduler.cpp | 4 +--- unit_tests/tests/test_aux_valves.cpp | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/firmware/controllers/system/timer/trigger_scheduler.cpp b/firmware/controllers/system/timer/trigger_scheduler.cpp index 2d16deea3c..89ba493e01 100644 --- a/firmware/controllers/system/timer/trigger_scheduler.cpp +++ b/firmware/controllers/system/timer/trigger_scheduler.cpp @@ -77,9 +77,7 @@ void TriggerScheduler::scheduleEventsUntilNextTriggerTooth(int rpm, uint32_t trgEventIndex, efitick_t edgeTimestamp) { - // Not sure why we check ignitionEnabled; it's left over from when this code lived in - // spark_logic.cpp, but I think it should be removed. - if (!isValidRpm(rpm) || !engineConfiguration->isIgnitionEnabled) { + if (!isValidRpm(rpm)) { // this might happen for instance in case of a single trigger event after a pause return; } diff --git a/unit_tests/tests/test_aux_valves.cpp b/unit_tests/tests/test_aux_valves.cpp index b01ca15e56..e67251bbac 100644 --- a/unit_tests/tests/test_aux_valves.cpp +++ b/unit_tests/tests/test_aux_valves.cpp @@ -24,6 +24,6 @@ TEST(misc, testAuxValves) { eth.assertTriggerEvent("a0", 0, &engine->auxValves[0][0].open, (void*)&auxPlainPinTurnOn, 7, 86); eth.assertTriggerEvent("a1", 1, &engine->auxValves[0][1].open, (void*)&auxPlainPinTurnOn, 3, 86); - eth.assertTriggerEvent("a2", 2, &engine->auxValves[1][0].open, (void*)&auxPlainPinTurnOn, 1, 86); + eth.assertTriggerEvent("a2", 2, &engine->auxValves[1][0].open, (void*)&auxPlainPinTurnOn, 5, 86); }