diff --git a/firmware/controllers/actuators/idle_thread.cpp b/firmware/controllers/actuators/idle_thread.cpp index 98dfe46b47..a2fe5ee8ef 100644 --- a/firmware/controllers/actuators/idle_thread.cpp +++ b/firmware/controllers/actuators/idle_thread.cpp @@ -114,11 +114,11 @@ Pid * getIdlePid() { return &idlePid; } -float getIdlePidOffset() { +float getIdlePidOffset(DECLARE_ENGINE_PARAMETER_SUFFIX) { return getIdlePid()->getOffset(); } -float getIdlePidMinValue() { +float getIdlePidMinValue(DECLARE_ENGINE_PARAMETER_SUFFIX) { return getIdlePid()->getMinValue(); } diff --git a/firmware/controllers/actuators/idle_thread.h b/firmware/controllers/actuators/idle_thread.h index 359ae00a9c..c2c5f8492d 100644 --- a/firmware/controllers/actuators/idle_thread.h +++ b/firmware/controllers/actuators/idle_thread.h @@ -36,6 +36,6 @@ void stopIdleHardware(DECLARE_ENGINE_PARAMETER_SIGNATURE); void initIdleHardware(DECLARE_ENGINE_PARAMETER_SIGNATURE); bool isIdleHardwareRestartNeeded(); void onConfigurationChangeIdleCallback(engine_configuration_s *previousConfiguration); -float getIdlePidOffset(); +float getIdlePidOffset(DECLARE_ENGINE_PARAMETER_SUFFIX); Pid * getIdlePid(); -float getIdlePidMinValue(); +float getIdlePidMinValue(DECLARE_ENGINE_PARAMETER_SUFFIX); diff --git a/unit_tests/tests/test_idle_controller.cpp b/unit_tests/tests/test_idle_controller.cpp index 93ade39796..0e8911fa96 100644 --- a/unit_tests/tests/test_idle_controller.cpp +++ b/unit_tests/tests/test_idle_controller.cpp @@ -43,15 +43,15 @@ TEST(idle, fsioPidParameters) { ASSERT_EQ(1, getAcToggle(PASS_ENGINE_PARAMETER_SIGNATURE)); eth.engine.periodicSlowCallback(PASS_ENGINE_PARAMETER_SIGNATURE); - ASSERT_EQ(40, getIdlePidOffset()); - ASSERT_EQ(30, getIdlePidMinValue()); + ASSERT_EQ(40, getIdlePidOffset(PASS_ENGINE_PARAMETER_SIGNATURE)); + ASSERT_EQ(30, getIdlePidMinValue(PASS_ENGINE_PARAMETER_SIGNATURE)); setMockVoltage(engineConfiguration->acSwitchAdc, 5 PASS_ENGINE_PARAMETER_SUFFIX); ASSERT_EQ(0, getAcToggle(PASS_ENGINE_PARAMETER_SIGNATURE)); eth.engine.periodicSlowCallback(PASS_ENGINE_PARAMETER_SIGNATURE); - ASSERT_EQ(50, getIdlePidOffset()); - ASSERT_EQ(60, getIdlePidMinValue()); + ASSERT_EQ(50, getIdlePidOffset(PASS_ENGINE_PARAMETER_SIGNATURE)); + ASSERT_EQ(60, getIdlePidMinValue(PASS_ENGINE_PARAMETER_SIGNATURE)); // todo finish this unit test!