rusefi
/
rusefi-1
mirror of https://github.com/rusefi/rusefi-1.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FasterEngineSpinUp should be enabled by default fix #4094

This commit is contained in:
rusefillc 2022-04-23 09:51:47 -04:00
parent 7bdb5150b4
commit 14e37e3cf4
17 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
firmware/CHANGELOG.md
View File

@ -23,6 +23,9 @@ Release template (copy/paste this for new release):
# Changelog
### Added
- FasterEngineSpinUp should be enabled by default #4094
## April 20202 Release - "Day 58"
All notable user-facing or behavior-altering changes will be documented in this file.

1
firmware/config/boards/hellen/cypress/board_configuration.cpp
View File

@ -13,7 +13,6 @@
void setBoardDefaultConfiguration() {
setCrankOperationMode();
engineConfiguration->isFasterEngineSpinUpEnabled = true;
engineConfiguration->useNoiselessTriggerDecoder = true;
engineConfiguration->isEngineChartEnabled = false;

1
firmware/config/boards/kinetis/board_configuration.cpp
View File

@ -15,7 +15,6 @@ int __debugEnabled = 0;
#endif
void setBoardOverrides() {
engineConfiguration->isFasterEngineSpinUpEnabled = true;
engineConfiguration->useNoiselessTriggerDecoder = true;
setAlgorithm(LM_SPEED_DENSITY);

1
firmware/config/engines/bmw_m73.cpp
View File

@ -95,7 +95,6 @@ void m73engine() {
strcpy(engineConfiguration->engineMake, ENGINE_MAKE_BMW);
strcpy(engineConfiguration->engineCode, "M73");
engineConfiguration->specs.firingOrder = FO_1_7_5_11_3_9_6_12_2_8_4_10;
engineConfiguration->isFasterEngineSpinUpEnabled = true;
engineConfiguration->fuelAlgorithm = LM_ALPHA_N;
engineConfiguration->canNbcType = CAN_BUS_NBC_NONE;

3
firmware/config/engines/mazda_miata_1_6.cpp
View File

@ -189,9 +189,6 @@ static void miataNAcommonEngineSettings() {
engineConfiguration->idle.solenoidFrequency = 160;
engineConfiguration->ignitionMode = IM_WASTED_SPARK;
engineConfiguration->isFasterEngineSpinUpEnabled = true;
setMapVeTable();
engineConfiguration->idleMode = IM_AUTO;

7
firmware/config/engines/mazda_miata_vvt.cpp
View File

@ -519,9 +519,6 @@ void setMazdaMiata2003EngineConfiguration() {
engineConfiguration->throttlePedalPositionAdcChannel = EFI_ADC_2;
*/
engineConfiguration->isFasterEngineSpinUpEnabled = true;
//set etb_p 12
engineConfiguration->etb.pFactor = 12; // a bit lower p-factor seems to work better on TLE9201? MRE?
engineConfiguration->etb.iFactor = 0;
@ -616,8 +613,6 @@ static void setMiataNB2_MRE_common() {
// todo: AC fan
// TLE8888_PIN_24: "43 - GP Out 4"
engineConfiguration->isFasterEngineSpinUpEnabled = true;
// set_analog_input_pin pps PA7
// EFI_ADC_7: "31 - AN volt 3" - PA7
// disabled for now since only allowed with ETB
@ -784,8 +779,6 @@ void setMiataNB2_ProteusEngineConfiguration() {
engineConfiguration->tps1_1AdcChannel = EFI_ADC_12;
engineConfiguration->isFasterEngineSpinUpEnabled = true;
engineConfiguration->clt.adcChannel = PROTEUS_IN_ANALOG_TEMP_1;
engineConfiguration->iat.adcChannel = PROTEUS_IN_ANALOG_TEMP_3;

2
firmware/controllers/algo/defaults/default_cranking.cpp
View File

@ -18,6 +18,8 @@ void setDefaultCranking() {
engineConfiguration->crankingIACposition = 50;
engineConfiguration->afterCrankingIACtaperDuration = 200;
engineConfiguration->isFasterEngineSpinUpEnabled = true;
// After start enrichment
#if !EFI_UNIT_TEST
// don't set this for unit tests, as it makes things more complicated to test

1
unit_tests/tests/ignition_injection/test_fuel_wall_wetting.cpp
View File

@ -63,6 +63,7 @@ TEST(fuel, testWallWettingEnrichmentMath) {
TEST(fuel, testWallWettingEnrichmentScheduling) {
EngineTestHelper eth(FORD_ASPIRE_1996);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
setCrankOperationMode();
engineConfiguration->useOnlyRisingEdgeForTrigger = true;

1
unit_tests/tests/ignition_injection/test_ignition_scheduling.cpp
View File

@ -39,6 +39,7 @@ TEST(ignition, twoCoils) {
TEST(ignition, trailingSpark) {
EngineTestHelper eth(TEST_ENGINE);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
/**
// TODO #3220: this feature makes this test sad, eventually remove this line (and the ability to disable it altogether)

1
unit_tests/tests/ignition_injection/test_one_cylinder_logic.cpp
View File

@ -8,6 +8,7 @@
TEST(issues, issueOneCylinderSpecialCase968) {
EngineTestHelper eth(GY6_139QMB);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
engine->tdcMarkEnabled = false;
// set injection_mode 1
engineConfiguration->injectionMode = IM_SEQUENTIAL;

2
unit_tests/tests/ignition_injection/test_startOfCrankingPrimingPulse.cpp
View File

@ -9,7 +9,7 @@
TEST(engine, testPlainCrankingWithoutAdvancedFeatures) {
EngineTestHelper eth(TEST_ENGINE);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
engine->tdcMarkEnabled = false;
engineConfiguration->cranking.baseFuel = 12;

1
unit_tests/tests/trigger/test_2jz_vvt.cpp
View File

@ -10,6 +10,7 @@
TEST(sensors, test2jz) {
EngineTestHelper eth(TOYOTA_2JZ_GTE_VVTi);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
// this crank trigger would be easier to test, crank shape is less important for this test

1
unit_tests/tests/trigger/test_map_cam.cpp
View File

@ -6,6 +6,7 @@
TEST(trigger, map_cam_by_magic_point) {
EngineTestHelper eth(TEST_CRANK_ENGINE);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
engineConfiguration->camInputs[0] = GPIOA_0;
engineConfiguration->vvtMode[0] = VVT_MAP_V_TWIN_ANOTHER;

1
unit_tests/tests/trigger/test_nissan_vq_vvt.cpp
View File

@ -73,6 +73,7 @@ TEST(nissan, vq_vvt) {
std::vector<std::shared_ptr<TriggerCallback>> ptrs;
EngineTestHelper eth (HELLEN_121_NISSAN_6_CYL);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
engineConfiguration->isIgnitionEnabled = false;
engineConfiguration->isInjectionEnabled = false;

1
unit_tests/tests/trigger/test_quad_cam.cpp
View File

@ -8,6 +8,7 @@
TEST(trigger, testQuadCam) {
// setting some weird engine
EngineTestHelper eth(FORD_ESCORT_GT);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
setCrankOperationMode();

1
unit_tests/tests/trigger/test_real_cranking_nissan_vq40.cpp
View File

@ -14,6 +14,7 @@ TEST(realCrankingVQ40, normalCranking) {
reader.open("tests/trigger/resources/nissan_vq40_cranking-1.csv", indeces);
EngineTestHelper eth (HELLEN_121_NISSAN_6_CYL);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
bool hasSeenFirstVvt = false;

4
unit_tests/tests/trigger/test_trigger_decoder.cpp
View File

@ -149,6 +149,7 @@ TEST(trigger, test1995FordInline6TriggerDecoder) {
ASSERT_EQ( 0, getTriggerZeroEventIndex(FORD_INLINE_6_1995)) << "triggerIndex ";
EngineTestHelper eth(FORD_INLINE_6_1995);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
setWholeTimingTable(-13);
Sensor::setMockValue(SensorType::Iat, 49.579071f);
@ -645,6 +646,7 @@ void doTestFuelSchedulerBug299smallAndMedium(int startUpDelayMs) {
printf("*************************************************** testFuelSchedulerBug299 small to medium\r\n");
EngineTestHelper eth(TEST_ENGINE);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
engine->tdcMarkEnabled = false;
eth.moveTimeForwardMs(startUpDelayMs); // nice to know that same test works the same with different anount of idle time on start
setTestBug299(&eth);
@ -946,6 +948,7 @@ TEST(big, testSequential) {
TEST(big, testFuelSchedulerBug299smallAndLarge) {
EngineTestHelper eth(TEST_ENGINE);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
engine->tdcMarkEnabled = false;
setTestBug299(&eth);
ASSERT_EQ( 4, engine->executor.size()) << "Lqs#0";
@ -1063,6 +1066,7 @@ TEST(big, testSparkReverseOrderBug319) {
printf("*************************************************** testSparkReverseOrderBug319 small to medium\r\n");
EngineTestHelper eth(TEST_ENGINE);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
engine->tdcMarkEnabled = false;
engineConfiguration->useOnlyRisingEdgeForTrigger = false;