rusefi
/
rusefi-1
mirror of https://github.com/rusefi/rusefi-1.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

https://rusefi.com/forum/viewtopic.php?p=37401#p37401

This commit is contained in:
rusefi 2020-07-10 14:19:51 -04:00
parent ebb5b00315
commit 29e3c71df4
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/controllers/actuators/idle_thread.cpp
View File

@ -75,7 +75,7 @@ static bool mightResetPid = false;
PidCic idlePid; PidCic idlePid;
#else #else
class PidWithOverrides : public Pid { class PidWithOverrides : public PidIndustrial {
public: public:
float getOffset() const override { float getOffset() const override {
#if EFI_UNIT_TEST #if EFI_UNIT_TEST

1
firmware/controllers/algo/engine_configuration.cpp
View File

@ -1450,7 +1450,6 @@ void validateConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
engineConfiguration->cltIdleRpmBins[i] = fixNegativeZero(engineConfiguration->cltIdleRpmBins[i]); engineConfiguration->cltIdleRpmBins[i] = fixNegativeZero(engineConfiguration->cltIdleRpmBins[i]);
} }
// having zeros in unsued fields is important for REO CRC match // having zeros in unsued fields is important for REO CRC match
engineConfiguration->unusedAt516 = 0;
engineConfiguration->unusedAt712 = 0; engineConfiguration->unusedAt712 = 0;
engineConfiguration->unusedAt716 = 0; engineConfiguration->unusedAt716 = 0;
engineConfiguration->unusedAt720 = 0; engineConfiguration->unusedAt720 = 0;

5
firmware/util/math/pid.h
View File

@ -30,6 +30,9 @@
struct pid_s; struct pid_s;
class Logging; class Logging;
/**
* default basic implementation also known as PidParallelController
*/
class Pid : public pid_state_s { class Pid : public pid_state_s {
public: public:
@ -110,6 +113,8 @@ private:
* See: Wittenmark B., Astrom K., Arzen K. IFAC Professional Brief. Computer Control: An Overview. * See: Wittenmark B., Astrom K., Arzen K. IFAC Professional Brief. Computer Control: An Overview.
* Two additional parameters used: derivativeFilterLoss and antiwindupFreq * Two additional parameters used: derivativeFilterLoss and antiwindupFreq
* (If both are 0, then this controller is identical to PidParallelController) * (If both are 0, then this controller is identical to PidParallelController)
*
* TODO: should PidIndustrial replace all usages of Pid/PidParallelController?
*/ */
class PidIndustrial : public Pid { class PidIndustrial : public Pid {
public: public: