From 2bbc5feef4a08047ba4872200d0f1b32e05d9dee Mon Sep 17 00:00:00 2001 From: rusefi Date: Mon, 14 Jan 2019 00:21:08 -0500 Subject: [PATCH] minor improvement --- firmware/controllers/trigger/trigger_decoder.cpp | 5 ++++- unit_tests/tests/test_fasterEngineSpinningUp.cpp | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/firmware/controllers/trigger/trigger_decoder.cpp b/firmware/controllers/trigger/trigger_decoder.cpp index 2b384c804a..11ef4b02b0 100644 --- a/firmware/controllers/trigger/trigger_decoder.cpp +++ b/firmware/controllers/trigger/trigger_decoder.cpp @@ -125,7 +125,10 @@ int TriggerState::getTotalRevolutionCounter() { return totalRevolutionCounter; } -TriggerStateWithRunningStatistics::TriggerStateWithRunningStatistics() { +TriggerStateWithRunningStatistics::TriggerStateWithRunningStatistics() : + //https://en.cppreference.com/w/cpp/language/zero_initialization + instantRpmValue() + { // avoid ill-defined instant RPM when the data is not gathered yet efitime_t nowNt = getTimeNowNt(); for (int i = 0; i < PWM_PHASE_MAX_COUNT; i++) { diff --git a/unit_tests/tests/test_fasterEngineSpinningUp.cpp b/unit_tests/tests/test_fasterEngineSpinningUp.cpp index 895b39c5bd..1731724cbf 100644 --- a/unit_tests/tests/test_fasterEngineSpinningUp.cpp +++ b/unit_tests/tests/test_fasterEngineSpinningUp.cpp @@ -37,6 +37,7 @@ TEST(sensors, testFasterEngineSpinningUp) { // check all events starting from now int timeStartUs = eth.getTimeNowUs(); // advance 1 revolution + // because we have trivial TT_ONE trigger here synchronization would happen with just one rise front eth.fireRise(200); // check if the mode is changed