From 37c502120f01e44401a2b62c3954345a2a00f22d Mon Sep 17 00:00:00 2001
From: Matthew Kennedy <matthewkennedy@outlook.com>
Date: Tue, 22 Dec 2020 06:23:17 -0800
Subject: [PATCH] test switching ignition modes (#2113)

---
 .../src/com/rusefi/FunctionalTest.java        | 74 +++++++++++++++++++
 1 file changed, 74 insertions(+)

diff --git a/java_console/autotest/src/com/rusefi/FunctionalTest.java b/java_console/autotest/src/com/rusefi/FunctionalTest.java
index 24c4cd42be..0f64b4b80c 100644
--- a/java_console/autotest/src/com/rusefi/FunctionalTest.java
+++ b/java_console/autotest/src/com/rusefi/FunctionalTest.java
@@ -30,6 +30,76 @@ public class FunctionalTest {
         ecu = EcuTestHelper.createInstance();
     }
 
+	@Test
+	public void testChangingIgnitionMode() {
+		String msg = "change ign mode";
+
+		ecu.setEngineType(ET_FORD_FIESTA);
+		ecu.changeRpm(2000);
+
+		// First is wasted spark
+		ecu.sendCommand("set ignition_mode 2");
+
+		{
+			// Check that we're in wasted spark mode
+			EngineChart chart = nextChart();
+
+			// Wasted spark should fire cylinders 1/3...
+            assertWaveNotNull(chart, EngineChart.SPARK_1);
+            assertWaveNotNull(chart, EngineChart.SPARK_3);
+
+            // ...but not cylinders 2/4
+            assertWaveNull(chart, EngineChart.SPARK_2);
+			assertWaveNull(chart, EngineChart.SPARK_4);
+		}
+
+		// Now switch to sequential mode
+		ecu.sendCommand("set ignition_mode 1");
+
+		{
+			// Check that we're in sequential spark mode
+			EngineChart chart = nextChart();
+
+			// All 4 cylinders should be firing
+			assertWaveNotNull(chart, EngineChart.SPARK_1);
+            assertWaveNotNull(chart, EngineChart.SPARK_2);
+            assertWaveNotNull(chart, EngineChart.SPARK_3);
+			assertWaveNotNull(chart, EngineChart.SPARK_4);
+		}
+
+		// Now switch to "one coil" mode
+        ecu.sendCommand("set ignition_mode 0");
+
+        {
+            // Check that we're in sequential spark mode
+            EngineChart chart = nextChart();
+
+            // Only coil 1 should be active
+            assertWaveNotNull(chart, EngineChart.SPARK_1);
+
+            // And no others
+            assertWaveNull(chart, EngineChart.SPARK_2);
+            assertWaveNull(chart, EngineChart.SPARK_3);
+            assertWaveNull(chart, EngineChart.SPARK_4);
+        }
+
+		// Now switch BACK to wasted mode
+		ecu.sendCommand("set ignition_mode 2");
+
+		{
+			// Check that we're in wasted spark mode
+			EngineChart chart = nextChart();
+
+            // Wasted spark should fire cylinders 1/3...
+            assertWaveNotNull(chart, EngineChart.SPARK_1);
+            assertWaveNotNull(chart, EngineChart.SPARK_3);
+
+            // ...but not cylinders 2/4
+            assertWaveNull(chart, EngineChart.SPARK_2);
+            assertWaveNull(msg, chart, EngineChart.SPARK_4);
+		}
+	}
+
     @Test
     public void testCustomEngine() {
         ecu.setEngineType(ET_DEFAULT_FRANKENSO);
@@ -399,6 +469,10 @@ public class FunctionalTest {
         assertNull(msg + "chart for " + key, chart.get(key));
     }
 
+    private static void assertWaveNotNull(EngineChart chart, String key) {
+        assertTrue(chart.get(key) != null);
+    }
+
     private EngineChart nextChart() {
         return TestingUtils.nextChart(ecu.commandQueue);
     }