diff --git a/firmware/controllers/error_handling.cpp b/firmware/controllers/error_handling.cpp index 162ed2817d..854de7ffcd 100644 --- a/firmware/controllers/error_handling.cpp +++ b/firmware/controllers/error_handling.cpp @@ -37,6 +37,7 @@ void chDbgPanic3(const char *msg, const char * file, int line) { /** * low-level function is used here to reduce stack usage */ + // todo: extract a macro for this palWritePad(LED_ERROR_PORT, LED_ERROR_PIN, 1); turnAllPinsOff(); #if EFI_HD44780_LCD diff --git a/firmware/rusefi.cpp b/firmware/rusefi.cpp index 55e730726e..3e34d507c7 100644 --- a/firmware/rusefi.cpp +++ b/firmware/rusefi.cpp @@ -230,6 +230,8 @@ extern engine_pins_s enginePins; void firmwareError(const char *errorMsg, ...) { if (hasFirmwareErrorFlag) return; + // todo: extract a macro and use the same macro here and in + // the other place where we have palWritePad(LED_ERROR_PORT, LED_ERROR_PIN, 1); enginePins.errorLedPin.setValue(1); turnAllPinsOff(); hasFirmwareErrorFlag = TRUE;