From 41fa8bdcec26f2dde3350960928de3e74cc78040 Mon Sep 17 00:00:00 2001 From: rusefi Date: Thu, 4 Apr 2019 20:03:31 -0400 Subject: [PATCH] we need TLE8888 driver #714 --- firmware/hw_layer/drivers/gpio/tle8888.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/firmware/hw_layer/drivers/gpio/tle8888.c b/firmware/hw_layer/drivers/gpio/tle8888.c index 81cb97c664..4432993e83 100644 --- a/firmware/hw_layer/drivers/gpio/tle8888.c +++ b/firmware/hw_layer/drivers/gpio/tle8888.c @@ -148,9 +148,12 @@ int tle8888_chip_init(void * data) ret = markUsed(cfg->spi_config.ssport, cfg->spi_config.sspad, DRIVER_NAME " CS"); if (cfg->reset.port != NULL) ret |= markUsed(cfg->reset.port, cfg->reset.pad, DRIVER_NAME " RST"); + /* + error: iteration 4 invokes undefined behavior [-Werror=aggressive-loop-optimizations] for (i = 0; i < TLE8888_DIRECT_OUTPUTS; i++) if (cfg->direct_io[i].port) ret |= markUsed(cfg->direct_io[i].port, cfg->direct_io[i].pad, DRIVER_NAME " DIRECT IO"); +*/ if (ret) { ret = -1; goto err_gpios; @@ -233,7 +236,7 @@ int tle8888_add(unsigned int index, const struct tle8888_config *cfg) osalDbgCheck((cfg != NULL) && (cfg->spi_bus != NULL) && (index < BOARD_TLE8888_COUNT)); /* check for valid cs. - * DOTO: remove this check? CS can be driven by SPI */ + * TODO: remove this check? CS can be driven by SPI */ if (cfg->spi_config.ssport == NULL) return -1;