60/2 VW trigger has running issue on 19/10/19 snapshot fix #986

firmware/controllers/actuators/idle_thread.cpp

@@ -581,6 +581,11 @@ void startIdleThread(Logging*sharedLogger DECLARE_ENGINE_PARAMETER_SUFFIX) {
 
 	idlePid.initPidClass(&engineConfiguration->idleRpmPid);
 
+#if ! EFI_UNIT_TEST
+	// todo: we still have to explicitly init all hardware on start in addition to handling configuration change via
+	// 'applyNewHardwareSettings' todo: maybe unify these two use-cases?
+	initIdleHardware(PASS_ENGINE_PARAMETER_SIGNATURE);
+#endif /* EFI_UNIT_TEST */
 
 	DISPLAY_STATE(Engine)
 	DISPLAY_TEXT(Idle_State);

firmware/controllers/algo/engine_configuration.cpp

@@ -159,6 +159,8 @@ extern LoggingWithStorage sharedLogger;
 /**
  * this is the top-level method which should be called in case of any changes to engine configuration
  * online tuning of most values in the maps does not count as configuration change, but 'Burn' command does
+ *
+ * this method is NOT currently invoked on ECU start - actual user input has to happen!
  */
 void incrementGlobalConfigurationVersion(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
 	ENGINE(globalConfigurationVersion++);

firmware/controllers/engine_controller.cpp

@@ -839,6 +839,6 @@ int getRusEfiVersion(void) {
 	if (initBootloader() != 0)
 		return 123;
 #endif /* EFI_BOOTLOADER_INCLUDE_CODE */
-	return 20191029;
+	return 20191030;
 }
 #endif /* EFI_UNIT_TEST */

firmware/hw_layer/hardware.cpp

@@ -268,6 +268,10 @@ void stopSpi(spi_device_e device) {
 #endif /* HAL_USE_SPI */
 }
 
+/**
+ * this method is NOT currently invoked on ECU start
+ * todo: maybe start invoking this method on ECU start so that peripheral start-up initialization and restart are unified?
+ */
 void applyNewHardwareSettings(void) {
     // all 'stop' methods need to go before we begin starting pins