rusefi
/
rusefi-1
mirror of https://github.com/rusefi/rusefi-1.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactoring

This commit is contained in:
rusefi 2017-04-29 14:40:55 -04:00
parent 7c39715483
commit 4df9e89afd
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
firmware/controllers/idle_thread.cpp
View File

@ -100,9 +100,9 @@ static void setIdleValvePwm(percent_t value) {
idleSolenoid.setSimplePwmDutyCycle(value / 100); idleSolenoid.setSimplePwmDutyCycle(value / 100);
} }
static void manualIdleController(int positionPercent) { static void manualIdleController() {
// todo: this is not great that we have to write into configuration here
boardConfiguration->manIdlePosition = positionPercent; int positionPercent = boardConfiguration->manIdlePosition;
if (isCranking()) { if (isCranking()) {
positionPercent += engineConfiguration->crankingIdleAdjustment; positionPercent += engineConfiguration->crankingIdleAdjustment;
@ -137,7 +137,9 @@ void setIdleValvePosition(int positionPercent) {
return; return;
scheduleMsg(logger, "setting idle valve position %d", positionPercent); scheduleMsg(logger, "setting idle valve position %d", positionPercent);
showIdleInfo(); showIdleInfo();
manualIdleController(positionPercent); // todo: this is not great that we have to write into configuration here
boardConfiguration->manIdlePosition = positionPercent;
manualIdleController();
} }
static int idlePositionBeforeBlip; static int idlePositionBeforeBlip;
@ -221,7 +223,7 @@ static msg_t ivThread(int param) {
if (engineConfiguration->idleMode == IM_MANUAL) { if (engineConfiguration->idleMode == IM_MANUAL) {
// let's re-apply CLT correction // let's re-apply CLT correction
manualIdleController(boardConfiguration->manIdlePosition); manualIdleController();
} else { } else {
autoIdle(); autoIdle();
} }