refactoring - removing unused parameter

firmware/console/status_loop.cpp

@@ -436,7 +436,7 @@ extern fatal_msg_t errorMessageBuffer;
 /**
  * @brief Sends all pending data to dev console
  */
-void updateDevConsoleState(Engine *engine) {
+void updateDevConsoleState(void) {
 	if (!isCommandLineConsoleReady()) {
 		return;
 	}
@@ -862,7 +862,7 @@ static void unsubscribe(int outputOrdinal) {
 	subscription[outputOrdinal] = false;
 }
 
-void initStatusLoop(Engine *engine) {
+void initStatusLoop(void) {
 	setFullLog(INITIAL_FULL_LOG);
 	addConsoleActionI(FULL_LOGGING_KEY, setFullLog);
 	addConsoleActionI("warn", setWarningEnabled);
@@ -888,9 +888,9 @@ void initStatusLoop(Engine *engine) {
 #endif /* EFI_PROD_CODE */
 }
 
-void startStatusThreads(Engine *engine) {
+void startStatusThreads(void) {
 	// todo: refactoring needed, this file should probably be split into pieces
-	chThdCreateStatic(lcdThreadStack, sizeof(lcdThreadStack), NORMALPRIO, (tfunc_t) lcdThread, engine);
+	chThdCreateStatic(lcdThreadStack, sizeof(lcdThreadStack), NORMALPRIO, (tfunc_t) lcdThread, NULL);
 #if EFI_PROD_CODE || defined(__DOXYGEN__)
 	initStatusLeds();
 	chThdCreateStatic(blinkingStack, sizeof(blinkingStack), NORMALPRIO, (tfunc_t) blinkingThread, NULL);

firmware/console/status_loop.h

@@ -10,10 +10,10 @@
 
 #include "engine.h"
 
-void updateDevConsoleState(Engine *engine);
+void updateDevConsoleState(void);
 void prepareTunerStudioOutputs(void);
-void startStatusThreads(Engine *engine);
-void initStatusLoop(Engine *engine);
+void startStatusThreads(void);
+void initStatusLoop(void);
 void writeLogLine(void);
 bool getFullLog(void);
 void setFullLog(int value);

firmware/rusefi.cpp

@@ -195,7 +195,7 @@ void runRusEfi(void) {
 	 */
 	initHardware(&sharedLogger);
 
-	initStatusLoop(engine);
+	initStatusLoop();
 	/**
 	 * Now let's initialize actual engine control logic
 	 * todo: should we initialize some? most? controllers before hardware?
@@ -209,7 +209,7 @@ void runRusEfi(void) {
 #if EFI_ENGINE_EMULATOR || defined(__DOXYGEN__)
 	initEngineEmulator(&sharedLogger, engine);
 #endif
-	startStatusThreads(engine);
+	startStatusThreads();
 
 	rememberCurrentConfiguration();
 
@@ -224,7 +224,7 @@ void runRusEfi(void) {
 
 #if (EFI_CLI_SUPPORT && !EFI_UART_ECHO_TEST_MODE) || defined(__DOXYGEN__)
 		// sensor state + all pending messages for our own dev console
-		updateDevConsoleState(engine);
+		updateDevConsoleState();
 #endif /* EFI_CLI_SUPPORT */
 
 		chThdSleepMilliseconds(boardConfiguration->consoleLoopPeriod);
@@ -250,5 +250,5 @@ int getRusEfiVersion(void) {
 		return 123; // this is here to make the compiler happy about the unused array
 	if (UNUSED_CCM_SIZE[0] * 0 != 0)
 		return 3211; // this is here to make the compiler happy about the unused array
-	return 20170408;
+	return 20170409;
 }

win32_functional_tests/simulator/rusEfiFunctionalTest.cpp

@@ -96,7 +96,7 @@ void rusEfiFunctionalTest(void) {
 
 	initializeConsole(&sharedLogger);
 
-	initStatusLoop(engine);
+	initStatusLoop();
 	initDataStructures(PASS_ENGINE_PARAMETER_F);
 
 
@@ -124,7 +124,7 @@ void rusEfiFunctionalTest(void) {
 
 	initMainEventListener(&sharedLogger, engine);
 
-	startStatusThreads(engine);
+	startStatusThreads();
 
 	runChprintfTest();
 
@@ -135,7 +135,7 @@ void rusEfiFunctionalTest(void) {
 }
 
 void printPendingMessages(void) {
-	updateDevConsoleState(engine);
+	updateDevConsoleState();
 	waveChart.publishIfFull();
 }